From patchwork Thu Dec 18 16:20:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 5515071 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 158839F507 for ; Thu, 18 Dec 2014 16:37:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3D357209EA for ; Thu, 18 Dec 2014 16:37:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7127120A14 for ; Thu, 18 Dec 2014 16:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbaLRQhS (ORCPT ); Thu, 18 Dec 2014 11:37:18 -0500 Received: from resqmta-po-05v.sys.comcast.net ([96.114.154.164]:35609 "EHLO resqmta-po-05v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbaLRQhQ (ORCPT ); Thu, 18 Dec 2014 11:37:16 -0500 X-Greylist: delayed 492 seconds by postgrey-1.27 at vger.kernel.org; Thu, 18 Dec 2014 11:37:16 EST Received: from resomta-po-11v.sys.comcast.net ([96.114.154.235]) by resqmta-po-05v.sys.comcast.net with comcast id V4Un1p00454zqzk014V4Y8; Thu, 18 Dec 2014 16:29:04 +0000 Received: from mail.gonehiking.org ([50.134.149.16]) by resomta-po-11v.sys.comcast.net with comcast id V4V21p00Z0MU7Qa014V3qL; Thu, 18 Dec 2014 16:29:04 +0000 Received: from lorien.internal (lorien-wl.internal [192.168.1.40]) by mail.gonehiking.org (Postfix) with ESMTP id A62EE40A89; Thu, 18 Dec 2014 09:20:16 -0700 (MST) From: Shuah Khan To: m.chehab@samsung.com, hans.verkuil@cisco.com, dheitmueller@kernellabs.com, prabhakar.csengg@gmail.com, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, ttmesterr@gmail.com Cc: Shuah Khan , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] media: au0828 change to not zero out fmt.pix.priv Date: Thu, 18 Dec 2014 09:20:11 -0700 Message-Id: <54b748fa5cb6883d6ce348c38328161409c1f1be.1418918402.git.shuahkh@osg.samsung.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: References: In-Reply-To: References: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1418920144; bh=M6p+RAeRVTHJmo4fS/QqdaLVsHHy8NiVJn2DEKO32Pc=; h=Received:Received:Received:From:To:Subject:Date:Message-Id; b=Kr3Y4HixNifO9mqvfaICSnxEd8SE1nT/rbZcb131Qe9PWGWQPUoePniQYRBObUCpk S5s9OgZmIZt52pGSNLbV6Y/S3aqNqaHyDF8uZoFPcFkt/YsJVCsmOUi35tl/NAUF7j xmw3FwSsJpCb04XmlrM6i9BjlXbLGC6kKzhBcJbD9AM6FKP1rcngjvATUskqKqIpBI +8elLss/I1FSSOK0soTzJtPwNuz1npeZfuc0Ee4gKXbTBE/CsQTQT4HNpu/Jw5OWep OvIgd+nmkys2ety2ZEPJn4H+mslAwlorNp5my1E2P/NpdaMG4MYJrpKwaWd8zLrUqV tKH8Q+E3Rq0mg== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap() vidioc_try_fmt_vid_cap(), and vidioc_s_fmt_vid_cap(). Remove it. Signed-off-by: Shuah Khan Acked-by: Hans Verkuil Acked-by: Lad, Prabhakar --- drivers/media/usb/au0828/au0828-video.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c index 3011ca8..ef49b2e 100644 --- a/drivers/media/usb/au0828/au0828-video.c +++ b/drivers/media/usb/au0828/au0828-video.c @@ -1104,7 +1104,6 @@ static int au0828_set_format(struct au0828_dev *dev, unsigned int cmd, format->fmt.pix.sizeimage = width * height * 2; format->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; format->fmt.pix.field = V4L2_FIELD_INTERLACED; - format->fmt.pix.priv = 0; if (cmd == VIDIOC_TRY_FMT) return 0; @@ -1189,7 +1188,6 @@ static int vidioc_g_fmt_vid_cap(struct file *file, void *priv, f->fmt.pix.sizeimage = dev->frame_size; f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; /* NTSC/PAL */ f->fmt.pix.field = V4L2_FIELD_INTERLACED; - f->fmt.pix.priv = 0; return 0; }