From patchwork Thu Oct 29 21:18:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 7521131 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A98F79F37F for ; Thu, 29 Oct 2015 21:23:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E0B802061D for ; Thu, 29 Oct 2015 21:23:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A2DE20617 for ; Thu, 29 Oct 2015 21:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758064AbbJ2VXh (ORCPT ); Thu, 29 Oct 2015 17:23:37 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37573 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757914AbbJ2VXg (ORCPT ); Thu, 29 Oct 2015 17:23:36 -0400 Received: by wmff134 with SMTP id f134so33247795wmf.0 for ; Thu, 29 Oct 2015 14:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:cc:message-id:date:user-agent:mime-version :content-type:content-transfer-encoding; bh=rPpNnq/Dch5wDz449qhm4sIo1MhrKezQHYp2HjapVaY=; b=06804Q7+lKkHXpjxbK/wySIQ2yiP4SoCrBIZY1xJGhz7MNgALw9ozSQeZFWHzoj9CS aZlxeQP8IfBWOQz5q7OgjFdUp6UmHPmXXV5Gk0hWtWyri/cBcJc9dygsJmktpVfYayiM 9kYUajPBylOxNjEI81p+uzHuy6zkDmT/BZansb4i4zd3iSfUA6FLp4WcSfraqnJbaluI 6mBFw1flZu/ZjEjyvBFtbHEC0eJenKqBsdlGUv+CZsHM4dmVpshTiiQwpPTv1+Mlhrb1 S+tsETq0iKJYC0s5QwM8mZe4XWFNp4ZodiRtXZegjVLZ/8nfIwEyrhH5jlQoEIKTbwT2 SyBw== X-Received: by 10.28.215.205 with SMTP id o196mr6564464wmg.95.1446153815210; Thu, 29 Oct 2015 14:23:35 -0700 (PDT) Received: from ?IPv6:2003:62:5f55:ba00:14ec:a654:7de1:4720? (p200300625F55BA0014ECA6547DE14720.dip0.t-ipconnect.de. [2003:62:5f55:ba00:14ec:a654:7de1:4720]) by smtp.googlemail.com with ESMTPSA id u64sm5435322wmd.6.2015.10.29.14.23.34 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 29 Oct 2015 14:23:34 -0700 (PDT) From: Heiner Kallweit Subject: [PATCH 1/9] media: rc: nuvoton-cir: remove unneeded IRQ_RETVAL usage To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Message-ID: <56328D35.3070908@gmail.com> Date: Thu, 29 Oct 2015 22:18:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using IRQ_RETVAL is unneeded here. IRQ_NONE / IRQ_HANDLED can be returned directly. Signed-off-by: Heiner Kallweit --- drivers/media/rc/nuvoton-cir.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/rc/nuvoton-cir.c b/drivers/media/rc/nuvoton-cir.c index 85af7a8..3d9a4cf 100644 --- a/drivers/media/rc/nuvoton-cir.c +++ b/drivers/media/rc/nuvoton-cir.c @@ -779,7 +779,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) if (!status) { nvt_dbg_verbose("%s exiting, IRSTS 0x0", __func__); nvt_cir_reg_write(nvt, 0xff, CIR_IRSTS); - return IRQ_RETVAL(IRQ_NONE); + return IRQ_NONE; } /* ack/clear all irq flags we've got */ @@ -790,7 +790,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) iren = nvt_cir_reg_read(nvt, CIR_IREN); if (!iren) { nvt_dbg_verbose("%s exiting, CIR not enabled", __func__); - return IRQ_RETVAL(IRQ_NONE); + return IRQ_NONE; } if (debug) @@ -853,7 +853,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) } nvt_dbg_verbose("%s done", __func__); - return IRQ_RETVAL(IRQ_HANDLED); + return IRQ_HANDLED; } /* Interrupt service routine for CIR Wake */ @@ -867,7 +867,7 @@ static irqreturn_t nvt_cir_wake_isr(int irq, void *data) status = nvt_cir_wake_reg_read(nvt, CIR_WAKE_IRSTS); if (!status) - return IRQ_RETVAL(IRQ_NONE); + return IRQ_NONE; if (status & CIR_WAKE_IRSTS_IR_PENDING) nvt_clear_cir_wake_fifo(nvt); @@ -879,7 +879,7 @@ static irqreturn_t nvt_cir_wake_isr(int irq, void *data) iren = nvt_cir_wake_reg_read(nvt, CIR_WAKE_IREN); if (!iren) { nvt_dbg_wake("%s exiting, wake not enabled", __func__); - return IRQ_RETVAL(IRQ_HANDLED); + return IRQ_HANDLED; } if ((status & CIR_WAKE_IRSTS_PE) && @@ -896,7 +896,7 @@ static irqreturn_t nvt_cir_wake_isr(int irq, void *data) } nvt_dbg_wake("%s done", __func__); - return IRQ_RETVAL(IRQ_HANDLED); + return IRQ_HANDLED; } static void nvt_enable_cir(struct nvt_dev *nvt)