From patchwork Thu Oct 29 21:19:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 7521141 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 577A6BEEA4 for ; Thu, 29 Oct 2015 21:23:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2F79A2060A for ; Thu, 29 Oct 2015 21:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4754120617 for ; Thu, 29 Oct 2015 21:23:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758061AbbJ2VXi (ORCPT ); Thu, 29 Oct 2015 17:23:38 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33103 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758063AbbJ2VXh (ORCPT ); Thu, 29 Oct 2015 17:23:37 -0400 Received: by wmeg8 with SMTP id g8so32456783wme.0 for ; Thu, 29 Oct 2015 14:23:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:cc:message-id:date:user-agent:mime-version :content-type:content-transfer-encoding; bh=PNPtImcUB0ltnYpfoKqzpLQc/ViX15kqNM4uWpkfngs=; b=eGXBM+tmWF6B6bG0qOWQwox7XWPg50N5gqQ3YBC6c5F4ZBnY31qJ9aCCdCdyhX6x5B zUYFto0NGMfczkeSIOwVkmxHlhw88fV8l/jtbQ0Q0ZafwCWmX0tYOOA4e5Kfh+AcoIrY PpSHQBxmAhO+ii+sAN1iiDS1z1k9qh3RrzcCfqMiTuo3RBLAhZMS8WhavSKx4DIIOk+R hVyKl8Rb4DIhH70noJohfq/Esft4jBv6VU0/73+Zv4Z63juBh8I5236fysQca0Fmf8rE TvV/W7gxoPkuiD0nokiZ4lk5kFPXUGacvAWsTcq3F9cPTJW3djrjtLuXy+EapIhMsutX 5bUw== X-Received: by 10.28.212.8 with SMTP id l8mr6654776wmg.32.1446153816322; Thu, 29 Oct 2015 14:23:36 -0700 (PDT) Received: from ?IPv6:2003:62:5f55:ba00:14ec:a654:7de1:4720? (p200300625F55BA0014ECA6547DE14720.dip0.t-ipconnect.de. [2003:62:5f55:ba00:14ec:a654:7de1:4720]) by smtp.googlemail.com with ESMTPSA id iw8sm3736615wjb.5.2015.10.29.14.23.35 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 29 Oct 2015 14:23:35 -0700 (PDT) From: Heiner Kallweit Subject: [PATCH 2/9] media: rc: nuvoton-cir: remove unneeded lock To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Message-ID: <56328D57.5000304@gmail.com> Date: Thu, 29 Oct 2015 22:19:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP chip_major / chip_minor are accessed sequentially in probe only. Therefore no lock is needed. Signed-off-by: Heiner Kallweit --- drivers/media/rc/nuvoton-cir.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/rc/nuvoton-cir.c b/drivers/media/rc/nuvoton-cir.c index 3d9a4cf..4d8e12f 100644 --- a/drivers/media/rc/nuvoton-cir.c +++ b/drivers/media/rc/nuvoton-cir.c @@ -227,7 +227,6 @@ static void cir_wake_dump_regs(struct nvt_dev *nvt) /* detect hardware features */ static int nvt_hw_detect(struct nvt_dev *nvt) { - unsigned long flags; u8 chip_major, chip_minor; char chip_id[12]; bool chip_unknown = false; @@ -279,10 +278,8 @@ static int nvt_hw_detect(struct nvt_dev *nvt) nvt_efm_disable(nvt); - spin_lock_irqsave(&nvt->nvt_lock, flags); nvt->chip_major = chip_major; nvt->chip_minor = chip_minor; - spin_unlock_irqrestore(&nvt->nvt_lock, flags); return 0; }