From patchwork Thu May 17 18:08:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 10407563 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2C05D60155 for ; Thu, 17 May 2018 18:29:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1BEAD2857F for ; Thu, 17 May 2018 18:29:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0EE1428678; Thu, 17 May 2018 18:29:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8538E2857F for ; Thu, 17 May 2018 18:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751595AbeEQS27 (ORCPT ); Thu, 17 May 2018 14:28:59 -0400 Received: from gateway33.websitewelcome.com ([192.185.146.195]:36787 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbeEQS26 (ORCPT ); Thu, 17 May 2018 14:28:58 -0400 X-Greylist: delayed 1230 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 May 2018 14:28:58 EDT Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway33.websitewelcome.com (Postfix) with ESMTP id ECE0D46D6FA for ; Thu, 17 May 2018 13:08:27 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id JNKFftABL5CKDJNKFfN82j; Thu, 17 May 2018 13:08:27 -0500 X-Authority-Reason: nr=8 Received: from [187.172.56.86] (port=42110 helo=[192.168.1.70]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1fJNKE-003dIJ-Dm; Thu, 17 May 2018 13:08:26 -0500 Subject: Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1 To: Mauro Carvalho Chehab Cc: Dan Carpenter , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <3d4973141e218fb516422d3d831742d55aaa5c04.1524499368.git.gustavo@embeddedor.com> <20180423152455.363d285c@vento.lan> <3ab9c4c9-0656-a08e-740e-394e2e509ae9@embeddedor.com> <20180423161742.66f939ba@vento.lan> <99e158c0-1273-2500-da9e-b5ab31cba889@embeddedor.com> <20180426204241.03a42996@vento.lan> <20180515085953.65bfa107@vento.lan> <20180515141655.idzuh2jfdkuu5grs@mwanda> <20180515193936.m25kzyeknsk2bo2c@mwanda> <0f31a60b-911d-0140-3546-98317e2a0557@embeddedor.com> <20180517083440.14e6b975@vento.lan> <20180517084324.3242c257@vento.lan> <20180517091340.7d8c62b2@vento.lan> From: "Gustavo A. R. Silva" Message-ID: <5921004a-a7d3-59c9-2ef4-b6a490390d3f@embeddedor.com> Date: Thu, 17 May 2018 13:08:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180517091340.7d8c62b2@vento.lan> Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.172.56.86 X-Source-L: No X-Exim-ID: 1fJNKE-003dIJ-Dm X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.70]) [187.172.56.86]:42110 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 05/17/2018 07:13 AM, Mauro Carvalho Chehab wrote: > Em Thu, 17 May 2018 08:43:24 -0300 > Mauro Carvalho Chehab escreveu: > >>>>> On 05/15/2018 02:39 PM, Dan Carpenter wrote: >>> >>>>>> You'd need to rebuild the db (possibly twice but definitely once). >>> >>> How? Here, I just pull from your git tree and do a "make". At most, >>> make clean; make. >> >> Never mind. Found it using grep. I'm running this: >> >> make allyesconfig >> /devel/smatch/smatch_scripts/build_kernel_data.sh >> /devel/smatch/smatch_scripts/build_kernel_data.sh > > It seems that something is broken... getting this error/warning: > > DBD::SQLite::db do failed: unrecognized token: "'end + strlen(" > " at /devel/smatch/smatch_scripts/../smatch_data/db/fill_db_sql.pl line 32, line 2938054. > Yep. I get the same warning multiple times. BTW, Mauro, you sent a patch to fix an spectre v1 issue in this file yesterday: dvb_ca_en50221.c:1480, but it seems there is another instance of the same issue some lines above: (sl->slot_state != DVB_CA_SLOTSTATE_INVALID)) { Thanks --- Gustavo diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c b/drivers/media/dvb-core/dvb_ca_en50221.c index 1310526..7edd9db 100644 --- a/drivers/media/dvb-core/dvb_ca_en50221.c +++ b/drivers/media/dvb-core/dvb_ca_en50221.c @@ -1398,6 +1398,7 @@ static int dvb_ca_en50221_io_do_ioctl(struct file *file, info->type = CA_CI_LINK; info->flags = 0; + slot = array_index_nospec(slot, ca->slot_count + 1); sl = &ca->slot_info[slot]; if ((sl->slot_state != DVB_CA_SLOTSTATE_NONE) &&