[GIT,PULL,FOR,v5.14] More Outreachy cleanups (v2)

Message ID	706ba93e-fa1c-34ce-8c54-d8a1c442811e@xs4all.nl (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-media-owner@kernel.org> To: Linux Media Mailing List <linux-media@vger.kernel.org> Cc: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>, Deepak R Varma <mh12gx2825@gmail.com>, Martiros Shakhzadyan <vrzh@vrzh.net> From: Hans Verkuil <hverkuil@xs4all.nl> Subject: [GIT PULL FOR v5.14] More Outreachy cleanups (v2) Message-ID: <706ba93e-fa1c-34ce-8c54-d8a1c442811e@xs4all.nl> Date: Fri, 30 Apr 2021 12:11:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk
Series	[GIT,PULL,FOR,v5.14] More Outreachy cleanups (v2) \| expand [GIT,PULL,FOR,v5.14] More Outreachy cleanups (v2)

Message ID

706ba93e-fa1c-34ce-8c54-d8a1c442811e@xs4all.nl (mailing list archive)

State

New, archived

Headers

To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
        Deepak R Varma <mh12gx2825@gmail.com>,
        Martiros Shakhzadyan <vrzh@vrzh.net>
From: Hans Verkuil <hverkuil@xs4all.nl>
Subject: [GIT PULL FOR v5.14] More Outreachy cleanups (v2)
Message-ID: <706ba93e-fa1c-34ce-8c54-d8a1c442811e@xs4all.nl>
Date: Fri, 30 Apr 2021 12:11:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.9.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Series

[GIT,PULL,FOR,v5.14] More Outreachy cleanups (v2) | expand

Message

Hans Verkuil April 30, 2021, 10:11 a.m. UTC

This supersedes an earlier PR. This v2 adds more patches from Martiros and
Deepak.

Regards,

	Hans

The following changes since commit 6756ae29420f849de4dc5c41f9fe948450b09285:

  media: staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.h (2021-04-21 14:07:01 +0200)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.14-out1

for you to fetch changes up to 68dc2d762b637dd980f8dcc9e762da8cb788b57e:

  staging: media: atomisp: remove unwanted dev_*() calls (2021-04-30 11:49:40 +0200)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Aline Santana Cordeiro (5):
      staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_cmd.c
      staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_compat_css20.c
      staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_subdev.c
      staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_v4l2.c
      staging: media: tegra-video: Align line break to match with the open parenthesis in file vi.c

Deepak R Varma (8):
      staging: media: atomisp: balance braces around if...else block
      staging: media: atomisp: remove unnecessary braces
      staging: media: atomisp: use __func__ over function names
      staging: media: atomisp: reformat code comment blocks
      staging: media: atomisp: fix CamelCase variable naming
      staging: media: atomisp: replace raw pr_*() by dev_dbg()
      staging: media: atomisp: remove unnecessary pr_info calls
      staging: media: atomisp: remove unwanted dev_*() calls

Martiros Shakhzadyan (9):
      staging: media: atomisp: Fix sh_css.c brace coding style issues
      staging: media: atomisp: Remove redundant assertions in sh_css.c
      staging: media: atomisp: Fix the rest of sh_css.c brace issues
      staging: media: atomisp: Remove all redundant assertions in sh_css.c
      staging: media: atomisp: Remove a superfluous else clause in sh_css.c
      staging: media: atomisp: Replace if else clause with a ternary
      staging: media: atomisp: Fix alignment and line length issues
      staging: media: atomisp: Refactor ia_css_stream_load()
      staging: media: atomisp: Fix line split style issues

 drivers/staging/media/atomisp/i2c/atomisp-gc0310.c           |   49 +-
 drivers/staging/media/atomisp/i2c/atomisp-gc2235.c           |   25 +-
 drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c |    6 +-
 drivers/staging/media/atomisp/i2c/atomisp-lm3554.c           |    2 +-
 drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c          |  108 +-
 drivers/staging/media/atomisp/i2c/atomisp-ov2680.c           |   41 +-
 drivers/staging/media/atomisp/i2c/mt9m114.h                  |    6 +-
 drivers/staging/media/atomisp/i2c/ov2680.h                   |   10 +-
 drivers/staging/media/atomisp/pci/atomisp_cmd.c              |   19 +-
 drivers/staging/media/atomisp/pci/atomisp_compat_css20.c     |    4 +-
 drivers/staging/media/atomisp/pci/atomisp_subdev.c           |    4 +-
 drivers/staging/media/atomisp/pci/atomisp_v4l2.c             |    4 +-
 drivers/staging/media/atomisp/pci/sh_css.c                   | 2089 ++++++++++++++++++--------------------
 drivers/staging/media/tegra-video/vi.c                       |    4 +-
 14 files changed, 1100 insertions(+), 1271 deletions(-)

Comments

Jenkins April 30, 2021, 10:30 a.m. UTC | #1

From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/706ba93e-fa1c-34ce-8c54-d8a1c442811e@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/102415/
Build time: 00:09:24
Link: https://lore.kernel.org/linux-media/706ba93e-fa1c-34ce-8c54-d8a1c442811e@xs4all.nl

gpg: Signature made Fri 30 Apr 2021 10:00:43 AM UTC
gpg:                using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]
gpg: Note: This key has expired!
Primary key fingerprint: 052C DE7B C215 053B 689F  1BCA BD2D 6148 6614 3B4C
     Subkey fingerprint: AAA7 FFBA 4D2D 77EF 4CAE  A142 1326 E0CD 23AB DCE5

Summary: got 3/22 patches with issues, being 0 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0008-staging-media-atomisp-Fix-the-rest-of-sh_css.c-brace.patch:

   checkpatch.pl:
	$ cat patches/0008-staging-media-atomisp-Fix-the-rest-of-sh_css.c-brace.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:130: WARNING: please, no spaces at the start of a line
	-:141: CHECK: Unnecessary parentheses around '!pipe'
	-:141: CHECK: Unnecessary parentheses around '!pipe->stream'
	-:269: CHECK: Unnecessary parentheses around '!pipe'
	-:269: CHECK: Unnecessary parentheses around 'pipe->mode != IA_CSS_PIPE_ID_PREVIEW'
	-:278: CHECK: Unnecessary parentheses around 'fw == last_fw'
	-:278: CHECK: Unnecessary parentheses around 'fw->info.isp.sp.enable.out_frame  != 0'
	-:339: CHECK: Unnecessary parentheses around '!pipe'
	-:339: CHECK: Unnecessary parentheses around '!pipe->stream'
	-:377: CHECK: Unnecessary parentheses around '!pipe'
	-:377: CHECK: Unnecessary parentheses around '!pipe->stream'
	-:377: CHECK: Unnecessary parentheses around 'pipe->mode != IA_CSS_PIPE_ID_PREVIEW'
	-:469: CHECK: Unnecessary parentheses around '!pipe'
	-:469: CHECK: Unnecessary parentheses around '!pipe->stream'
	-:469: CHECK: Unnecessary parentheses around 'pipe->mode != IA_CSS_PIPE_ID_PREVIEW'
	-:529: CHECK: Unnecessary parentheses around '!pipe'
	-:529: CHECK: Unnecessary parentheses around '!buffer'
	-:582: CHECK: Unnecessary parentheses around 'queue_id <= SH_CSS_INVALID_QUEUE_ID'
	-:582: CHECK: Unnecessary parentheses around 'queue_id >= SH_CSS_MAX_NUM_QUEUES'
	-:627: CHECK: Logical continuations should be on the previous line
	-:637: CHECK: Unnecessary parentheses around '!h_vbuf'
	-:637: CHECK: Unnecessary parentheses around 'h_vbuf->vptr == 0x0'
	-:647: CHECK: Logical continuations should be on the previous line
	-:657: CHECK: Logical continuations should be on the previous line
	-:707: CHECK: Unnecessary parentheses around '!pipe'
	-:707: CHECK: Unnecessary parentheses around '!buffer'
	-:732: CHECK: Unnecessary parentheses around 'queue_id <= SH_CSS_INVALID_QUEUE_ID'
	-:732: CHECK: Unnecessary parentheses around 'queue_id >= SH_CSS_MAX_NUM_QUEUES'
	-:1197: CHECK: Unnecessary parentheses around '!pipe'
	-:1197: CHECK: Unnecessary parentheses around 'pipe->mode != IA_CSS_PIPE_ID_VIDEO'
	-:1283: WARNING: please, no spaces at the start of a line
	-:1293: WARNING: please, no spaces at the start of a line
	-:1303: WARNING: please, no spaces at the start of a line
	-:1313: WARNING: please, no spaces at the start of a line
	-:1331: WARNING: line length of 105 exceeds 100 columns
	-:1331: CHECK: Unnecessary parentheses around '!pipe'
	-:1331: CHECK: Unnecessary parentheses around 'pipe->mode != IA_CSS_PIPE_ID_CAPTURE'
	-:1331: CHECK: Unnecessary parentheses around 'pipe->mode != IA_CSS_PIPE_ID_COPY'
	-:1360: WARNING: please, no spaces at the start of a line
	-:1370: WARNING: please, no spaces at the start of a line
	-:1513: CHECK: Unnecessary parentheses around '!pipe'
	-:1513: CHECK: Unnecessary parentheses around 'pipe->mode != IA_CSS_PIPE_ID_YUVPP'
	-:1608: CHECK: Unnecessary parentheses around '!pipe'
	-:1608: CHECK: Unnecessary parentheses around '!pipe->stream'
	-:1608: CHECK: Unnecessary parentheses around 'pipe->mode != IA_CSS_PIPE_ID_YUVPP'
	-:1775: CHECK: Unnecessary parentheses around 'num_primary_stage == 0'
	-:1775: CHECK: Unnecessary parentheses around 'mode == IA_CSS_CAPTURE_MODE_PRIMARY'
	-:1880: WARNING: line length of 112 exceeds 100 columns
	-:1909: WARNING: please, no spaces at the start of a line
	-:2052: CHECK: Unnecessary parentheses around '!firmware'
	-:2052: CHECK: Unnecessary parentheses around '!pipe'
	-:2111: WARNING: please, no spaces at the start of a line
	-:2206: CHECK: Unnecessary parentheses around '!pipe'
	-:2206: CHECK: Unnecessary parentheses around '!config'
	-:2764: CHECK: Unnecessary parentheses around '!stream'
	-:2764: CHECK: Unnecessary parentheses around '!stream->last_pipe'

patches/0012-staging-media-atomisp-Fix-alignment-and-line-length-.patch:

   checkpatch.pl:
	$ cat patches/0012-staging-media-atomisp-Fix-alignment-and-line-length-.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:281: WARNING: line length of 107 exceeds 100 columns
	-:293: WARNING: line length of 110 exceeds 100 columns
	-:390: WARNING: line length of 107 exceeds 100 columns
	-:402: WARNING: line length of 110 exceeds 100 columns

patches/0017-staging-media-atomisp-use-__func__-over-function-nam.patch:

   checkpatch.pl:
	$ cat patches/0017-staging-media-atomisp-use-__func__-over-function-nam.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:30: WARNING: Unnecessary ftrace-like logging - prefer using ftrace
	-:43: WARNING: Unnecessary ftrace-like logging - prefer using ftrace
	-:119: WARNING: Unnecessary ftrace-like logging - prefer using ftrace


Error #512 when building PDF docs

Mauro Carvalho Chehab May 17, 2021, 1:57 p.m. UTC | #2

Em Fri, 30 Apr 2021 12:11:22 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:

> This supersedes an earlier PR. This v2 adds more patches from Martiros and
> Deepak.
> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit 6756ae29420f849de4dc5c41f9fe948450b09285:
> 
>   media: staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.h (2021-04-21 14:07:01 +0200)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.14-out1
> 
> for you to fetch changes up to 68dc2d762b637dd980f8dcc9e762da8cb788b57e:
> 
>   staging: media: atomisp: remove unwanted dev_*() calls (2021-04-30 11:49:40 +0200)
> 
> ----------------------------------------------------------------
> Tag branch
> 
> ----------------------------------------------------------------
> Aline Santana Cordeiro (5):
>       staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_cmd.c
>       staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_compat_css20.c
>       staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_subdev.c
>       staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_v4l2.c
>       staging: media: tegra-video: Align line break to match with the open parenthesis in file vi.c
> 
> Deepak R Varma (8):
>       staging: media: atomisp: balance braces around if...else block
>       staging: media: atomisp: remove unnecessary braces
>       staging: media: atomisp: use __func__ over function names
>       staging: media: atomisp: reformat code comment blocks
>       staging: media: atomisp: fix CamelCase variable naming
>       staging: media: atomisp: replace raw pr_*() by dev_dbg()
>       staging: media: atomisp: remove unnecessary pr_info calls
>       staging: media: atomisp: remove unwanted dev_*() calls
> 
> Martiros Shakhzadyan (9):
>       staging: media: atomisp: Fix sh_css.c brace coding style issues
>       staging: media: atomisp: Remove redundant assertions in sh_css.c
>       staging: media: atomisp: Fix the rest of sh_css.c brace issues
>       staging: media: atomisp: Remove all redundant assertions in sh_css.c
>       staging: media: atomisp: Remove a superfluous else clause in sh_css.c
>       staging: media: atomisp: Replace if else clause with a ternary
>       staging: media: atomisp: Fix alignment and line length issues
>       staging: media: atomisp: Refactor ia_css_stream_load()
>       staging: media: atomisp: Fix line split style issues

I ended not applying two patches from this series:

- staging: media: atomisp: use __func__ over function names

Dan requested some changes on it, as it has several dev_dbg() calls
used just for tracing. I sent a reply with a few additional issues;

- staging: media: atomisp: remove unwanted dev_*() calls

This one didn't apply. Is it touching the same lines the first patch
changed? If so, please merge both into a single one, after applying
the fixes I mentioned on my e-mail:

	https://lore.kernel.org/linux-media/20210517154448.7bb8be17@coco.lan/T/#ma9ded10c22aaa86de74babf1bd2a2320c3dac70b
	
The remaining ones were applied.

Thanks!
Mauro

[GIT,PULL,FOR,v5.14] More Outreachy cleanups (v2)

Pull-request

Message

Comments