mbox series

[GIT,PULL,FOR,v5.15] v2: Various fixes and enhancements

Message ID 71026122-e9bc-a481-70ab-fde4e89af571@xs4all.nl (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL,FOR,v5.15] v2: Various fixes and enhancements | expand

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.15f

Message

Hans Verkuil Aug. 5, 2021, 10:18 a.m. UTC
Compared to v1 this adds five new patches:

      media: cedrus: hevc: Add support for scaling lists
      media: Rename V4L2_PIX_FMT_SUNXI_TILED_NV12 to V4L2_PIX_FMT_NV12_32L32
      media: Rename V4L2_PIX_FMT_HM12 to V4L2_PIX_FMT_NV12_16L16
      media: Add NV12_4L4 tiled format
      media: Clean V4L2_PIX_FMT_NV12MT documentation

And it fixes a typo (mt8192 -> mt8195) in the commit log of:

      dt-bindings: media: mtk-vcodec: Add binding for MT8195 VENC

Regards,

	Hans

The following changes since commit bfee75f73c37a2f46a6326eaa06f5db701f76f01:

  media: venus: venc: add support for V4L2_CID_MPEG_VIDEO_H264_8X8_TRANSFORM control (2021-08-04 14:43:52 +0200)


are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.15f

for you to fetch changes up to b44234e9ac7997271f3412a2a2bb57f0cdc4ee06:

  media: Clean V4L2_PIX_FMT_NV12MT documentation (2021-08-05 11:01:29 +0200)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Benjamin Gaignard (2):
      media: hevc: Add scaling matrix control
      media: hantro: Add scaling lists feature

Christophe JAILLET (1):
      media: meson-ge2d: Fix rotation parameter changes detection in 'ge2d_s_ctrl()'

Ezequiel Garcia (4):
      media: Rename V4L2_PIX_FMT_SUNXI_TILED_NV12 to V4L2_PIX_FMT_NV12_32L32
      media: Rename V4L2_PIX_FMT_HM12 to V4L2_PIX_FMT_NV12_16L16
      media: Add NV12_4L4 tiled format
      media: Clean V4L2_PIX_FMT_NV12MT documentation

Hans Verkuil (3):
      cedrus: drop min_buffers_needed.
      vivid: add module option to set request support mode
      videobuf2-core: sanity checks for requests and qbuf

Irui Wang (3):
      media: mtk-vcodec: Clean redundant encoder format definition
      dt-bindings: media: mtk-vcodec: Add binding for MT8195 VENC
      media: mtk-vcodec: Add MT8195 H264 venc driver

Jernej Skrabec (1):
      media: cedrus: hevc: Add support for scaling lists

Krzysztof HaƂasa (1):
      TDA1997x: fix tda1997x_remove()

Pavel Skripkin (1):
      media: em28xx: add missing em28xx_close_extension

Pete Hemery (1):
      media: gspca/sn9c20x: Add ability to control built-in webcam LEDs

Robert Foss (4):
      media: camss: vfe: Don't read hardware version needlessly
      media: camss: vfe: Decrease priority of of VFE HW version to 'dbg'
      media: camss: vfe: Remove vfe_hw_version_read() argument
      media: camss: vfe: Rework vfe_hw_version_read() function definition

 Documentation/admin-guide/media/ivtv.rst                     |  2 +-
 Documentation/devicetree/bindings/media/mediatek-vcodec.txt  |  1 +
 Documentation/userspace-api/media/drivers/cx2341x-uapi.rst   |  8 ++---
 Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst    | 57 +++++++++++++++++++++++++++++++++++
 Documentation/userspace-api/media/v4l/pixfmt-reserved.rst    | 22 --------------
 Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst  | 50 +++++++++++++++++++++----------
 Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst   |  6 ++++
 Documentation/userspace-api/media/videodev2.h.rst.exceptions |  2 ++
 drivers/media/common/videobuf2/videobuf2-core.c              | 23 +++++++++++++-
 drivers/media/i2c/tda1997x.c                                 |  4 +--
 drivers/media/pci/cx18/cx18-ioctl.c                          |  4 +--
 drivers/media/pci/cx18/cx18-streams.c                        |  8 ++---
 drivers/media/pci/ivtv/ivtv-ioctl.c                          |  8 ++---
 drivers/media/platform/meson/ge2d/ge2d.c                     |  6 +---
 drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h           |  1 +
 drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c       | 63 +++++++++++++++++++-------------------
 drivers/media/platform/qcom/camss/camss-vfe-170.c            |  9 ++++--
 drivers/media/platform/qcom/camss/camss-vfe-4-1.c            |  8 +++--
 drivers/media/platform/qcom/camss/camss-vfe-4-7.c            |  8 +++--
 drivers/media/platform/qcom/camss/camss-vfe-4-8.c            |  8 +++--
 drivers/media/platform/qcom/camss/camss-vfe.c                |  3 +-
 drivers/media/platform/qcom/camss/camss-vfe.h                |  2 +-
 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c           | 10 +++----
 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h           |  2 +-
 drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c         |  2 +-
 drivers/media/test-drivers/vivid/vivid-core.c                | 14 +++++++--
 drivers/media/usb/em28xx/em28xx-cards.c                      |  5 +++-
 drivers/media/usb/gspca/sn9c20x.c                            | 22 +++++++++++++-
 drivers/media/v4l2-core/v4l2-common.c                        |  3 ++
 drivers/media/v4l2-core/v4l2-ctrls-core.c                    |  6 ++++
 drivers/media/v4l2-core/v4l2-ctrls-defs.c                    |  4 +++
 drivers/media/v4l2-core/v4l2-ioctl.c                         |  5 ++--
 drivers/staging/media/hantro/hantro_drv.c                    |  8 +++--
 drivers/staging/media/hantro/hantro_g2_hevc_dec.c            | 52 ++++++++++++++++++++++++++++++++
 drivers/staging/media/hantro/hantro_hevc.c                   | 21 +++++++++++++
 drivers/staging/media/hantro/hantro_hw.h                     |  4 +++
 drivers/staging/media/sunxi/cedrus/cedrus.c                  |  8 ++++-
 drivers/staging/media/sunxi/cedrus/cedrus.h                  |  1 +
 drivers/staging/media/sunxi/cedrus/cedrus_dec.c              |  2 ++
 drivers/staging/media/sunxi/cedrus/cedrus_h265.c             | 70 ++++++++++++++++++++++++++++++++++++++++++-
 drivers/staging/media/sunxi/cedrus/cedrus_hw.c               |  2 +-
 drivers/staging/media/sunxi/cedrus/cedrus_regs.h             |  2 ++
 drivers/staging/media/sunxi/cedrus/cedrus_video.c            |  6 ++--
 include/media/hevc-ctrls.h                                   | 11 +++++++
 include/uapi/linux/videodev2.h                               | 19 +++++++++---
 45 files changed, 449 insertions(+), 133 deletions(-)

Comments

Jenkins Aug. 5, 2021, 3:53 p.m. UTC | #1
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/71026122-e9bc-a481-70ab-fde4e89af571@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/129674/
Build time: 00:43:50
Link: https://lore.kernel.org/linux-media/71026122-e9bc-a481-70ab-fde4e89af571@xs4all.nl

gpg: Signature made Thu 05 Aug 2021 09:02:06 AM UTC
gpg:                using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [unknown]
gpg: Note: This key has expired!
Primary key fingerprint: 052C DE7B C215 053B 689F  1BCA BD2D 6148 6614 3B4C
     Subkey fingerprint: AAA7 FFBA 4D2D 77EF 4CAE  A142 1326 E0CD 23AB DCE5

Summary: got 9/21 patches with issues, being 6 at build time

Error/warnings:

patches/0001-media-camss-vfe-Don-t-read-hardware-version-needless.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]

    allyesconfig: return code #0:
	SPARSE:../drivers/media/cec/core/cec-core.c ../include/asm-generic/bitops/find.h:90:32:  warning: shift count is negative (-192)
	SPARSE:../drivers/media/mc/mc-devnode.c ../include/asm-generic/bitops/find.h:90:32:  warning: shift count is negative (-192)
	SPARSE:../drivers/media/v4l2-core/v4l2-dev.c ../include/asm-generic/bitops/find.h:132:46:  warning: shift count is negative (-192)
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:268 v4l_print_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:292 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:302 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:328 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:347 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:352 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:362 v4l_print_framebuffer() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:735 v4l_print_frmsizeenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:762 v4l_print_frmivalenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:1424 v4l_fill_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/rc/meson-ir-tx.c:22: warning: expecting prototype for meson(). Prototype was for DEVICE_NAME() instead
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1969 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2856 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

patches/0005-media-hevc-Add-scaling-matrix-control.patch:

    allyesconfig: return code #0:
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:268 v4l_print_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:292 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:302 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:328 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:347 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:352 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:362 v4l_print_framebuffer() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:735 v4l_print_frmsizeenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:762 v4l_print_frmivalenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:1424 v4l_fill_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2828 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

patches/0007-media-cedrus-hevc-Add-support-for-scaling-lists.patch:

   checkpatch.pl:
	$ cat patches/0007-media-cedrus-hevc-Add-support-for-scaling-lists.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:56: CHECK: Alignment should match open parenthesis

patches/0011-media-em28xx-add-missing-em28xx_close_extension.patch:

   checkpatch.pl:
	$ cat patches/0011-media-em28xx-add-missing-em28xx_close_extension.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:11: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)

patches/0014-media-gspca-sn9c20x-Add-ability-to-control-built-in-.patch:

   checkpatch.pl:
	$ cat patches/0014-media-gspca-sn9c20x-Add-ability-to-control-built-in-.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:87: CHECK: Alignment should match open parenthesis

patches/0018-media-Rename-V4L2_PIX_FMT_SUNXI_TILED_NV12-to-V4L2_P.patch:

    allyesconfig: return code #0:
	SPARSE:../drivers/media/v4l2-core/v4l2-dev.c ../include/asm-generic/bitops/find.h:132:46:  warning: shift count is negative (-192)
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:268 v4l_print_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:292 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:302 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:328 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:347 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:352 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:362 v4l_print_framebuffer() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:735 v4l_print_frmsizeenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:762 v4l_print_frmivalenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:1424 v4l_fill_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1979 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2841 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

   checkpatch.pl:
	$ cat patches/0018-media-Rename-V4L2_PIX_FMT_SUNXI_TILED_NV12-to-V4L2_P.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:106: ERROR: trailing statements should be on next line

patches/0019-media-Rename-V4L2_PIX_FMT_HM12-to-V4L2_PIX_FMT_NV12_.patch:

    allyesconfig: return code #0:
	SPARSE:../drivers/media/v4l2-core/v4l2-dev.c ../include/asm-generic/bitops/find.h:132:46:  warning: shift count is negative (-192)
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:268 v4l_print_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:292 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:302 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:328 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:347 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:352 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:362 v4l_print_framebuffer() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:735 v4l_print_frmsizeenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:762 v4l_print_frmivalenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:1424 v4l_fill_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1979 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2856 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

   checkpatch.pl:
	$ cat patches/0019-media-Rename-V4L2_PIX_FMT_HM12-to-V4L2_PIX_FMT_NV12_.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:317: ERROR: trailing statements should be on next line

patches/0020-media-Add-NV12_4L4-tiled-format.patch:

    allyesconfig: return code #0:
	SPARSE:../drivers/media/v4l2-core/v4l2-dev.c ../include/asm-generic/bitops/find.h:132:46:  warning: shift count is negative (-192)
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:268 v4l_print_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:292 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:302 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:328 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:347 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:352 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:362 v4l_print_framebuffer() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:735 v4l_print_frmsizeenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:762 v4l_print_frmivalenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:1425 v4l_fill_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1979 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2841 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

   checkpatch.pl:
	$ cat patches/0020-media-Add-NV12_4L4-tiled-format.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:55: WARNING: line length of 165 exceeds 100 columns
	-:68: ERROR: trailing statements should be on next line

patches/0021-media-Clean-V4L2_PIX_FMT_NV12MT-documentation.patch:

    allyesconfig: return code #0:
	SPARSE:../drivers/media/v4l2-core/v4l2-dev.c ../include/asm-generic/bitops/find.h:132:46:  warning: shift count is negative (-192)
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:268 v4l_print_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:292 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:302 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:328 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:347 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:352 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:362 v4l_print_framebuffer() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:735 v4l_print_frmsizeenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:762 v4l_print_frmivalenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:1425 v4l_fill_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1979 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2856 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
Naresh Kamboju Aug. 10, 2021, 9:45 a.m. UTC | #2
[Please ignore this if it is already reported]
The following kernel crash "Internal error: Oops:" found while booting the arm64
Dragonboard 845c device.

Our bisect scripts are still running to bisect the first bad commit.
However, I would like to report on suspecting sub-systems patch set

On Thu, 5 Aug 2021 at 15:48, Hans Verkuil <hverkuil@xs4all.nl> wrote:

> Robert Foss (4):
>       media: camss: vfe: Don't read hardware version needlessly
>       media: camss: vfe: Decrease priority of of VFE HW version to 'dbg'
>       media: camss: vfe: Remove vfe_hw_version_read() argument
>       media: camss: vfe: Rework vfe_hw_version_read() function definition

[    8.296907] Unable to handle kernel NULL pointer dereference at
virtual address 0000000000000000
[    8.305943] Mem abort info:
[    8.307150] Bluetooth: Core ver 2.22
[    8.308784]   ESR = 0x96000004
[    8.308787]   EC = 0x25: DABT (current EL), IL = 32 bits
[    8.308790]   SET = 0, FnV = 0
[    8.308792]   EA = 0, S1PTW = 0
[    8.308794]   FSC = 0x04: level 0 translation fault
[    8.308796] Data abort info:
[    8.308798]   ISV = 0, ISS = 0x00000004
[    8.313982] NET: Registered PF_BLUETOOTH protocol family
[    8.315502]   CM = 0, WnR = 0
[    8.320889] Bluetooth: HCI device and connection manager initialized
[    8.323948] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000107162000
[    8.323952] [0000000000000000] pgd=0000000000000000, p4d=0000000000000000
[    8.323959] Internal error: Oops: 96000004 [#1] PREEMPT SMP
[    8.323963] Modules linked in: gpu_sched(+) bluetooth(+)
reset_qcom_pdc drm_kms_helper i2c_qcom_geni(+) qcom_camss
spi_geni_qcom videobuf2_dma_sg venus_core v4l2_fwnode v4l2_async
v4l2_mem2mem
[    8.327174] Bluetooth: HCI socket layer initialized
[    8.332068]  videobuf2_memops videobuf2_v4l2 camcc_sdm845
videobuf2_common qcom_rng i2c_qcom_cci ath10k_snoc ath10k_core
xhci_pci ath qcom_q6v5_mss qrtr xhci_pci_renesas mac80211
qcom_q6v5_pas ns qcom_pil_info qcom_q6v5 slim_qcom_ngd_ctrl
pdr_interface qcom_sysmon cfg80211 qcom_common display_connector
qcom_glink_smem icc_osm_l3 rfkill slimbus qcom_wdt qmi_helpers
mdt_loader socinfo drm rmtfs_mem fuse
[    8.332103] CPU: 6 PID: 9 Comm: kworker/u16:1 Not tainted
5.14.0-rc5-next-20210809 #1
[    8.332107] Hardware name: Thundercomm Dragonboard 845c (DT)
[    8.332109] Workqueue: events_unbound deferred_probe_work_func
[    8.332120] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[    8.335040] Bluetooth: L2CAP socket layer initialized
[    8.337046] i2c 10-003b: Fixing up cyclic dependency with hdmi-out
[    8.342391] pc : vfe_hw_version+0x20/0x80 [qcom_camss]
[    8.342405] lr : msm_vfe_subdev_init+0x8c/0x4d0 [qcom_camss]
[    8.342415] sp : ffff80001009ba20
[    8.342416] x29: ffff80001009ba20 x28: ffff330f84ea6000 x27: 0000000000000004
[    8.347824] Bluetooth: SCO socket layer initialized
[    8.350763]
[    8.350764] x26: 0000000000000003 x25: ffff330f8ea00080 x24: 0000000000000000
[    8.350767] x23: ffff330f84ea6000 x22: ffff330f80f5b010 x21: ffffd62954d86828
[    8.350770] x20: ffff330f80f5b000 x19: 0000000000000000 x18: 0000000000000000
[    8.350773] x17: 0000000000000000 x16: ffffd6298befc0e0 x15: 0000000000000000
[    8.350776] x14: 0000000000000000 x13: 7367616c665f746e x12: 69617274736e6f63
[    8.350779] x11: ffff330f80400000 x10: 0000000000000000 x9 : ffffd62954d811b0
[    8.350782] x8 : 0101010101010101 x7 : ffffd62954d7d814 x6 : ffffd62954d80f80
[    8.350785] x5 : ffff330f8ea03080 x4 : ffff330f8ea03640 x3 : ffffd62954d7d720
[    8.557091] x2 : 0000000000000003 x1 : ffffd62954d7dae0 x0 : ffff330f8ea00080
[    8.564282] Call trace:
[    8.566749]  vfe_hw_version+0x20/0x80 [qcom_camss]
[    8.571599]  msm_vfe_subdev_init+0x8c/0x4d0 [qcom_camss]
[    8.576956]  camss_probe+0x358/0xd60 [qcom_camss]
[    8.581710]  platform_probe+0x74/0xf0
[    8.585400]  really_probe+0xc4/0x470
[    8.589003]  __driver_probe_device+0x11c/0x190
[    8.593477]  driver_probe_device+0x48/0x110
[    8.597694]  __device_attach_driver+0xa4/0x140
[    8.602173]  bus_for_each_drv+0x84/0xe0
[    8.606038]  __device_attach+0xe4/0x1c0
[    8.609904]  device_initial_probe+0x20/0x30
[    8.614118]  bus_probe_device+0xa4/0xb0
[    8.617979]  deferred_probe_work_func+0xa8/0xfc
[    8.622543]  process_one_work+0x1dc/0x4a0
[    8.626587]  worker_thread+0x144/0x470
[    8.630364]  kthread+0x144/0x160
[    8.633617]  ret_from_fork+0x10/0x20
[    8.637227] Code: a9be7bfd 910003fd f9000bf3 f9400813 (b9400273)
[    8.643362] ---[ end trace 37b6accc93773476 ]---

full test log:
https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20210809/testrun/5410288/suite/ltp-crypto-tests/test/af_alg07/log

Reported-by:  Linux Kernel Functional Testing <lkft@linaro.org>

steps to reproduce:
 # It is always reproducible
 # Boot arm64 Dragonboard 845c board with built kernel Image
 # While booting the device you will notice this crash log

metadata:
  git branch: master
  git repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
  git commit: da454ebf578f6c542ba9f5b3ddb98db3ede109c1
  git describe: next-20210809
  make_kernelversion: 5.14.0-rc5
  kernel-config: https://builds.tuxbuild.com/1wURGIfgNW0xkrl16wDktoeATBp/config
  vmlinux: https://builds.tuxbuild.com/1wURGIfgNW0xkrl16wDktoeATBp/vmlinux.xz
  System.map: https://builds.tuxbuild.com/1wURGIfgNW0xkrl16wDktoeATBp/System.map
  Image: https://builds.tuxbuild.com/1wURGIfgNW0xkrl16wDktoeATBp/Image.gz
  gcc: gcc-11

--
Linaro LKFT
https://lkft.linaro.org
Robert Foss Aug. 10, 2021, 10:20 a.m. UTC | #3
Hey Naresh,

Thanks for reporting this.

On Tue, 10 Aug 2021 at 11:45, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> [Please ignore this if it is already reported]
> The following kernel crash "Internal error: Oops:" found while booting the arm64
> Dragonboard 845c device.
>
> Our bisect scripts are still running to bisect the first bad commit.
> However, I would like to report on suspecting sub-systems patch set
>
> On Thu, 5 Aug 2021 at 15:48, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> > Robert Foss (4):
> >       media: camss: vfe: Don't read hardware version needlessly
> >       media: camss: vfe: Decrease priority of of VFE HW version to 'dbg'
> >       media: camss: vfe: Remove vfe_hw_version_read() argument
> >       media: camss: vfe: Rework vfe_hw_version_read() function definition
>
> [    8.296907] Unable to handle kernel NULL pointer dereference at
> virtual address 0000000000000000
> [    8.305943] Mem abort info:
> [    8.307150] Bluetooth: Core ver 2.22
> [    8.308784]   ESR = 0x96000004
> [    8.308787]   EC = 0x25: DABT (current EL), IL = 32 bits
> [    8.308790]   SET = 0, FnV = 0
> [    8.308792]   EA = 0, S1PTW = 0
> [    8.308794]   FSC = 0x04: level 0 translation fault
> [    8.308796] Data abort info:
> [    8.308798]   ISV = 0, ISS = 0x00000004
> [    8.313982] NET: Registered PF_BLUETOOTH protocol family
> [    8.315502]   CM = 0, WnR = 0
> [    8.320889] Bluetooth: HCI device and connection manager initialized
> [    8.323948] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000107162000
> [    8.323952] [0000000000000000] pgd=0000000000000000, p4d=0000000000000000
> [    8.323959] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> [    8.323963] Modules linked in: gpu_sched(+) bluetooth(+)
> reset_qcom_pdc drm_kms_helper i2c_qcom_geni(+) qcom_camss
> spi_geni_qcom videobuf2_dma_sg venus_core v4l2_fwnode v4l2_async
> v4l2_mem2mem
> [    8.327174] Bluetooth: HCI socket layer initialized
> [    8.332068]  videobuf2_memops videobuf2_v4l2 camcc_sdm845
> videobuf2_common qcom_rng i2c_qcom_cci ath10k_snoc ath10k_core
> xhci_pci ath qcom_q6v5_mss qrtr xhci_pci_renesas mac80211
> qcom_q6v5_pas ns qcom_pil_info qcom_q6v5 slim_qcom_ngd_ctrl
> pdr_interface qcom_sysmon cfg80211 qcom_common display_connector
> qcom_glink_smem icc_osm_l3 rfkill slimbus qcom_wdt qmi_helpers
> mdt_loader socinfo drm rmtfs_mem fuse
> [    8.332103] CPU: 6 PID: 9 Comm: kworker/u16:1 Not tainted
> 5.14.0-rc5-next-20210809 #1
> [    8.332107] Hardware name: Thundercomm Dragonboard 845c (DT)
> [    8.332109] Workqueue: events_unbound deferred_probe_work_func
> [    8.332120] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> [    8.335040] Bluetooth: L2CAP socket layer initialized
> [    8.337046] i2c 10-003b: Fixing up cyclic dependency with hdmi-out
> [    8.342391] pc : vfe_hw_version+0x20/0x80 [qcom_camss]
> [    8.342405] lr : msm_vfe_subdev_init+0x8c/0x4d0 [qcom_camss]
> [    8.342415] sp : ffff80001009ba20
> [    8.342416] x29: ffff80001009ba20 x28: ffff330f84ea6000 x27: 0000000000000004
> [    8.347824] Bluetooth: SCO socket layer initialized
> [    8.350763]
> [    8.350764] x26: 0000000000000003 x25: ffff330f8ea00080 x24: 0000000000000000
> [    8.350767] x23: ffff330f84ea6000 x22: ffff330f80f5b010 x21: ffffd62954d86828
> [    8.350770] x20: ffff330f80f5b000 x19: 0000000000000000 x18: 0000000000000000
> [    8.350773] x17: 0000000000000000 x16: ffffd6298befc0e0 x15: 0000000000000000
> [    8.350776] x14: 0000000000000000 x13: 7367616c665f746e x12: 69617274736e6f63
> [    8.350779] x11: ffff330f80400000 x10: 0000000000000000 x9 : ffffd62954d811b0
> [    8.350782] x8 : 0101010101010101 x7 : ffffd62954d7d814 x6 : ffffd62954d80f80
> [    8.350785] x5 : ffff330f8ea03080 x4 : ffff330f8ea03640 x3 : ffffd62954d7d720
> [    8.557091] x2 : 0000000000000003 x1 : ffffd62954d7dae0 x0 : ffff330f8ea00080
> [    8.564282] Call trace:
> [    8.566749]  vfe_hw_version+0x20/0x80 [qcom_camss]
> [    8.571599]  msm_vfe_subdev_init+0x8c/0x4d0 [qcom_camss]
> [    8.576956]  camss_probe+0x358/0xd60 [qcom_camss]
> [    8.581710]  platform_probe+0x74/0xf0
> [    8.585400]  really_probe+0xc4/0x470
> [    8.589003]  __driver_probe_device+0x11c/0x190
> [    8.593477]  driver_probe_device+0x48/0x110
> [    8.597694]  __device_attach_driver+0xa4/0x140
> [    8.602173]  bus_for_each_drv+0x84/0xe0
> [    8.606038]  __device_attach+0xe4/0x1c0
> [    8.609904]  device_initial_probe+0x20/0x30
> [    8.614118]  bus_probe_device+0xa4/0xb0
> [    8.617979]  deferred_probe_work_func+0xa8/0xfc
> [    8.622543]  process_one_work+0x1dc/0x4a0
> [    8.626587]  worker_thread+0x144/0x470
> [    8.630364]  kthread+0x144/0x160
> [    8.633617]  ret_from_fork+0x10/0x20
> [    8.637227] Code: a9be7bfd 910003fd f9000bf3 f9400813 (b9400273)
> [    8.643362] ---[ end trace 37b6accc93773476 ]---
>
> full test log:
> https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20210809/testrun/5410288/suite/ltp-crypto-tests/test/af_alg07/log
>
> Reported-by:  Linux Kernel Functional Testing <lkft@linaro.org>
>
> steps to reproduce:
>  # It is always reproducible
>  # Boot arm64 Dragonboard 845c board with built kernel Image
>  # While booting the device you will notice this crash log
>
> metadata:
>   git branch: master
>   git repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>   git commit: da454ebf578f6c542ba9f5b3ddb98db3ede109c1
>   git describe: next-20210809
>   make_kernelversion: 5.14.0-rc5
>   kernel-config: https://builds.tuxbuild.com/1wURGIfgNW0xkrl16wDktoeATBp/config
>   vmlinux: https://builds.tuxbuild.com/1wURGIfgNW0xkrl16wDktoeATBp/vmlinux.xz
>   System.map: https://builds.tuxbuild.com/1wURGIfgNW0xkrl16wDktoeATBp/System.map
>   Image: https://builds.tuxbuild.com/1wURGIfgNW0xkrl16wDktoeATBp/Image.gz
>   gcc: gcc-11
>

Having a look at this issue, I've traced the issue to the
vfe->ops->hw_version(vfe) call happening before vfe->base is assigned.

I'll submit a patch fixing this issue shortly.


Rob.