| Message ID | 7b69f2cb91319abdacf37be501db2eae45112a09.1520350517.git.mchehab@s-opensource.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mauro, On Tue, Mar 06, 2018 at 10:35:22AM -0500, Mauro Carvalho Chehab wrote: > The values on this array never changes. Make it const. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Since I'm sure there will be more cleanup/fixes on tw9910 and ov772x, could you please take into account my series: [PATCH v2 00/11] media: ov772x/tw9910 cleanup before any additional change to these 2 drivers? Thanks j > --- > drivers/media/i2c/ov772x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c > index 16665af0c712..321105bb3161 100644 > --- a/drivers/media/i2c/ov772x.c > +++ b/drivers/media/i2c/ov772x.c > @@ -531,7 +531,7 @@ static const struct ov772x_win_size ov772x_win_sizes[] = { > /* > * frame rate settings lists > */ > -static unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 }; > +static const unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 }; > > /* > * general function > -- > 2.14.3 >
Em Tue, 6 Mar 2018 17:05:26 +0100 jacopo mondi <jacopo@jmondi.org> escreveu: > Hi Mauro, > > On Tue, Mar 06, 2018 at 10:35:22AM -0500, Mauro Carvalho Chehab wrote: > > The values on this array never changes. Make it const. > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> > > Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Since I'm sure there will be more cleanup/fixes on tw9910 and ov772x, > could you please take into account my series: > [PATCH v2 00/11] media: ov772x/tw9910 cleanup > before any additional change to these 2 drivers? That is the next on my patch queue :-) Reviewing them right now. Regards, Mauro
diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index 16665af0c712..321105bb3161 100644 --- a/drivers/media/i2c/ov772x.c +++ b/drivers/media/i2c/ov772x.c @@ -531,7 +531,7 @@ static const struct ov772x_win_size ov772x_win_sizes[] = { /* * frame rate settings lists */ -static unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 }; +static const unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 }; /* * general function
The values on this array never changes. Make it const. Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> --- drivers/media/i2c/ov772x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)