From patchwork Thu Jul 20 23:47:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 9855825 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7B830601C8 for ; Thu, 20 Jul 2017 23:47:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6D2C2286F2 for ; Thu, 20 Jul 2017 23:47:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 62023286FD; Thu, 20 Jul 2017 23:47:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E1C45286F2 for ; Thu, 20 Jul 2017 23:47:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965952AbdGTXrl (ORCPT ); Thu, 20 Jul 2017 19:47:41 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:52301 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965203AbdGTXrk (ORCPT ); Thu, 20 Jul 2017 19:47:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-ID:Subject:Cc:From:To:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=y81rBTsFeGHD2yDJXK9NTps48hz3+esYcvz7srj8WSw=; b=T7/jnfN6DfqLsI2H9zatrr1yU Zz/aIb+CfFmo0z3qze6KGjiiKejiPM6VjBGW97BLi00/CgOlc3w6Bq0y6uG+9SK3bL9dJOTIG59qU hhZtlXt4g9fNB3zq534GDiWo818VFDU/+JpjvIH7jRznn/mr2843V/CBs96K3s0arzErTupJyyfSf N3O+SEUZLo0ENNdIsWLuRvs8aejnar3hU3KkXCOl/NdN97HoAWOurrRyB8TGy28AocfPZomNQ3vLv R1pEmX9fhnfUSEb1W8Vgtge+wWrrzkCGrc7u05wuUBP82GOCCSA3NaKheH7sk62G9qTcLr4aqeqRg 8dnKbGTUw==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlap) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dYLAQ-0005WF-Mu; Thu, 20 Jul 2017 23:47:39 +0000 To: LKML , linux-media , Mauro Carvalho Chehab From: Randy Dunlap Cc: "Yang, Hyungwoo" , "Rapolu, Chiranjeevi" Subject: [PATCH -next] media: ov5670: add depends to fix build errors Message-ID: <7b6d824a-2574-d33f-7bc9-308809b15b70@infradead.org> Date: Thu, 20 Jul 2017 16:47:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Language: en-US Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap Fix build errors by adding dependency on VIDEO_V4L2_SUBDEV_API: ../drivers/media/i2c/ov5670.c: In function 'ov5670_open': ../drivers/media/i2c/ov5670.c:1917:5: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration] v4l2_subdev_get_try_format(sd, fh->pad, 0); ../drivers/media/i2c/ov5670.c:1917:38: error: 'struct v4l2_subdev_fh' has no member named 'pad' v4l2_subdev_get_try_format(sd, fh->pad, 0); ../drivers/media/i2c/ov5670.c: In function 'ov5670_do_get_pad_format': ../drivers/media/i2c/ov5670.c:2198:17: error: invalid type argument of unary '*' (have 'int') fmt->format = *v4l2_subdev_get_try_format(&ov5670->sd, cfg, ../drivers/media/i2c/ov5670.c: In function 'ov5670_set_pad_format': ../drivers/media/i2c/ov5670.c:2236:3: error: invalid type argument of unary '*' (have 'int') *v4l2_subdev_get_try_format(sd, cfg, fmt->pad) = fmt->format; ../drivers/media/i2c/ov5670.c: At top level: ../drivers/media/i2c/ov5670.c:2444:19: error: 'v4l2_subdev_link_validate' undeclared here (not in a function) .link_validate = v4l2_subdev_link_validate, ../drivers/media/i2c/ov5670.c: In function 'ov5670_probe': ../drivers/media/i2c/ov5670.c:2492:12: error: 'struct v4l2_subdev' has no member named 'entity' ov5670->sd.entity.ops = &ov5670_subdev_entity_ops; ../drivers/media/i2c/ov5670.c:2493:12: error: 'struct v4l2_subdev' has no member named 'entity' ov5670->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR; ../drivers/media/i2c/ov5670.c:2497:42: error: 'struct v4l2_subdev' has no member named 'entity' ret = media_entity_pads_init(&ov5670->sd.entity, 1, &ov5670->pad); ../drivers/media/i2c/ov5670.c:2524:34: error: 'struct v4l2_subdev' has no member named 'entity' media_entity_cleanup(&ov5670->sd.entity); ../drivers/media/i2c/ov5670.c: In function 'ov5670_remove': ../drivers/media/i2c/ov5670.c:2544:26: error: 'struct v4l2_subdev' has no member named 'entity' media_entity_cleanup(&sd->entity); Signed-off-by: Randy Dunlap Cc: "Rapolu, Chiranjeevi" Cc: "Yang, Hyungwoo" --- drivers/media/i2c/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20170720.orig/drivers/media/i2c/Kconfig +++ linux-next-20170720/drivers/media/i2c/Kconfig @@ -618,7 +618,7 @@ config VIDEO_OV6650 config VIDEO_OV5670 tristate "OmniVision OV5670 sensor support" - depends on I2C && VIDEO_V4L2 + depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API depends on MEDIA_CAMERA_SUPPORT select V4L2_FWNODE ---help---