| Message ID | 8e1c6c3a32919603072bb7278c66b4d469f7e762.1721661958.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: raspberrypi: VIDEO_RASPBERRYPI_PISP_BE should depend on ARCH_BCM2835 | expand |
On 7/22/2024 8:28 AM, Geert Uytterhoeven wrote: > Currently, the Raspberry Pi PiSP Backend (BE) ISP is only present on the > Broadcom BCM2712-based Raspberry Pi 5. Hence add a dependency on > ARCH_BCM2835, to prevent asking the user about this driver when > configuring a kernel without Broadcom BCM2835 family support. The > dependency can be relaxed if/when the encoder appears on other SoC > families. > > Fixes: 12187bd5d4f8c128 ("media: raspberrypi: Add support for PiSP BE") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: FLorian Fainelli <florian.fainelli@broadcom.com> Thanks!
Hi Geert On Mon, Jul 22, 2024 at 05:28:28PM GMT, Geert Uytterhoeven wrote: > Currently, the Raspberry Pi PiSP Backend (BE) ISP is only present on the > Broadcom BCM2712-based Raspberry Pi 5. Hence add a dependency on ^ nit: double space > ARCH_BCM2835, to prevent asking the user about this driver when > configuring a kernel without Broadcom BCM2835 family support. The double space before "The" as well > dependency can be relaxed if/when the encoder appears on other SoC > families. we can surely lift this requirement in the unlikely event this happens Thanks Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > Fixes: 12187bd5d4f8c128 ("media: raspberrypi: Add support for PiSP BE") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/media/platform/raspberrypi/pisp_be/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/raspberrypi/pisp_be/Kconfig b/drivers/media/platform/raspberrypi/pisp_be/Kconfig > index 38c0f8305d620d83..46765a2e4c4d1573 100644 > --- a/drivers/media/platform/raspberrypi/pisp_be/Kconfig > +++ b/drivers/media/platform/raspberrypi/pisp_be/Kconfig > @@ -2,6 +2,7 @@ config VIDEO_RASPBERRYPI_PISP_BE > tristate "Raspberry Pi PiSP Backend (BE) ISP driver" > depends on V4L_PLATFORM_DRIVERS > depends on VIDEO_DEV > + depends on ARCH_BCM2835 || COMPILE_TEST > select VIDEO_V4L2_SUBDEV_API > select MEDIA_CONTROLLER > select VIDEOBUF2_DMA_CONTIG > -- > 2.34.1 >
Hi Jacopo, On Mon, Jul 22, 2024 at 5:59 PM Jacopo Mondi <jacopo.mondi@ideasonboard.com> wrote: > On Mon, Jul 22, 2024 at 05:28:28PM GMT, Geert Uytterhoeven wrote: > > Currently, the Raspberry Pi PiSP Backend (BE) ISP is only present on the > > Broadcom BCM2712-based Raspberry Pi 5. Hence add a dependency on > ^ nit: double space Yep, double space after a full stop. > > ARCH_BCM2835, to prevent asking the user about this driver when > > configuring a kernel without Broadcom BCM2835 family support. The > > double space before "The" as well Likewise. > Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks! Gr{oetje,eeting}s, Geert
diff --git a/drivers/media/platform/raspberrypi/pisp_be/Kconfig b/drivers/media/platform/raspberrypi/pisp_be/Kconfig index 38c0f8305d620d83..46765a2e4c4d1573 100644 --- a/drivers/media/platform/raspberrypi/pisp_be/Kconfig +++ b/drivers/media/platform/raspberrypi/pisp_be/Kconfig @@ -2,6 +2,7 @@ config VIDEO_RASPBERRYPI_PISP_BE tristate "Raspberry Pi PiSP Backend (BE) ISP driver" depends on V4L_PLATFORM_DRIVERS depends on VIDEO_DEV + depends on ARCH_BCM2835 || COMPILE_TEST select VIDEO_V4L2_SUBDEV_API select MEDIA_CONTROLLER select VIDEOBUF2_DMA_CONTIG
Currently, the Raspberry Pi PiSP Backend (BE) ISP is only present on the Broadcom BCM2712-based Raspberry Pi 5. Hence add a dependency on ARCH_BCM2835, to prevent asking the user about this driver when configuring a kernel without Broadcom BCM2835 family support. The dependency can be relaxed if/when the encoder appears on other SoC families. Fixes: 12187bd5d4f8c128 ("media: raspberrypi: Add support for PiSP BE") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/media/platform/raspberrypi/pisp_be/Kconfig | 1 + 1 file changed, 1 insertion(+)