From patchwork Fri Oct 16 20:27:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7420661 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A0379BEEA4 for ; Fri, 16 Oct 2015 20:28:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DE390205BE for ; Fri, 16 Oct 2015 20:27:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 021AE205BB for ; Fri, 16 Oct 2015 20:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932414AbbJPU1n (ORCPT ); Fri, 16 Oct 2015 16:27:43 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:60105 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753458AbbJPU1m (ORCPT ); Fri, 16 Oct 2015 16:27:42 -0400 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0LhGOe-1aI8cZ1xWC-00mb67; Fri, 16 Oct 2015 22:27:35 +0200 From: Arnd Bergmann To: Hans Verkuil Cc: Mauro Carvalho Chehab , Laurent Pinchart , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org Subject: [PATCH] [media] sh-vou: clarify videobuf2 dependency Date: Fri, 16 Oct 2015 22:27:29 +0200 Message-ID: <9667468.98avsAXYlo@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:rE3hhIciYXCbXTr8VgLeQs5lj2HU/H/TjyIQJIWC/DNQhubOHoI Vho27pvBsHk6vA/T8eYVdOCYDSonmhMI956J+rOnCi0L7t+nfRvmluYW8VkbtW0nBEeVrTT ZV1ofjvVX7bQ4/V1TktvztIwiU+thlSjaId4zed5gdJbU+zmfSeLGRZt9FHLQhNDfZZo5II i6whes2B2DCL0Mf5CRD0Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:mON/rWqtYUE=:uBwPMQS5gteHMiVE3DzrAM cvDxwkDYpPVAYYc+CIHGsTXlWD6YlrW4P6jixp3KlqwftU4YMSobN08015zRcK/OMxsuDwoMB x9YSXk8qLD8yHkCGge+/UgB7XddCcS+3H8SHUhcWni4z/mIfiICkxrT6QuGfJAPFOEtKyMkcL nh2a6YaH1WX8Qa95EUUul1hOvO6J+iiq6tz8nCs1wuND83dh50x/W7ZRJZM8SJuvjgjyfZLGD IKTENgvg4hrLgi8ODWXA5JMM6Tm3lkRLgJmsRp31aOJO6gYE6xVYUEB2OpNskcCGVbxuFpA8f SdN7uup37OVHLlWKZSBrg5O9m4TdzJ37Nei4YTGsdUmCl3+A3wB2qvZFmIABh1IzhHNDBVl43 37T7kCyGSE3nbmM0RV7vTcH+Cb8rIlNcvTyKVKk0UPiBafoCmsvwD5g4xcyLgxIg8/AfdbssH OgR/msoIH4+VS3j9NRLtxzpP1F3aWDYncCfdtrubjeSKG3PrVn/3ai1u9lAqT9jw1hokJGqcZ QYjROIA+m+t/jV8g+jnqhcKva5cpo7v4mYskPZILY5y7s44/1ywUU825tPsYWa925oQMEaQr6 nTOKxn1XLE+/RpaMY+iK68swlyl8yLrtAbqrSnHs3EDiQ6HWQ82oTR20QYD792G5CzNrE6yI+ 8x5i+dPNzBrL7C3v79Lm7r53sNGU6etciGSN9dS+NAl3KSDQRgDJF8n/meA/1Qnv01icDmbnI 7L6gMQBC5nhpWbVT Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The sh-vou driver has been converted from videobuf to videobuf2, but the Kconfig file still lists VIDEOBUF_DMA_CONTIG as a dependency. Consequently we can build the driver without VIDEOBUF2_DMA_CONTIG and get a link error: drivers/built-in.o: In function `sh_vou_probe': vf610-ocotp.c:(.text+0x2dbf5c): undefined reference to `vb2_dma_contig_init_ctx' vf610-ocotp.c:(.text+0x2dc0b4): undefined reference to `vb2_dma_contig_cleanup_ctx' vf610-ocotp.c:(.text+0x2dc144): undefined reference to `vb2_dma_contig_memops' drivers/built-in.o: In function `sh_vou_remove': vf610-ocotp.c:(.text+0x2dc190): undefined reference to `vb2_dma_contig_cleanup_ctx' This changes the dependency to VIDEOBUF2_DMA_CONTIG instead. Signed-off-by: Arnd Bergmann Fixes: 57af3ad59d95 ("[media] sh-vou: convert to vb2") --- Found on ARM randconfig tests -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index f88a6cfb7086..3ddf72f2d844 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -38,7 +38,7 @@ config VIDEO_SH_VOU depends on MEDIA_CAMERA_SUPPORT depends on VIDEO_DEV && I2C && HAS_DMA depends on ARCH_SHMOBILE || COMPILE_TEST - select VIDEOBUF_DMA_CONTIG + select VIDEOBUF2_DMA_CONTIG help Support for the Video Output Unit (VOU) on SuperH SoCs.