From patchwork Sat Jun 11 17:48:30 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 872062 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p5BHmh1V030833 for ; Sat, 11 Jun 2011 17:48:43 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753246Ab1FKRsl (ORCPT ); Sat, 11 Jun 2011 13:48:41 -0400 Received: from smtp-vbr15.xs4all.nl ([194.109.24.35]:3227 "EHLO smtp-vbr15.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506Ab1FKRsl (ORCPT ); Sat, 11 Jun 2011 13:48:41 -0400 Received: from tschai.lan (215.80-203-102.nextgentel.com [80.203.102.215]) (authenticated bits=0) by smtp-vbr15.xs4all.nl (8.13.8/8.13.8) with ESMTP id p5BHmbw8092582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 11 Jun 2011 19:48:38 +0200 (CEST) (envelope-from hverkuil@xs4all.nl) From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil Subject: [RFCv3 PATCH 1/6] tuner-core: rename check_mode to supported_mode Date: Sat, 11 Jun 2011 19:48:30 +0200 Message-Id: <980897e53f7cc2ec9bbbf58d9d451ee56a249309.1307813916.git.hans.verkuil@cisco.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1307814515-17351-1-git-send-email-hverkuil@xs4all.nl> References: <1307814515-17351-1-git-send-email-hverkuil@xs4all.nl> X-Virus-Scanned: by XS4ALL Virus Scanner Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Sat, 11 Jun 2011 17:48:44 +0000 (UTC) From: Hans Verkuil The check_mode function checks whether a mode is supported. So calling it supported_mode is more appropriate. In addition it returned either 0 or -EINVAL which suggests that the -EINVAL error should be passed on. However, that's not the case so change the return type to bool. Signed-off-by: Hans Verkuil --- drivers/media/video/tuner-core.c | 19 ++++++++----------- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c index 5748d04..083b9f1 100644 --- a/drivers/media/video/tuner-core.c +++ b/drivers/media/video/tuner-core.c @@ -723,22 +723,19 @@ static int tuner_remove(struct i2c_client *client) */ /** - * check_mode - Verify if tuner supports the requested mode + * supported_mode - Verify if tuner supports the requested mode * @t: a pointer to the module's internal struct_tuner * * This function checks if the tuner is capable of tuning analog TV, * digital TV or radio, depending on what the caller wants. If the - * tuner can't support that mode, it returns -EINVAL. Otherwise, it - * returns 0. + * tuner can't support that mode, it returns false. Otherwise, it + * returns true. * This function is needed for boards that have a separate tuner for * radio (like devices with tea5767). */ -static inline int check_mode(struct tuner *t, enum v4l2_tuner_type mode) +static bool supported_mode(struct tuner *t, enum v4l2_tuner_type mode) { - if ((1 << mode & t->mode_mask) == 0) - return -EINVAL; - - return 0; + return 1 << mode & t->mode_mask; } /** @@ -759,7 +756,7 @@ static int set_mode_freq(struct i2c_client *client, struct tuner *t, struct analog_demod_ops *analog_ops = &t->fe.ops.analog_ops; if (mode != t->mode) { - if (check_mode(t, mode) == -EINVAL) { + if (!supported_mode(t, mode)) { tuner_dbg("Tuner doesn't support mode %d. " "Putting tuner to sleep\n", mode); t->standby = true; @@ -1138,7 +1135,7 @@ static int tuner_g_frequency(struct v4l2_subdev *sd, struct v4l2_frequency *f) struct tuner *t = to_tuner(sd); struct dvb_tuner_ops *fe_tuner_ops = &t->fe.ops.tuner_ops; - if (check_mode(t, f->type) == -EINVAL) + if (!supported_mode(t, f->type)) return 0; f->type = t->mode; if (fe_tuner_ops->get_frequency && !t->standby) { @@ -1161,7 +1158,7 @@ static int tuner_g_tuner(struct v4l2_subdev *sd, struct v4l2_tuner *vt) struct analog_demod_ops *analog_ops = &t->fe.ops.analog_ops; struct dvb_tuner_ops *fe_tuner_ops = &t->fe.ops.tuner_ops; - if (check_mode(t, vt->type) == -EINVAL) + if (!supported_mode(t, vt->type)) return 0; vt->type = t->mode; if (analog_ops->get_afc)