From patchwork Wed Jun 28 20:25:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9815395 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 70EF9603F2 for ; Wed, 28 Jun 2017 20:25:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61D472029B for ; Wed, 28 Jun 2017 20:25:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 550C624151; Wed, 28 Jun 2017 20:25:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 09A862029B for ; Wed, 28 Jun 2017 20:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751553AbdF1UZN (ORCPT ); Wed, 28 Jun 2017 16:25:13 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:35814 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbdF1UZM (ORCPT ); Wed, 28 Jun 2017 16:25:12 -0400 Received: by mail-oi0-f68.google.com with SMTP id l130so6681353oib.2; Wed, 28 Jun 2017 13:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lORRQcv/3xfJSbTKM66Q9h/T2RQPSXvB3LwOMcHOlbA=; b=Ku45IcUt2wDuoQeUgZa3JXTg2//fnKrbdRXGooS77f49RG8nGuLnAcMloo8d5j+VKX lvC+3iKWGOv+jEqOCWJd8/NgA51q2VDY7uNAcAQM/uegxOgPrYUVucX0eqXSLkTfrYNC DuBNi8psAPAFoHGHt9Z+H0gx8WLUPfGFlwevt5mE09NOIY5aRV5X+Yys+yxK92nSSfiJ pk99B/rrHan7jjMULkAin3311a497gp2+nPlqOgBUpFPQoXPNEVZGM3jZ+lgvHnJmVLa 2mVOgwKMcVNN3ke4f6ZqDozzPZeGXSpJCkz+FzUYVjyruxIYw5UK5hWWm7fNDdjsmBXW b8Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lORRQcv/3xfJSbTKM66Q9h/T2RQPSXvB3LwOMcHOlbA=; b=b/9H2bJOsSf/SheddNx+yX5bbHf/02o/ut33JmCxEM8PuyMBPu5/zX9NgHve7IzIsW wsT8VNICo7aFexMIHxf0a5UvgKpG80Fz47ioUrKky1Pbnfen1jGQ4bw1UezbRY2OkveZ +HC3fCDM+2y0hgBiChPoTyMTw1ZWs2MHEVcZIVddy2xvZm2eKWs+wyq/d2Cz/6zAHayN FO6bW19M38FMjE7YRwh8d0lXVnJMeftLR8uA/Td6SuVfzsnOAtk+QBTJP/2ulnhuyWs7 xsyGPNRgdiqKSeG3Px/7z4WBILmsQLTfD0X4CAqDWGLo/v6x+YBauN+vMob638ELpXhq FM6A== X-Gm-Message-State: AKS2vOzKrotLwl7CZQOzBuSprTI5s3SrQ1Eee6rxf9EEiE+reuDFxF73 4jTvUCF/0cb9/eNPK+ul1Jb1M/pAMq7r0bo= X-Received: by 10.202.75.77 with SMTP id y74mr7311200oia.151.1498681511435; Wed, 28 Jun 2017 13:25:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.51.72 with HTTP; Wed, 28 Jun 2017 13:25:10 -0700 (PDT) In-Reply-To: References: <20170627150310.719212-1-arnd@arndb.de> <20170627150310.719212-3-arnd@arndb.de> From: Arnd Bergmann Date: Wed, 28 Jun 2017 22:25:10 +0200 X-Google-Sender-Auth: 3v-7Fyp6KrDsS81BLl-xOfohAOI Message-ID: Subject: Re: [PATCH 3/3] [media] venus: fix compile-test build on non-qcom ARM platform To: Stanimir Varbanov Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Linux Kernel Mailing List Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jun 27, 2017 at 9:45 PM, Stanimir Varbanov wrote: > Hi Arnd, > > On 27.06.2017 18:02, Arnd Bergmann wrote: >> >> If QCOM_MDT_LOADER is enabled, but ARCH_QCOM is not, we run into >> a build error: >> >> ERROR: "qcom_mdt_load" [drivers/media/platform/qcom/venus/venus-core.ko] >> undefined! >> ERROR: "qcom_mdt_get_size" >> [drivers/media/platform/qcom/venus/venus-core.ko] undefined! > > > Ahh, thanks for the fix, these two will also pursuing me in my dreams. I just came after me as well, as I hit another corner case, we need this fixup on top, I'll send a replacement: Subject: [PATCH] fixup! [media] venus: fix compile-test build on non-qcom ARM platform Signed-off-by: Arnd Bergmann fw_dev->parent = parent; diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c index 76edb9f60311..3794b9e3250b 100644 --- a/drivers/media/platform/qcom/venus/firmware.c +++ b/drivers/media/platform/qcom/venus/firmware.c @@ -40,7 +40,7 @@ int venus_boot(struct device *parent, struct device *fw_dev, const char *fwname) void *mem_va; int ret; - if (!qcom_scm_is_available()) + if (!IS_ENABLED(CONFIG_QCOM_MDT_LOADER) || !qcom_scm_is_available()) return -EPROBE_DEFER;