From patchwork Mon Sep 30 07:09:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 2962741 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 49D479F88A for ; Mon, 30 Sep 2013 07:09:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4EAEF20265 for ; Mon, 30 Sep 2013 07:09:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 482D820259 for ; Mon, 30 Sep 2013 07:09:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372Ab3I3HJO (ORCPT ); Mon, 30 Sep 2013 03:09:14 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:52553 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228Ab3I3HJN (ORCPT ); Mon, 30 Sep 2013 03:09:13 -0400 Received: by mail-pa0-f44.google.com with SMTP id lf10so5477723pab.31 for ; Mon, 30 Sep 2013 00:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=j567Gi5+9oWvPCvPsg6tCNHfldLQODm3LGUhTUBLfEo=; b=zSDmhpXAfswVYaM1FSqLAuTjX9RbyjRkzUcQ8opN+ubQf53a2F4ipwUAfaYLfStvcX /NN4bqYtP9V+pMVWRLnMK3syMi3yIdnXjmn+k0RcmRrku5w5RuE6C9YSnYVzRTMsF0YG afknrX8qoYAVZK3hzCS67P5krFVMtXjlKVmcgbVXZnNdN4CgafJ9lfsmSM96nAGfYJRF zTobhegyEEKZKnaklI8+JDMdybK8ydfFvXU84iuJQn969ejp6va0FsoCW/d9lKeLWX/X LzY036B4zfcqQoHc/zZnK9DWhWFQjJDOFTUDjuuX/RaChTiOTFnxwXdA/2a5+SU3VHMV j4CQ== MIME-Version: 1.0 X-Received: by 10.66.154.197 with SMTP id vq5mr1484008pab.155.1380524953334; Mon, 30 Sep 2013 00:09:13 -0700 (PDT) Received: by 10.70.18.229 with HTTP; Mon, 30 Sep 2013 00:09:13 -0700 (PDT) In-Reply-To: <20130930030518.GA3024@localhost> References: <5248d26d.XCpLjin/D8FfRGFk%fengguang.wu@intel.com> <20130930030518.GA3024@localhost> Date: Mon, 30 Sep 2013 09:09:13 +0200 X-Google-Sender-Auth: Z2b4YhMVkzYXLHf-2W51CKFhAyg Message-ID: Subject: Re: mcam-core.c:undefined reference to `vb2_dma_sg_memops' From: Geert Uytterhoeven To: Fengguang Wu Cc: kbuild-all@01.org, Jonathan Corbet , Mauro Carvalho Chehab , Linux Media Mailing List Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Fengguang, On Mon, Sep 30, 2013 at 5:05 AM, Fengguang Wu wrote: > FYI, kernel build failed on > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 15c03dd4859ab16f9212238f29dd315654aa94f6 > commit: 866f321339988293a5bb3ec6634c2c9d8396bf54 Revert "staging/solo6x10: depend on CONFIG_FONTS" > date: 3 months ago > config: x86_64-randconfig-c5-0930 (attached as .config) > > All error/warnings: > > drivers/built-in.o: In function `mcam_v4l_open': >>> mcam-core.c:(.text+0x3bf73a): undefined reference to `vb2_dma_sg_memops' The referenced commit above is completely unrelated to this failure, as both CONFIG_SOLO6X10=m and CONFIG_VIDEOBUF2_DMA_SG=m, while this is about a missing symbol in builtin code. However, there's something wrong with the VIDEO_CAFE_CCIC dependencies. Untested gmail-white-space-damaged patch below (so your trick of emailing random people to obtain a solution worked ;-) From 8a53ff3c33cfaa8641c9ba3e16bc5b0a35c74842 Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven Date: Mon, 30 Sep 2013 09:03:20 +0200 Subject: [PATCH] [media] VIDEO_CAFE_CCIC should select VIDEOBUF2_DMA_SG If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m: drivers/built-in.o: In function `mcam_v4l_open': >> mcam-core.c:(.text+0x3bf73a): undefined reference to `vb2_dma_sg_memops' Reported-by: Fengguang Wu Signed-off-by: Geert Uytterhoeven --- drivers/media/platform/marvell-ccic/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/marvell-ccic/Kconfig b/drivers/media/platform/marvell-ccic/Kconfig index bf739e3..ec4c771 100644 --- a/drivers/media/platform/marvell-ccic/Kconfig +++ b/drivers/media/platform/marvell-ccic/Kconfig @@ -4,6 +4,7 @@ config VIDEO_CAFE_CCIC select VIDEO_OV7670 select VIDEOBUF2_VMALLOC select VIDEOBUF2_DMA_CONTIG + select VIDEOBUF2_DMA_SG ---help--- This is a video4linux2 driver for the Marvell 88ALP01 integrated CMOS camera controller. This is the controller found on first-