From patchwork Tue Jan 19 11:12:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 8060671 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 26A4A9F1CC for ; Tue, 19 Jan 2016 11:12:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5ED5F203B1 for ; Tue, 19 Jan 2016 11:12:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A8762038F for ; Tue, 19 Jan 2016 11:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751383AbcASLMy (ORCPT ); Tue, 19 Jan 2016 06:12:54 -0500 Received: from mout.gmx.net ([212.227.17.21]:59738 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbcASLMy (ORCPT ); Tue, 19 Jan 2016 06:12:54 -0500 Received: from axis700.grange ([81.173.136.213]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0Lpxdr-1ZgdcL34Ap-00fgZZ; Tue, 19 Jan 2016 12:12:50 +0100 Received: by axis700.grange (Postfix, from userid 1000) id C2A42FF63; Tue, 19 Jan 2016 12:12:48 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by axis700.grange (Postfix) with ESMTP id BB82A13EC9; Tue, 19 Jan 2016 12:12:48 +0100 (CET) Date: Tue, 19 Jan 2016 12:12:48 +0100 (CET) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Linux Media Mailing List cc: Sylwester Nawrocki , Laurent Pinchart Subject: [PATCH] V4L: fix ov9650 control clusters Message-ID: MIME-Version: 1.0 X-Provags-ID: V03:K0:9wjuevJlX/1tHVYAmTYrSmuYj3csyQU+FZmkNMfMUj5UdCSiscb 7FD41u3gbA17/3zenM84EN2sj5cShT2ccCyK6Xv3J88kv2FI8Hsv7kpl0llyqbuaHxiCUoO JckGXS1fwtdYV43Z5doFizUIsDG/MXiJo1DtTekpMgjfDDal05ObCNyUKYmw1UQtx0v31SA iPzfTuv5iJTw/3pkdVtaw== X-UI-Out-Filterresults: notjunk:1; V01:K0:4N7GVKqzRmE=:LpY0W5R7/+GRTIHtP5APb0 hx59V6Jl2/7GKGKpqfq/pBqv2jhbG5keyboQBCx3dDMwakcB3XAKJlVqA07vlDG1k4I5GTPGZ AWMkjh/KMV21mGfhxEB/ukvuTkaQRVM1+2OQnz6//HfrgtIfJC8JZi9wWMGnKfOF9UPnzLg8p /BqibkmCj27fv2jq9pLJPU+DLG7JV09ShEGCkWjj82xvcozQXwMzSsJYroTT3cbuJE76Eaj9X q222zw51sbTGosPuXUrRQaSfwyOMdcRQmtiOCsNx6+upGb8gs67ERZ3Fvp2+gbD/HzpZVoojC +OtlUFAHzKenrpYu6iMRSeQovqxbg/3PBZzwPiB3cBn8Rumm8jxCMEsxhTxGPV3TzHIHlmDnx L96Pr2LSP8ynYFyxm9yENxzMHKZFN0qfgnL4oYJGyHe7eW4CJ57Z7XTMm5tCc3eWgnZFr5A9H LJW+KPWDypbewrPQhUX8LJEODLJQKhJON+MBlHHX6/9k1uU8yMfz/lGbGuUE7JqzBTq6mVIv9 8otwq906l4U9SmFpTqYT0xvjGqmEi/7IP2eNzVeADwd+QKbAnvxtVsFSTK+myoDbYF3Z63V4B 4Y0hvieCm3Nza9mA9Gll5dgDlsoHg0NfeHV/9n2Uaq/LWZJaHVnX1n6bjfDj84xMmbD07UDpP s+4ULAtwWe+wDqMvs0+6aRuj5CMuyNaOPdAjjymMu8uqU/pdY9c442jEuvF5+45P0voFo00mM iVUi8ng7Crj2PxnaBWslFiL+dI1NhDANFpX9AfToKrNi1ABNe0VYkEZoFRmaIfUeQYLWyYd7j nbX+2VS Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Auto-gain and auto-exposure clusters in the ov9650 driver have both a size of 2, not 3 controls. Fix this. Signed-off-by: Guennadi Liakhovetski Reviewed-by: Laurent Pinchart --- drivers/media/i2c/ov9650.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c index 9fe9006..2baa528 100644 --- a/drivers/media/i2c/ov9650.c +++ b/drivers/media/i2c/ov9650.c @@ -1046,8 +1046,8 @@ static int ov965x_initialize_controls(struct ov965x *ov965x) ctrls->exposure->flags |= V4L2_CTRL_FLAG_VOLATILE; v4l2_ctrl_auto_cluster(3, &ctrls->auto_wb, 0, false); - v4l2_ctrl_auto_cluster(3, &ctrls->auto_gain, 0, true); - v4l2_ctrl_auto_cluster(3, &ctrls->auto_exp, 1, true); + v4l2_ctrl_auto_cluster(2, &ctrls->auto_gain, 0, true); + v4l2_ctrl_auto_cluster(2, &ctrls->auto_exp, 1, true); v4l2_ctrl_cluster(2, &ctrls->hflip); ov965x->sd.ctrl_handler = hdl;