mbox series

[GIT,PULL,FOR,v6.7] RC fixes

Message ID ZQAK1UxQlcx2ExWr@gofer.mess.org (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL,FOR,v6.7] RC fixes | expand

Pull-request

git://linuxtv.org/syoung/media_tree.git tags/v6.7a

Message

Sean Young Sept. 12, 2023, 6:53 a.m. UTC 
The following changes since commit f32b68cd3604a824769ffeb02d2adea492a9d221:

  media: cx231xx: Add EP5_BUF_SIZE and EP5_TIMEOUT_MS macros (2023-09-06 12:29:09 +0200)

are available in the Git repository at:

  git://linuxtv.org/syoung/media_tree.git tags/v6.7a

for you to fetch changes up to c6ab671c3b08b7b5231346ec7a7f06ff2b22bf07:

  arm64: dts: meson: add IR controller for Meson-S4 SoC (2023-09-11 11:49:43 +0100)

----------------------------------------------------------------
v6.7a

----------------------------------------------------------------
Sean Young (2):
      dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible
      media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

Zelong Dong (2):
      media: rc: meson-ir: support rc driver type RC_DRIVER_SCANCODE
      arm64: dts: meson: add IR controller for Meson-S4 SoC

 .../devicetree/bindings/leds/irled/pwm-ir-tx.yaml  |   5 +-
 .../devicetree/bindings/media/nokia,n900-ir        |  20 -
 arch/arm/configs/omap2plus_defconfig               |   1 -
 .../boot/dts/amlogic/meson-s4-s805x2-aq222.dts     |   6 +
 arch/arm64/boot/dts/amlogic/meson-s4.dtsi          |  15 +
 drivers/media/rc/Kconfig                           |  10 -
 drivers/media/rc/Makefile                          |   1 -
 drivers/media/rc/ir-rx51.c                         | 285 -----------
 drivers/media/rc/meson-ir.c                        | 522 ++++++++++++++++++---
 drivers/media/rc/pwm-ir-tx.c                       |   1 +
 10 files changed, 477 insertions(+), 389 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir
 delete mode 100644 drivers/media/rc/ir-rx51.c

Comments

Jenkins Sept. 12, 2023, 7:21 a.m. UTC | #1 
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/ZQAK1UxQlcx2ExWr@gofer.mess.org/
Build log: https://builder.linuxtv.org/job/patchwork/338983/
Build time: 00:22:19
Link: https://lore.kernel.org/linux-media/ZQAK1UxQlcx2ExWr@gofer.mess.org

gpg: Signature made Tue 12 Sep 2023 06:47:44 AM UTC
gpg:                using RSA key A624251A26084A9ED9E4C8B6425F639D3960FA9E
gpg:                issuer "sean@mess.org"
gpg: Good signature from "Sean Young <sean@mess.org>" [full]

Summary: got 4/4 patches with issues, being 1 at build time

Error/warnings:

patches/0001-dt-bindings-media-remove-nokia-n900-ir-as-pwm-ir-tx-.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:447 gc0310_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_fops.c: ../drivers/staging/media/atomisp/pci/atomisp_fops.c:517 atomisp_open() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2801 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2900 atomisp_cp_morph_table() warn: missing unwind goto?

    allyesconfig: return code #0:
	../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	../drivers/media/usb/dvb-usb-v2/af9035.c: ../drivers/media/usb/dvb-usb-v2/af9035.c:467 af9035_i2c_master_xfer() warn: inconsistent returns '&d->i2c_mutex'.
	  Locked on  : 326,387
	  Unlocked on: 465,467
	../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2792 mxc_jpeg_probe() warn: missing unwind goto?
	../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
	../drivers/media/usb/uvc/uvc_v4l2.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../include/linux/rcuwait.h, ...):
	SPARSE:../drivers/media/usb/uvc/uvc_v4l2.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() parse error: OOM: 3000008Kb sm_state_count = 1970648
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() warn: Function too hairy.  No more merges.
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() parse error: __split_smt: function too hairy.  Giving up after 54 seconds
	../drivers/media/pci/ivtv/ivtvfb.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../drivers/media/pci/ivtv/ivtv-driver.h):
	SPARSE:../drivers/media/pci/ivtv/ivtvfb.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2890 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

   checkpatch.pl:
	$ cat patches/0001-dt-bindings-media-remove-nokia-n900-ir-as-pwm-ir-tx-.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:35: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
	-:38: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

patches/0002-media-rc-remove-ir-rx51-in-favour-of-generic-pwm-ir-.patch:

   checkpatch.pl:
	$ cat patches/0002-media-rc-remove-ir-rx51-in-favour-of-generic-pwm-ir-.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:75: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

patches/0003-media-rc-meson-ir-support-rc-driver-type-RC_DRIVER_S.patch:

   checkpatch.pl:
	$ cat patches/0003-media-rc-meson-ir-support-rc-driver-type-RC_DRIVER_S.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:620: WARNING: DT compatible string "amlogic,meson-s4-ir" appears un-documented -- check ./Documentation/devicetree/bindings/

patches/0004-arm64-dts-meson-add-IR-controller-for-Meson-S4-SoC.patch:

   checkpatch.pl:
	$ cat patches/0004-arm64-dts-meson-add-IR-controller-for-Meson-S4-SoC.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:55: WARNING: DT compatible string "amlogic,meson-s4-ir" appears un-documented -- check ./Documentation/devicetree/bindings/
Hans Verkuil Sept. 21, 2023, 12:55 p.m. UTC | #2 
Hi Sean,

On 12/09/2023 08:53, Sean Young wrote:
> The following changes since commit f32b68cd3604a824769ffeb02d2adea492a9d221:
> 
>   media: cx231xx: Add EP5_BUF_SIZE and EP5_TIMEOUT_MS macros (2023-09-06 12:29:09 +0200)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/syoung/media_tree.git tags/v6.7a
> 
> for you to fetch changes up to c6ab671c3b08b7b5231346ec7a7f06ff2b22bf07:
> 
>   arm64: dts: meson: add IR controller for Meson-S4 SoC (2023-09-11 11:49:43 +0100)
> 
> ----------------------------------------------------------------
> v6.7a
> 
> ----------------------------------------------------------------
> Sean Young (2):
>       dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible
>       media: rc: remove ir-rx51 in favour of generic pwm-ir-tx
> 
> Zelong Dong (2):
>       media: rc: meson-ir: support rc driver type RC_DRIVER_SCANCODE
>       arm64: dts: meson: add IR controller for Meson-S4 SoC

I think you accidentally picked the dts patch instead of the bindings
patch (1), since that one is missing, leading to a checkpatch warning:

WARNING: DT compatible string "amlogic,meson-s4-ir" appears un-documented -- check ./Documentation/devicetree/bindings/
#56: FILE: arch/arm64/boot/dts/amlogic/meson-s4.dtsi:146:
+                               compatible = "amlogic,meson-s4-ir";

I'll mark this PR as 'Changes Requested', since this can't be right.

Regards,

	Hans

(1) https://patchwork.linuxtv.org/project/linux-media/patch/20230825115310.39993-3-zelong.dong@amlogic.com/

> 
>  .../devicetree/bindings/leds/irled/pwm-ir-tx.yaml  |   5 +-
>  .../devicetree/bindings/media/nokia,n900-ir        |  20 -
>  arch/arm/configs/omap2plus_defconfig               |   1 -
>  .../boot/dts/amlogic/meson-s4-s805x2-aq222.dts     |   6 +
>  arch/arm64/boot/dts/amlogic/meson-s4.dtsi          |  15 +
>  drivers/media/rc/Kconfig                           |  10 -
>  drivers/media/rc/Makefile                          |   1 -
>  drivers/media/rc/ir-rx51.c                         | 285 -----------
>  drivers/media/rc/meson-ir.c                        | 522 ++++++++++++++++++---
>  drivers/media/rc/pwm-ir-tx.c                       |   1 +
>  10 files changed, 477 insertions(+), 389 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir
>  delete mode 100644 drivers/media/rc/ir-rx51.c
Sean Young Sept. 21, 2023, 2:58 p.m. UTC | #3 
On Thu, Sep 21, 2023 at 02:55:32PM +0200, Hans Verkuil wrote:
> Hi Sean,
> 
> On 12/09/2023 08:53, Sean Young wrote:
> > The following changes since commit f32b68cd3604a824769ffeb02d2adea492a9d221:
> > 
> >   media: cx231xx: Add EP5_BUF_SIZE and EP5_TIMEOUT_MS macros (2023-09-06 12:29:09 +0200)
> > 
> > are available in the Git repository at:
> > 
> >   git://linuxtv.org/syoung/media_tree.git tags/v6.7a
> > 
> > for you to fetch changes up to c6ab671c3b08b7b5231346ec7a7f06ff2b22bf07:
> > 
> >   arm64: dts: meson: add IR controller for Meson-S4 SoC (2023-09-11 11:49:43 +0100)
> > 
> > ----------------------------------------------------------------
> > v6.7a
> > 
> > ----------------------------------------------------------------
> > Sean Young (2):
> >       dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible
> >       media: rc: remove ir-rx51 in favour of generic pwm-ir-tx
> > 
> > Zelong Dong (2):
> >       media: rc: meson-ir: support rc driver type RC_DRIVER_SCANCODE
> >       arm64: dts: meson: add IR controller for Meson-S4 SoC
> 
> I think you accidentally picked the dts patch instead of the bindings
> patch (1), since that one is missing, leading to a checkpatch warning:
> 
> WARNING: DT compatible string "amlogic,meson-s4-ir" appears un-documented -- check ./Documentation/devicetree/bindings/
> #56: FILE: arch/arm64/boot/dts/amlogic/meson-s4.dtsi:146:
> +                               compatible = "amlogic,meson-s4-ir";
> 
> I'll mark this PR as 'Changes Requested', since this can't be right.

Yes, you're right, that's my bad. Thanks for catching that early. 

I'll respin.

Thanks,

Sean