Message ID | ac74fda5-4160-1cd7-4ce1-bb8ad64aed51@xs4all.nl (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [GIT,PULL,FOR,v6.2] Various fixes and enhancements | expand |
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/ac74fda5-4160-1cd7-4ce1-bb8ad64aed51@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/259856/
Build time: 00:00:00
Link: https://lore.kernel.org/linux-media/ac74fda5-4160-1cd7-4ce1-bb8ad64aed51@xs4all.nl
gpg: Signature made Mon 28 Nov 2022 09:16:31 AM UTC
gpg: using EDDSA key 52ADCAAE8A4F70B99ACD8D726B425DF79B1C1E76
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]
Build aborted due to a fatal error:
FAILED: patch patch patches/0001-media-s5p-mfc-Add-variant-data-for-MFC-v7-hardware-f.patch doesn't apply:
Applying patch patches/0001-media-s5p-mfc-Add-variant-data-for-MFC-v7-hardware-f.patch
patching file drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
Hunk #1 FAILED at 1590.
Hunk #2 succeeded at 1671 with fuzz 2 (offset 10 lines).
1 out of 2 hunks FAILED -- rejects in file drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
Patch patches/0001-media-s5p-mfc-Add-variant-data-for-MFC-v7-hardware-f.patch can be reverse-applied
On Mon, Nov 28, 2022 at 11:04:51AM +0100, Hans Verkuil wrote: > The following changes since commit 3ab848bea7790583674a0e08eb5f8c1553d07751: > > media: dt-bindings: s5p-mfc: Add new compatible string for Exynos3250 SoC (2022-11-25 11:33:17 +0000) > > are available in the Git repository at: > > git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.2i > Jason A. Donenfeld (1): > media: stv0288: use explicitly signed char If this is for 6.2, rather than as a bug fix for 6.1, then please drop it from this pull, and I'll include it as part of the pull of all of these -funsigned-char fixes for 6.2, per Linus' request. Note that I sent this for 6.1 and followed up on it several times, but my emails went entirely ignored, and then today I found this in my inbox, not because I was CC'd but because my lore search matches on my last name. During that time, I regularly checked the linux-media tree to see if you had applied it silently, but that also wasn't the case. So I'm pretty sure the "confusion" here is entirely on you for ignoring emails and not communicating. So, anyway, please remove this patch from your pull. Thanks, Jason
Hi Jason, On 11/28/22 12:56, Jason A. Donenfeld wrote: > On Mon, Nov 28, 2022 at 11:04:51AM +0100, Hans Verkuil wrote: >> The following changes since commit 3ab848bea7790583674a0e08eb5f8c1553d07751: >> >> media: dt-bindings: s5p-mfc: Add new compatible string for Exynos3250 SoC (2022-11-25 11:33:17 +0000) >> >> are available in the Git repository at: >> >> git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.2i > >> Jason A. Donenfeld (1): >> media: stv0288: use explicitly signed char > > If this is for 6.2, rather than as a bug fix for 6.1, then please drop > it from this pull, and I'll include it as part of the pull of all of > these -funsigned-char fixes for 6.2, per Linus' request. OK, it's dropped in v2 of my PR. > > Note that I sent this for 6.1 and followed up on it several times, but > my emails went entirely ignored, and then today I found this in my inbox, > not because I was CC'd but because my lore search matches on my last > name. During that time, I regularly checked the linux-media tree to see > if you had applied it silently, but that also wasn't the case. So I'm > pretty sure the "confusion" here is entirely on you for ignoring emails > and not communicating. Mauro is extremely busy, so last week I've been going through older patches and picked this one up. It would have gone in for v6.2 :-) Regards, Hans > > So, anyway, please remove this patch from your pull. > > Thanks, > Jason