From patchwork Tue Aug 2 08:18:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: BOUWSMA Barry X-Patchwork-Id: 1028302 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p728J92O015962 for ; Tue, 2 Aug 2011 08:19:09 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752445Ab1HBITH (ORCPT ); Tue, 2 Aug 2011 04:19:07 -0400 Received: from mail-ey0-f171.google.com ([209.85.215.171]:64987 "EHLO mail-ey0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419Ab1HBITF (ORCPT ); Tue, 2 Aug 2011 04:19:05 -0400 Received: by eye22 with SMTP id 22so5063226eye.2 for ; Tue, 02 Aug 2011 01:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=pfulqKB0j6m0Op2o7untkEux0xJhdahQlQTgd8b/BbM=; b=rkmpHYxFf8yvt44FI0ZGqdhFwqDBTmEKNrmXFyL5hPas+ts9r6Nnuc0jFozFGGC9P7 guD06P5XFvpmyExakaJBTPQNLyEYLvyfHz0nbmLF37UB8hewq95mLF8mXZBwo4PQRwdb eeesiLFbmzXJDm7gUx+1g6UpnVwjt7FYAlRng= Received: by 10.213.20.83 with SMTP id e19mr99987ebb.120.1312273144185; Tue, 02 Aug 2011 01:19:04 -0700 (PDT) Received: from IPv4-netbook (vax.chrillesen.dk [193.88.12.35]) by mx.google.com with ESMTPS id h49sm2413374eeh.8.2011.08.02.01.19.00 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 02 Aug 2011 01:19:01 -0700 (PDT) Date: Tue, 2 Aug 2011 10:18:57 +0200 (CEST) From: BOUWSMA Barry X-X-Sender: beer@localhost.localdomain To: Doron Cohen cc: linux-media@vger.kernel.org Subject: Re: [PATCH] drivers: support new Siano tuner devices. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.01 (DEB 1184 2008-12-16) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 02 Aug 2011 08:19:20 +0000 (UTC) On k (kedd) 19.júl (július) 2011, 14:21, Doron Cohen wrote: > This is the first time I ever post changes to linux kernel, so excuse me > if I have errors in the process. > As Siano team member, I would like to update the drivers for Siano > devices with the latest and greatest fixes. Unfortunately there is a hug > gap between the current code in the kernel and the code Siano has which > is more advanced and supports newer devices. I will try to break down > the changes into small pieces so each of the changes will be clear and > isolated. > Here is the first change which is my "test balloon" and includes simple > changes which includes support in new devices pulished after the kernel > source maintenance has stopped. Thanks for your contribution, and I hope it sees usage. I have found that for many kernel revisions, I have had to have some variant of the following added code, for my Siano-based device to function automatically in DVB-T modus: Apologies if this problem has been addressed by your patchset. If there was a reason for removing this functionality, I have not been able to follow it over time. Another thing, as my device is capable of receiving DAB radio broadcasts and Siano has provided a library to make this possible under Linux, are there plans to update this library for the DAB+ standard that is now being used, with the Reed-Solomon error protection and up to HE-AACv2 audio encoding? (I am aware of the 960-sample-window incompatibility with many AAC software players.) barry bouwsma mails will be delayed due to infrequent internet access now on the road in croatia --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- 3.0.0-rc1-hacks/sms-cards.c.orig 2011-04-06 04:04:12.000000000 +0200 +++ 3.0.0-rc1-hacks/sms-cards.c 2011-07-09 10:17:30.000000000 +0200 @@ -301,6 +301,11 @@ case SMS1XXX_BOARD_HAUPPAUGE_TIGER_MINICARD_R2: request_module("smsdvb"); break; +/* XXX HACK */ + case SMS1XXX_BOARD_SIANO_STELLAR: + request_module("smsdvb"); + break; + default: /* do nothing */ break;