From patchwork Sun Feb 6 20:49:02 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 536151 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p16Kof9n025197 for ; Sun, 6 Feb 2011 20:50:41 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754001Ab1BFUuS (ORCPT ); Sun, 6 Feb 2011 15:50:18 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:22297 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753951Ab1BFUuS (ORCPT ); Sun, 6 Feb 2011 15:50:18 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 47EB79403D; Sun, 6 Feb 2011 21:49:02 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 462BE9403B; Sun, 6 Feb 2011 21:49:02 +0100 (CET) Date: Sun, 6 Feb 2011 21:49:02 +0100 (CET) From: Jesper Juhl To: linux-kernel@vger.kernel.org cc: Holger Waechtler , Felix Domke , linux-media@vger.kernel.org, Mauro Carvalho Chehab , Jean Delvare Subject: [PATCH] TTUSB DVB: ttusb_boot_dsp() needs to release_firmware() or it leaks memory. Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sun, 06 Feb 2011 20:50:41 +0000 (UTC) diff --git a/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c b/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c index 40625b2..cbe2f0d 100644 --- a/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c +++ b/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c @@ -334,6 +334,7 @@ static int ttusb_boot_dsp(struct ttusb *ttusb) err = ttusb_cmd(ttusb, b, 4, 0); done: + release_firmware(fw); if (err) { dprintk("%s: usb_bulk_msg() failed, return value %i!\n", __func__, err);