diff mbox

[MEDIA] add device ID to ati remote

Message ID cfb14339f809faa9b5e40d2fa53f330b.squirrel@helmutauer.de (mailing list archive)
State New, archived
Headers show

Commit Message

Helmut Auer Feb. 7, 2017, 8:42 a.m. UTC
Author: Helmut Auer <vdr@xxx.de>
Date:   Fri Jan 27 19:09:35 2017 +0100

    Adding 1 device ID to ati_remote driver.

    Signed-off-by: Helmut Auer <vdr@xxx.de>


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Sean Young Feb. 13, 2017, 1:42 p.m. UTC | #1
On Tue, Feb 07, 2017 at 09:42:47AM +0100, vdr@helmutauer.de wrote:
> 
> Author: Helmut Auer <vdr@xxx.de>
> Date:   Fri Jan 27 19:09:35 2017 +0100
> 
>     Adding 1 device ID to ati_remote driver.

If possible, a more descriptive message would be preferred, e.g. what
device do you have, what branding, what product did it come with.

> 
>     Signed-off-by: Helmut Auer <vdr@xxx.de>

Unless I'm mistaken, contributions can't be anonymous or use a fake email
address.

> 
> diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c
> index 0884b7d..83022b1 100644
> --- a/drivers/media/rc/ati_remote.c
> +++ b/drivers/media/rc/ati_remote.c
> @@ -108,6 +108,7 @@
>  #define NVIDIA_REMOTE_PRODUCT_ID       0x0005
>  #define MEDION_REMOTE_PRODUCT_ID       0x0006
>  #define FIREFLY_REMOTE_PRODUCT_ID      0x0008
> +#define REYCOM_REMOTE_PRODUCT_ID       0x000c
> 
>  #define DRIVER_VERSION         "2.2.1"
>  #define DRIVER_AUTHOR           "Torrey Hoffman <thoffman@arnor.net>"
> @@ -227,6 +228,10 @@ static struct usb_device_id ati_remote_table[] = {
>                 USB_DEVICE(ATI_REMOTE_VENDOR_ID, FIREFLY_REMOTE_PRODUCT_ID),
>                 .driver_info = (unsigned long)&type_firefly
>         },
> +       {
> +               USB_DEVICE(ATI_REMOTE_VENDOR_ID, REYCOM_REMOTE_PRODUCT_ID),
> +               .driver_info = (unsigned long)&type_firefly
> +       },
>         {}      /* Terminating entry */
>  };

Your email client replaced all tabs with spaces so the patch no longer
applies.

Thanks,
Sean
Helmut Auer Feb. 13, 2017, 10:57 p.m. UTC | #2
Hello

Thanks for the info, but sorry I'm not willinmg to do anything more to get the patch into the kernel.
I have an own distribution and I am applying those patches and thats easier than committing it to the kernel ;)
Maybe anyone who needs this finds this patch.

Kind regards
Helmut

Am 13.02.2017 um 14:42 schrieb Sean Young:
> On Tue, Feb 07, 2017 at 09:42:47AM +0100, vdr@helmutauer.de wrote:
>>
>> Author: Helmut Auer <vdr@xxx.de>
>> Date:   Fri Jan 27 19:09:35 2017 +0100
>>
>>      Adding 1 device ID to ati_remote driver.
>
> If possible, a more descriptive message would be preferred, e.g. what
> device do you have, what branding, what product did it come with.
>
>>
>>      Signed-off-by: Helmut Auer <vdr@xxx.de>
>
> Unless I'm mistaken, contributions can't be anonymous or use a fake email
> address.
>
>>
>> diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c
>> index 0884b7d..83022b1 100644
>> --- a/drivers/media/rc/ati_remote.c
>> +++ b/drivers/media/rc/ati_remote.c
>> @@ -108,6 +108,7 @@
>>   #define NVIDIA_REMOTE_PRODUCT_ID       0x0005
>>   #define MEDION_REMOTE_PRODUCT_ID       0x0006
>>   #define FIREFLY_REMOTE_PRODUCT_ID      0x0008
>> +#define REYCOM_REMOTE_PRODUCT_ID       0x000c
>>
>>   #define DRIVER_VERSION         "2.2.1"
>>   #define DRIVER_AUTHOR           "Torrey Hoffman <thoffman@arnor.net>"
>> @@ -227,6 +228,10 @@ static struct usb_device_id ati_remote_table[] = {
>>                  USB_DEVICE(ATI_REMOTE_VENDOR_ID, FIREFLY_REMOTE_PRODUCT_ID),
>>                  .driver_info = (unsigned long)&type_firefly
>>          },
>> +       {
>> +               USB_DEVICE(ATI_REMOTE_VENDOR_ID, REYCOM_REMOTE_PRODUCT_ID),
>> +               .driver_info = (unsigned long)&type_firefly
>> +       },
>>          {}      /* Terminating entry */
>>   };
>
> Your email client replaced all tabs with spaces so the patch no longer
> applies.
>
> Thanks,
> Sean
>
Helmut Auer Feb. 14, 2017, 7:11 a.m. UTC | #3
P.S. Here is the patch again with a correction.

> On Tue, Feb 07, 2017 at 09:42:47AM +0100, vdr@helmutauer.de wrote:
>>
>> Author: Helmut Auer <vdr@xxx.de>
>> Date:   Fri Jan 27 19:09:35 2017 +0100
>>
>>     Adding 1 device ID to ati_remote driver.
>
> If possible, a more descriptive message would be preferred, e.g. what
> device do you have, what branding, what product did it come with.
>
>>
>>     Signed-off-by: Helmut Auer <vdr@xxx.de>
>
> Unless I'm mistaken, contributions can't be anonymous or use a fake email
> address.
>
>>
>> diff --git a/drivers/media/rc/ati_remote.c
>> b/drivers/media/rc/ati_remote.c
>> index 0884b7d..83022b1 100644
>> --- a/drivers/media/rc/ati_remote.c
>> +++ b/drivers/media/rc/ati_remote.c
>> @@ -108,6 +108,7 @@
>>  #define NVIDIA_REMOTE_PRODUCT_ID       0x0005
>>  #define MEDION_REMOTE_PRODUCT_ID       0x0006
>>  #define FIREFLY_REMOTE_PRODUCT_ID      0x0008
>> +#define REYCOM_REMOTE_PRODUCT_ID       0x000c
>>
>>  #define DRIVER_VERSION         "2.2.1"
>>  #define DRIVER_AUTHOR           "Torrey Hoffman <thoffman@arnor.net>"
>> @@ -227,6 +228,10 @@ static struct usb_device_id ati_remote_table[] = {
>>                 USB_DEVICE(ATI_REMOTE_VENDOR_ID,
>> FIREFLY_REMOTE_PRODUCT_ID),
>>                 .driver_info = (unsigned long)&type_firefly
>>         },
>> +       {
>> +               USB_DEVICE(ATI_REMOTE_VENDOR_ID,
>> REYCOM_REMOTE_PRODUCT_ID),
>> +               .driver_info = (unsigned long)&type_firefly
>> +       },
>>         {}      /* Terminating entry */
>>  };
>
> Your email client replaced all tabs with spaces so the patch no longer
> applies.
>
> Thanks,
> Sean
>
diff mbox

Patch

diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c
index 0884b7d..83022b1 100644
--- a/drivers/media/rc/ati_remote.c
+++ b/drivers/media/rc/ati_remote.c
@@ -108,6 +108,7 @@ 
 #define NVIDIA_REMOTE_PRODUCT_ID       0x0005
 #define MEDION_REMOTE_PRODUCT_ID       0x0006
 #define FIREFLY_REMOTE_PRODUCT_ID      0x0008
+#define REYCOM_REMOTE_PRODUCT_ID       0x000c

 #define DRIVER_VERSION         "2.2.1"
 #define DRIVER_AUTHOR           "Torrey Hoffman <thoffman@arnor.net>"
@@ -227,6 +228,10 @@  static struct usb_device_id ati_remote_table[] = {
                USB_DEVICE(ATI_REMOTE_VENDOR_ID, FIREFLY_REMOTE_PRODUCT_ID),
                .driver_info = (unsigned long)&type_firefly
        },
+       {
+               USB_DEVICE(ATI_REMOTE_VENDOR_ID, REYCOM_REMOTE_PRODUCT_ID),
+               .driver_info = (unsigned long)&type_firefly
+       },
        {}      /* Terminating entry */
 };