| Message ID | e39e656c49c05829f0cf9affd7918818351d09e6.1585059896.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Reorganize media Kconfig | expand |
On Tue, 24 Mar 2020 at 11:26, Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > > When the platform drivers got added, they were all part of > complex camera support. This is not the case anymore, as we > now have codecs and other stuff there too. > > So, fix the dependencies, in order to not require users to > manually select something that it doesn't make sense. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > drivers/media/Kconfig | 3 +-- > drivers/media/platform/Kconfig | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig > index 9dfea5c4b6ab..4af21fa73fcf 100644 > --- a/drivers/media/Kconfig > +++ b/drivers/media/Kconfig > @@ -99,8 +99,7 @@ source "drivers/media/mc/Kconfig" > config VIDEO_DEV > tristate > depends on MEDIA_SUPPORT > - depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT > - default y > + default MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT || V4L_PLATFORM_DRIVERS > This is missing V4L_MEM2MEM_DRIVERS. Without, some mem-to-mem drivers will be hidden. Thanks, Ezequiel
A few more comments... On Tue, 24 Mar 2020 at 11:26, Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > > When the platform drivers got added, they were all part of > complex camera support. This is not the case anymore, as we > now have codecs and other stuff there too. > > So, fix the dependencies, in order to not require users to > manually select something that it doesn't make sense. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > drivers/media/Kconfig | 3 +-- > drivers/media/platform/Kconfig | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > [..] > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index e01bbb9dd1c1..34f40c2c8c45 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -5,7 +5,6 @@ > > menuconfig V4L_PLATFORM_DRIVERS > bool "V4L platform devices" It would be more consistent to have "V4L platform drivers". Same applies on other _DRIVER menus with "devices" descriptions. > - depends on MEDIA_CAMERA_SUPPORT Also, this same change is needed on V4L_MEM2MEM_DRIVERS. Thanks, Ezequiel
diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index 9dfea5c4b6ab..4af21fa73fcf 100644 --- a/drivers/media/Kconfig +++ b/drivers/media/Kconfig @@ -99,8 +99,7 @@ source "drivers/media/mc/Kconfig" config VIDEO_DEV tristate depends on MEDIA_SUPPORT - depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT - default y + default MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT || V4L_PLATFORM_DRIVERS config VIDEO_V4L2_SUBDEV_API bool "V4L2 sub-device userspace API" diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index e01bbb9dd1c1..34f40c2c8c45 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -5,7 +5,6 @@ menuconfig V4L_PLATFORM_DRIVERS bool "V4L platform devices" - depends on MEDIA_CAMERA_SUPPORT help Say Y here to enable support for platform-specific V4L drivers.
When the platform drivers got added, they were all part of complex camera support. This is not the case anymore, as we now have codecs and other stuff there too. So, fix the dependencies, in order to not require users to manually select something that it doesn't make sense. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- drivers/media/Kconfig | 3 +-- drivers/media/platform/Kconfig | 1 - 2 files changed, 1 insertion(+), 3 deletions(-)