From patchwork Mon Jul 25 14:30:37 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Palash Bandyopadhyay X-Patchwork-Id: 1004752 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6PEUldW010310 for ; Mon, 25 Jul 2011 14:30:47 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751849Ab1GYOap (ORCPT ); Mon, 25 Jul 2011 10:30:45 -0400 Received: from hera.kernel.org ([140.211.167.34]:36950 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727Ab1GYOao convert rfc822-to-8bit (ORCPT ); Mon, 25 Jul 2011 10:30:44 -0400 Received: from cnxtsmtp2.conexant.com (cnxt09253.conexant.com [198.62.9.253]) by hera.kernel.org (8.14.4/8.14.3) with ESMTP id p6PEUgD5028070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Mon, 25 Jul 2011 14:30:43 GMT X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.97 at hera.kernel.org X-M-MSG: X-WSS-ID: 0LOW8B3-03-2B0-03 Received: from nbwsmx2.bbnet.ad (nbwsmx2.bbnet.ad [157.152.183.212]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by cnxtsmtp2.conexant.com (Axway MailGate 3.8.1) with ESMTP id 29AA423B6B4 for ; Mon, 25 Jul 2011 07:30:38 -0700 (PDT) Received: from NBWSMX2.bbnet.ad ([127.0.0.1]) by nbwsmx2.bbnet.ad with Microsoft SMTPSVC(6.0.3790.4675); Mon, 25 Jul 2011 07:30:39 -0700 Received: from cnxthub1.bbnet.ad ([157.152.180.131]) by NBWSMX2.bbnet.ad over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 25 Jul 2011 07:30:39 -0700 Received: from NBMBX01.bbnet.ad ([fe80:0000:0000:0000:49cc:d6ea:184.37.222.21]) by cnxthub1.bbnet.ad ([157.152.180.131]) with mapi; Mon, 25 Jul 2011 07:30:38 -0700 From: "Palash Bandyopadhyay" To: "Mauro Carvalho Chehab" , "Devin Heitmueller" cc: "Linux Media Mailing List" , "Gerd Hoffmann" , "Sri Deevi" Date: Mon, 25 Jul 2011 07:30:37 -0700 Subject: RE: [PATCH] Fix regression introduced which broke the Hauppauge USBLive 2 Thread-Topic: [PATCH] Fix regression introduced which broke the Hauppauge USBLive 2 Thread-Index: AcxKyoJOF5FP4dhyQPu7gHcCeitD+wACycY5 Message-ID: References: <4E2C16B5.5010703@redhat.com> <73512a61-63b5-4e42-bbda-26e33ec8ec35@cnxthub2.bbnet.ad> , <4E2D685E.6090209@redhat.com> In-Reply-To: <4E2D685E.6090209@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-OriginalArrivalTime: 25 Jul 2011 14:30:39.0709 (UTC) FILETIME=[6D2E80D0:01CC4AD7] X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on hera.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 25 Jul 2011 14:30:47 +0000 (UTC) X-Greylist: Delayed for 08:37:34 by milter-greylist-4.2.3 (hera.kernel.org [140.211.167.34]); Mon, 25 Jul 2011 14:30:44 +0000 (UTC) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Mauro and Devin, Thanks for the explainations. The fix proposed is ok and as Devin mentioned, should have very low impact. I'll see if I can dig into the issue to root cause it. Thanks for your help. Rgds, Palash Signed off by Palash Bandyopadhyay diff --git a/drivers/media/video/cx231xx/cx231xx-avcore.c b/drivers/media/video/cx231xx/cx231xx-avcore.c index cf50faf..cf412cd 100644 --- a/drivers/media/video/cx231xx/cx231xx-avcore.c +++ b/drivers/media/video/cx231xx/cx231xx-avcore.c @@ -2412,7 +2412,7 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) break; } - msleep(PWR_SLEEP_INTERVAL); + msleep(PWR_SLEEP_INTERVAL * 10); /* For power saving, only enable Pwr_resetout_n when digital TV is selected. */