Message ID | e97de1cfd545c5861634619112770cf0710a6241.1637781097.git.mchehab+huawei@kernel.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Solve the remaining issues with clang and W=1 on media | expand |
On Wed, Nov 24, 2021 at 08:13:04PM +0100, Mauro Carvalho Chehab wrote: > Those functions just call a V4L2 core macro, and aren't used > anywhere. Get rid of them, in order to avoid clang warnings with > W=1. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH 00/20] at: https://lore.kernel.org/all/cover.1637781097.git.mchehab+huawei@kernel.org/ > > drivers/media/i2c/adv7842.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c > index 7f8acbdf0db4..9d6eed0f8281 100644 > --- a/drivers/media/i2c/adv7842.c > +++ b/drivers/media/i2c/adv7842.c > @@ -256,21 +256,11 @@ static inline struct v4l2_subdev *to_sd(struct v4l2_ctrl *ctrl) > return &container_of(ctrl->handler, struct adv7842_state, hdl)->sd; > } > > -static inline unsigned hblanking(const struct v4l2_bt_timings *t) > -{ > - return V4L2_DV_BT_BLANKING_WIDTH(t); > -} > - > static inline unsigned htotal(const struct v4l2_bt_timings *t) > { > return V4L2_DV_BT_FRAME_WIDTH(t); > } > > -static inline unsigned vblanking(const struct v4l2_bt_timings *t) > -{ > - return V4L2_DV_BT_BLANKING_HEIGHT(t); > -} > - > static inline unsigned vtotal(const struct v4l2_bt_timings *t) > { > return V4L2_DV_BT_FRAME_HEIGHT(t); > -- > 2.33.1 > >
diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c index 7f8acbdf0db4..9d6eed0f8281 100644 --- a/drivers/media/i2c/adv7842.c +++ b/drivers/media/i2c/adv7842.c @@ -256,21 +256,11 @@ static inline struct v4l2_subdev *to_sd(struct v4l2_ctrl *ctrl) return &container_of(ctrl->handler, struct adv7842_state, hdl)->sd; } -static inline unsigned hblanking(const struct v4l2_bt_timings *t) -{ - return V4L2_DV_BT_BLANKING_WIDTH(t); -} - static inline unsigned htotal(const struct v4l2_bt_timings *t) { return V4L2_DV_BT_FRAME_WIDTH(t); } -static inline unsigned vblanking(const struct v4l2_bt_timings *t) -{ - return V4L2_DV_BT_BLANKING_HEIGHT(t); -} - static inline unsigned vtotal(const struct v4l2_bt_timings *t) { return V4L2_DV_BT_FRAME_HEIGHT(t);
Those functions just call a V4L2 core macro, and aren't used anywhere. Get rid of them, in order to avoid clang warnings with W=1. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/20] at: https://lore.kernel.org/all/cover.1637781097.git.mchehab+huawei@kernel.org/ drivers/media/i2c/adv7842.c | 10 ---------- 1 file changed, 10 deletions(-)