| Message ID | f11b1d6b-5800-4d75-9732-506be3f8458d@moroto.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: qcom: camss: clean up a check | expand |
On 12/10/2023 10:42, Dan Carpenter wrote: > Imagine that "->vfe_num" is zero, then the subtraction will underflow to > UINT_MAX. Plus it's just cleaner to use >= instead. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/media/platform/qcom/camss/camss-ispif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c > index be9d2f0a10c1..ddfe94377ee5 100644 > --- a/drivers/media/platform/qcom/camss/camss-ispif.c > +++ b/drivers/media/platform/qcom/camss/camss-ispif.c > @@ -270,7 +270,7 @@ static int ispif_vfe_reset(struct ispif_device *ispif, u8 vfe_id) > unsigned long time; > u32 val; > > - if (vfe_id > camss->res->vfe_num - 1) { > + if (vfe_id >= camss->res->vfe_num) { > dev_err(camss->dev, > "Error: asked reset for invalid VFE%d\n", vfe_id); > return -ENOENT; Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On 12/10/2023 10:42, Dan Carpenter wrote: > Imagine that "->vfe_num" is zero, then the subtraction will underflow to > UINT_MAX. Plus it's just cleaner to use >= instead. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/media/platform/qcom/camss/camss-ispif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c > index be9d2f0a10c1..ddfe94377ee5 100644 > --- a/drivers/media/platform/qcom/camss/camss-ispif.c > +++ b/drivers/media/platform/qcom/camss/camss-ispif.c > @@ -270,7 +270,7 @@ static int ispif_vfe_reset(struct ispif_device *ispif, u8 vfe_id) > unsigned long time; > u32 val; > > - if (vfe_id > camss->res->vfe_num - 1) { > + if (vfe_id >= camss->res->vfe_num) { > dev_err(camss->dev, > "Error: asked reset for invalid VFE%d\n", vfe_id); > return -ENOENT; From my @linaro.org address Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On 10/12/23 11:42, Dan Carpenter wrote: > Imagine that "->vfe_num" is zero, then the subtraction will underflow to > UINT_MAX. Plus it's just cleaner to use >= instead. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c index be9d2f0a10c1..ddfe94377ee5 100644 --- a/drivers/media/platform/qcom/camss/camss-ispif.c +++ b/drivers/media/platform/qcom/camss/camss-ispif.c @@ -270,7 +270,7 @@ static int ispif_vfe_reset(struct ispif_device *ispif, u8 vfe_id) unsigned long time; u32 val; - if (vfe_id > camss->res->vfe_num - 1) { + if (vfe_id >= camss->res->vfe_num) { dev_err(camss->dev, "Error: asked reset for invalid VFE%d\n", vfe_id); return -ENOENT;
Imagine that "->vfe_num" is zero, then the subtraction will underflow to UINT_MAX. Plus it's just cleaner to use >= instead. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/media/platform/qcom/camss/camss-ispif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)