[v3,0/4] add i2c support for mt8192

Message

Qii Wang (王琪) Aug. 5, 2020, 10:52 a.m. UTC

This series are based on 5.8-rc1 and we provide four i2c patches
to support mt8192 SoC.

Main changes compared to v2:
--delete unused I2C_DMA_4G_MODE

Main changes compared to v1:
--modify the commit with access more than 8GB dram
--add Reviewed-by and Acked-by from Yingjoe, Matthias and Rob

Qii Wang (4):
  i2c: mediatek: Add apdma sync in i2c driver
  i2c: mediatek: Add access to more than 8GB dram in i2c driver
  dt-bindings: i2c: update bindings for MT8192 SoC
  i2c: mediatek: Add i2c compatible for MediaTek MT8192

 .../devicetree/bindings/i2c/i2c-mt65xx.txt         |  1 +
 drivers/i2c/busses/i2c-mt65xx.c                    | 77 +++++++++++++++-------
 2 files changed, 53 insertions(+), 25 deletions(-)

Comments

Wolfram Sang Aug. 5, 2020, 9:42 p.m. UTC | #1

On Wed, Aug 05, 2020 at 06:52:18PM +0800, Qii Wang wrote:
> This series are based on 5.8-rc1 and we provide four i2c patches
> to support mt8192 SoC.
> 
> Main changes compared to v2:
> --delete unused I2C_DMA_4G_MODE
> 
> Main changes compared to v1:
> --modify the commit with access more than 8GB dram
> --add Reviewed-by and Acked-by from Yingjoe, Matthias and Rob
> 
> Qii Wang (4):
>   i2c: mediatek: Add apdma sync in i2c driver
>   i2c: mediatek: Add access to more than 8GB dram in i2c driver
>   dt-bindings: i2c: update bindings for MT8192 SoC
>   i2c: mediatek: Add i2c compatible for MediaTek MT8192
> 
>  .../devicetree/bindings/i2c/i2c-mt65xx.txt         |  1 +

Applied to for-next, thanks!

Sidenote: I get these warnings when compiling the driver:

drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_low_ns' not described in 'i2c_spec_values'
drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_high_ns' not described in 'i2c_spec_values'
drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_su_sta_ns' not described in 'i2c_spec_values'
drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'max_hd_dat_ns' not described in 'i2c_spec_values'
drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_su_dat_ns' not described in 'i2c_spec_values'

Is someone interested to fix these?

Matthias Brugger Aug. 6, 2020, 6:30 a.m. UTC | #2

On 05/08/2020 23:42, [e-mail] wrote:
> On Wed, Aug 05, 2020 at 06:52:18PM +0800, Qii Wang wrote:
>> This series are based on 5.8-rc1 and we provide four i2c patches
>> to support mt8192 SoC.
>>
>> Main changes compared to v2:
>> --delete unused I2C_DMA_4G_MODE
>>
>> Main changes compared to v1:
>> --modify the commit with access more than 8GB dram
>> --add Reviewed-by and Acked-by from Yingjoe, Matthias and Rob
>>
>> Qii Wang (4):
>>    i2c: mediatek: Add apdma sync in i2c driver
>>    i2c: mediatek: Add access to more than 8GB dram in i2c driver
>>    dt-bindings: i2c: update bindings for MT8192 SoC
>>    i2c: mediatek: Add i2c compatible for MediaTek MT8192
>>
>>   .../devicetree/bindings/i2c/i2c-mt65xx.txt         |  1 +
> 
> Applied to for-next, thanks!
> 
> Sidenote: I get these warnings when compiling the driver:
> 
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_low_ns' not described in 'i2c_spec_values'
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_high_ns' not described in 'i2c_spec_values'
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_su_sta_ns' not described in 'i2c_spec_values'
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'max_hd_dat_ns' not described in 'i2c_spec_values'
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_su_dat_ns' not described in 'i2c_spec_values'
> 
> Is someone interested to fix these?
> 

I just send a fix for that.

Regards,
Matthias