From patchwork Thu Aug 15 07:16:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pi-Hsun Shih X-Patchwork-Id: 11095113 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F3B1F1823 for ; Thu, 15 Aug 2019 07:16:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC1DD28879 for ; Thu, 15 Aug 2019 07:16:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D03952887E; Thu, 15 Aug 2019 07:16:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5C14E28879 for ; Thu, 15 Aug 2019 07:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=TvvZckCH19UiLOscbEUlr3SX49dty3F08kxJ4ni5JpQ=; b=OidRLEY+CZ0Mhn OWcpY52IkbJiD+rV4JTyBq4MkMJn1ZZ7KHC/OuttOz7n/124vTyM9WgSZAypKh+GLthLhiOoeFrqw 8RkZsqJtK4QCim2riTGjACTLeS4U9e0jwQn3ciOTmiyuh865PP/wL+d2/Bk1cPO1U2pyZxcvkVRY7 Dzxy1eMYPrfyRWlEEyiD07Kof+WT58Su5JBYVE/Wpx3Sx+5OE53vimrHVBf0glsdUYMBQB5gRTXTs GcdzAoipjHrMXadFSmfwdJ8ZQBJuyz2i1IdUnq4crQPkO8syl4RWuEk4rS7FIcRqtB7DzWUOtfHsW HjyizXdCBT5grxypyT0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyA06-0004ga-OU; Thu, 15 Aug 2019 07:16:46 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hyA02-0004ex-IR for linux-mediatek@lists.infradead.org; Thu, 15 Aug 2019 07:16:45 +0000 Received: by mail-pf1-x444.google.com with SMTP id i30so924699pfk.9 for ; Thu, 15 Aug 2019 00:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=s5f8KXoDAyC3GiScQEWx3+hem8uLIFg9V9KZILhkXgo=; b=GFfaGEIODCSVdkKe7WEXKBQbRwDMHVEO4VbVgXsMEL9Ru50ISVc2oAWtyWx5wyGi7H GJr/+HATsNCT6SY53BDaEzkiwEPnVSMURjTYqZgcpR5fnJ4pt2g95uqucT0mmUjsjL6y ivNboEsYJmza8IS79PEt6ENyAJ8qUrz4783s8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=s5f8KXoDAyC3GiScQEWx3+hem8uLIFg9V9KZILhkXgo=; b=tcsuHfnSqU4Hu/P8c6UiQQX8YELiNeOwgeTTNuNncLtBrd9KmwOVclgaOlOg9WLy5V qUpk33PYkRT5SUccChqtUKAZZUYuSl4pvPFX/r+6gNkuA/tYxBcYV/0VqT/+f4ou2h+y q66t/A3FHTuIYW6myoCJ+Bc5zQww4fUU9TVJ6soTYA+dTlCu0K4NFzvgL46NY6EOL3F4 N7MBre3+K9dysQisWB3RMJ9DxXnDaXGr7w8k3gKNe68T9Cyje1RPT4PZ1B4Acu4/GwOh 9s6aWmQa+XcVHhDYHLJInVqfXM/50I1SvUFNYumNWrNJe6PYKf7DpqypJwPUQESIt/5M gLCQ== X-Gm-Message-State: APjAAAV8XvkWemXulwfcmDBuEv2MAKG+/OvDzeD6qEOQjm5bV76LqmR4 qMNU5NwpB2PVz85Ym7Q/g9NFNvJeJz8= X-Google-Smtp-Source: APXvYqwy9le1UizWA3SSSD7ratSCaYjvvJydzJy93Cxi+fw1djduxV0s35o8JfSUj7Z2PaWLhjl69w== X-Received: by 2002:a17:90a:e392:: with SMTP id b18mr969478pjz.140.1565853401279; Thu, 15 Aug 2019 00:16:41 -0700 (PDT) Received: from pihsun-z840.tpe.corp.google.com ([2401:fa00:1:10:7889:7a43:f899:134c]) by smtp.googlemail.com with ESMTPSA id v6sm1768727pff.78.2019.08.15.00.16.39 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 15 Aug 2019 00:16:40 -0700 (PDT) From: Pi-Hsun Shih To: Subject: [PATCH v16 0/5] Add support for mt8183 SCP. Date: Thu, 15 Aug 2019 15:16:24 +0800 Message-Id: <20190815071635.168671-1-pihsun@chromium.org> X-Mailer: git-send-email 2.23.0.rc1.153.gdeed80330f-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190815_001642_634937_BE0BE815 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:REMOTE PROCESSOR REMOTEPROC SUBSYSTEM" , open list , "moderated list:ARM/Mediatek SoC support" , Pi-Hsun Shih , "moderated list:ARM/Mediatek SoC support" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Add support for controlling and communicating with mt8183's system control processor (SCP), using the remoteproc & rpmsg framework. And also add a cros_ec driver for CrOS EC host command over rpmsg. The overall structure of the series is: * remoteproc/mtk_scp.c: Control the start / stop of SCP (Patch 2, 3). * remoteproc/mtk_scp_ipi.c: Communicates to SCP using inter-processor interrupt (IPI) and shared memory (Patch 2, 3). * rpmsg/mtk_rpmsg.c: Wrapper to wrap the IPI communication into a rpmsg device. Supports name service for SCP firmware to announce channels (Patch 4). * add scp dts node to mt8183 platform (Patch 5). Changes from v15: - Fix a bug on incorrect usage of wait_event_timeout return value. Changes from v14: - Fix a typo on variable in DEBUG section. Changes from v13: - Move include/linux/platform_data/mtk_scp.h to include/linux/remoteproc/mtk_scp.h. - Rename scp_get_reserve_* to scp_get_reserved_*. - Add lock for access of scp->ipi_desc. - Lock the whole ipi_send function. - Move more setting of cache size from SCP firmware to kernel driver, to prevent problem while loading firmware onto DRAM. - Minor fixes addressing comment. Changes from v12: - Initialize cache before firmware load, to avoid problem while loading large firmware. - Disable watchdog before stopping SCP, to avoid extra warning message. - Fix new warnings by checkpatch. Changes from v11: - Fixed a bug that mtk_rpmsg_endpoint is not properly cleaned up if rproc_boot fails. - Add missing documentation in comment. Changes from v10: - Drop applied cros_ec_rpmsg patches. - Add clock reset before loading SCP firmware. - Fix some type mismatch warnings when printing debug messages. Changes from v9: - Remove reserve-memory-vpu_share node. - Remove change to cros_ec_commands.h (That is already in https://lore.kernel.org/lkml/20190518063949.GY4319@dell/T/) Changes from v8: - Rebased onto https://patchwork.kernel.org/cover/10962385/. - Drop merged cros_ec_rpmsg patch, and add scp dts node patch. - Add more reserved memory region. Changes from v7: - Rebase onto https://lore.kernel.org/patchwork/patch/1059196/. - Fix clock enable/disable timing for SCP driver. - Add more SCP IPI ID. Changes from v6: - Decouple mtk_rpmsg from mtk_scp. - Change data of EC response to be aligned to 4 bytes. Changes from v5: - Add device tree binding document for cros_ec_rpmsg. - Better document in comments for cros_ec_rpmsg. - Remove dependency on CONFIG_ in binding tree document. Changes from v4: - Merge patch 6 (Load ELF firmware) into patch 2, so the driver loads ELF firmware by default, and no longer accept plain binary. - rpmsg_device listed in device tree (as a child of the SCP node) would have it's device tree node mapped to the rpmsg_device, so the rpmsg driver can use the properties on device tree. Changes from v3: - Make writing to SCP SRAM aligned. - Add a new patch (Patch 6) to load ELF instead of bin firmware. - Add host event support for EC driver. - Fix some bugs found in testing (missing spin_lock_init, rproc_subdev_unprepare to rproc_subdev_stop). - Fix some coding style issue found by checkpatch.pl. Changes from v2: - Fold patch 3 into patch 2 in v2. - Move IPI id around to support cross-testing for old and new firmware. - Finish more TODO items. Changes from v1: - Extract functions and rename variables in mtk_scp.c. - Do cleanup properly in mtk_rpmsg.c, which also removes the problem of short-lived work items. - Code format fix based on feedback for cros_ec_rpmsg.c. - Extract feature detection for SCP into separate patch (Patch 6). Eddie Huang (1): arm64: dts: mt8183: add scp node Erin Lo (3): dt-bindings: Add a binding for Mediatek SCP remoteproc/mediatek: add SCP support for mt8183 remoteproc: mt8183: add reserved memory manager API Pi-Hsun Shih (1): rpmsg: add rpmsg support for mt8183 SCP. .../bindings/remoteproc/mtk,scp.txt | 36 + arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 11 + arch/arm64/boot/dts/mediatek/mt8183.dtsi | 12 + drivers/remoteproc/Kconfig | 10 + drivers/remoteproc/Makefile | 1 + drivers/remoteproc/mtk_common.h | 92 +++ drivers/remoteproc/mtk_scp.c | 710 ++++++++++++++++++ drivers/remoteproc/mtk_scp_ipi.c | 161 ++++ drivers/rpmsg/Kconfig | 9 + drivers/rpmsg/Makefile | 1 + drivers/rpmsg/mtk_rpmsg.c | 414 ++++++++++ include/linux/remoteproc/mtk_scp.h | 168 +++++ include/linux/rpmsg/mtk_rpmsg.h | 38 + 13 files changed, 1663 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt create mode 100644 drivers/remoteproc/mtk_common.h create mode 100644 drivers/remoteproc/mtk_scp.c create mode 100644 drivers/remoteproc/mtk_scp_ipi.c create mode 100644 drivers/rpmsg/mtk_rpmsg.c create mode 100644 include/linux/remoteproc/mtk_scp.h create mode 100644 include/linux/rpmsg/mtk_rpmsg.h