mbox series

[v3,0/2] tracing: make tracer_init_tracefs initcall asynchronous

Message ID 20220323152257.7871-1-mark-pk.tsai@mediatek.com (mailing list archive)
Headers show
Series tracing: make tracer_init_tracefs initcall asynchronous | expand

Message

Mark-PK Tsai (蔡沛剛) March 23, 2022, 3:22 p.m. UTC
Move trace_eval_init() to subsys_initcall to make it start
earlier.
And to avoid tracer_init_tracefs being blocked by
trace_event_sem which trace_eval_init() hold [1],
queue tracer_init_tracefs() to eval_map_wq to let
the two works being executed sequentially.

It can speed up the initialization of kernel as result
of making tracer_init_tracefs asynchronous.

On my arm64 platform, it reduce ~20ms of 125ms which total
time do_initcalls spend.

Mark-PK Tsai (2):
  tracing: Avoid adding tracer option before update_tracer_options
  tracing: make tracer_init_tracefs initcall asynchronous

 kernel/trace/trace.c | 38 ++++++++++++++++++++++++++++----------
 1 file changed, 28 insertions(+), 10 deletions(-)

Comments

Mark-PK Tsai (蔡沛剛) April 22, 2022, 9:27 a.m. UTC | #1
Hi Steve,

Could you please help to review this patch?
Sorry to disturb you, I just want to make sure it has not been
forgotten.

> Move trace_eval_init() to subsys_initcall to make it start
> earlier.
> And to avoid tracer_init_tracefs being blocked by
> trace_event_sem which trace_eval_init() hold [1],
> queue tracer_init_tracefs() to eval_map_wq to let
> the two works being executed sequentially.
> 
> It can speed up the initialization of kernel as result
> of making tracer_init_tracefs asynchronous.
> 
> On my arm64 platform, it reduce ~20ms of 125ms which total
> time do_initcalls spend.
> 
> Mark-PK Tsai (2):
>   tracing: Avoid adding tracer option before update_tracer_options
>   tracing: make tracer_init_tracefs initcall asynchronous
> 
>  kernel/trace/trace.c | 38 ++++++++++++++++++++++++++++----------
>  1 file changed, 28 insertions(+), 10 deletions(-)
> 
> -- 
> 2.18.0
Steven Rostedt April 22, 2022, 3:41 p.m. UTC | #2
On Fri, 22 Apr 2022 17:27:51 +0800
Mark-PK Tsai <mark-pk.tsai@mediatek.com> wrote:

> Could you please help to review this patch?
> Sorry to disturb you, I just want to make sure it has not been
> forgotten.

No problem. Sorry for not getting to it, but my queue is rather deep :-p

Hopefully I can get to it by next week. Feel free to remind me again in a
week in case you do not hear back from me. But it is in my local patchwork,
but so is a lot of other patches I need to review :-/

-- Steve