mbox series

[RESEND,v3,0/3] regulator: mt6358: Remove bogus regulators and improvements

Message ID 20230926043450.2353320-1-wenst@chromium.org (mailing list archive)
Headers show
Series regulator: mt6358: Remove bogus regulators and improvements | expand

Message

Chen-Yu Tsai Sept. 26, 2023, 4:34 a.m. UTC 
Hi,

This seems to have fallen through the cracks, so I'm resending with tags
collected and patches rebased onto next-20230925. The diffs remain the
same.

This is v3 of the remainder of the MT6358 regulator driver cleanup
and improvement series. v1 can be found here [1]; v2 is here [2].

Changes since v2:
- Merged patches dropped
- Fixed up pickable linear ranges' selector values
- Collected tags
- Patch adding missing regulator definitions squashed into patch using
  the definitions; recommended by Krzysztof on my MT6366 series.
- Remaining dts patch split out to be sent separately

Changes since v1:
- Merged patches dropped
- Added patch to move VCN33 regulator status sync after ID check
- Added patch to fix VCN33 sync fail error message
- Added patch to add missing register definitions

Various discrepancies were found while preparing to upstream MT8186
device trees, which utilize the MT6366 PMIC, that is also covered by
this driver.

This v3 series can be seen as two parts. v1 had three parts, but one
part was fully merged, and then v2 gained another cleanup. v3 drops
the "fixing bogus regulators" part: driver changes are fully merged
and device tree change has been sent separately [3]. All patches here
should go through the regulator tree.

Part 1 - Robust chip ID checking (patch 1)

Angelo suggested making the driver fail to probe if an unexpected chip
ID was found. Patch 1 implements this.

Part 2 - Output voltage fine tuning support (patches 2, 3)

Many of the LDOs on these PMIC support an extra level of output voltage
fine tuning. Most default to no offset, but a couple have a non-zero
offset by default. Previously this was unaccounted for in the driver and
device tree constraints. On the outputs with non-zero offset, this ends
up becoming a discrepancy between the device tree and actual hardware.
These two patches adds support for this second level of tuning, modeled
as bunch of linear ranges. While it's unlikely we need this level of
control, it's nice to be able to read back the accurate hardware
settings.

The series has been reviewed, and the mfd header change has been acked
by Lee. Please merge.

Thanks
ChenYu

[1] https://lore.kernel.org/linux-arm-kernel/20230609083009.2822259-1-wenst@chromium.org/
[2] https://lore.kernel.org/linux-mediatek/20230721082903.2038975-1-wenst@chromium.org/
[3] https://lore.kernel.org/linux-mediatek/20230913084457.1638690-1-wenst@chromium.org/

Chen-Yu Tsai (3):
  regulator: mt6358: Fail probe on unknown chip ID
  regulator: mt6358: Add output voltage fine tuning to fixed regulators
  regulator: mt6358: Add output voltage fine tuning to variable LDOs

 drivers/regulator/mt6358-regulator.c | 304 ++++++++++++---------------
 include/linux/mfd/mt6358/registers.h |   6 +
 2 files changed, 144 insertions(+), 166 deletions(-)

Comments

Mark Brown Sept. 26, 2023, 8:05 a.m. UTC | #1 
On Tue, Sep 26, 2023 at 12:34:45PM +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> This seems to have fallen through the cracks, so I'm resending with tags
> collected and patches rebased onto next-20230925. The diffs remain the
> same.

AFAICT this is still in CI.