[0/2] media: i2c: Add support for GC05A2 sensor

Message

Zhi Mao (毛智) March 13, 2024, 5:44 a.m. UTC

This series adds YAML DT binding and V4L2 sub-device driver for Galaxycore's
GC05A2 5-megapixel 10-bit RAW CMOS 1/5" sensor, with an MIPI CSI-2 image data
interface and the I2C control bus.

The driver is implemented with V4L2 framework.
 - Async registered as a V4L2 sub-device.
 - As the first component of camera system including Seninf, ISP pipeline.
 - A media entity that provides one source pad in common.
 - Used in camera features on ChromeOS application.

Also this driver supports following features:
 - manual exposure and analog gain control support
 - vertical blanking control support
 - test pattern support
 - media controller support
 - runtime PM support
 - support resolution: 2592x1944@30fps, 1280x720@60fps

This series is based on linux-next, tag: next-20240312
 
Thanks 

Zhi Mao (2):
  media: dt-bindings: i2c: add GalaxyCore GC05A2 image sensor
  media: i2c: Add GC05A2 image sensor driver

 .../bindings/media/i2c/galaxycore,gc05a2.yaml |  112 ++
 drivers/media/i2c/Kconfig                     |   10 +
 drivers/media/i2c/Makefile                    |    1 +
 drivers/media/i2c/gc05a2.c                    | 1377 +++++++++++++++++
 4 files changed, 1500 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/galaxycore,gc05a2.yaml
 create mode 100644 drivers/media/i2c/gc05a2.c

Comments

Andy Shevchenko March 13, 2024, 8:52 a.m. UTC | #1

On Wed, Mar 13, 2024 at 7:54 AM Zhi Mao <[e-mail]> wrote:
>
> This series adds YAML DT binding and V4L2 sub-device driver for Galaxycore's
> GC05A2 5-megapixel 10-bit RAW CMOS 1/5" sensor, with an MIPI CSI-2 image data
> interface and the I2C control bus.
>
> The driver is implemented with V4L2 framework.
>  - Async registered as a V4L2 sub-device.
>  - As the first component of camera system including Seninf, ISP pipeline.
>  - A media entity that provides one source pad in common.
>  - Used in camera features on ChromeOS application.
>
> Also this driver supports following features:
>  - manual exposure and analog gain control support
>  - vertical blanking control support
>  - test pattern support
>  - media controller support
>  - runtime PM support
>  - support resolution: 2592x1944@30fps, 1280x720@60fps

Not even going to do a thorough review as one should learn on the
previous reviews. Most of the comments that I had given to another
driver submission are applicable here. So, waiting for v2 with all
applicable being addressed.

Zhi Mao (毛智) March 16, 2024, 3:03 a.m. UTC | #2

Hi Andy,

Thanks for your review.


On Wed, 2024-03-13 at 10:52 +0200, Andy Shevchenko wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Wed, Mar 13, 2024 at 7:54 AM Zhi Mao <[e-mail]>
> wrote:
> >
> > This series adds YAML DT binding and V4L2 sub-device driver for
> Galaxycore's
> > GC05A2 5-megapixel 10-bit RAW CMOS 1/5" sensor, with an MIPI CSI-2
> image data
> > interface and the I2C control bus.
> >
> > The driver is implemented with V4L2 framework.
> >  - Async registered as a V4L2 sub-device.
> >  - As the first component of camera system including Seninf, ISP
> pipeline.
> >  - A media entity that provides one source pad in common.
> >  - Used in camera features on ChromeOS application.
> >
> > Also this driver supports following features:
> >  - manual exposure and analog gain control support
> >  - vertical blanking control support
> >  - test pattern support
> >  - media controller support
> >  - runtime PM support
> >  - support resolution: 2592x1944@30fps, 1280x720@60fps
> 
> Not even going to do a thorough review as one should learn on the
> previous reviews. Most of the comments that I had given to another
> driver submission are applicable here. So, waiting for v2 with all
> applicable being addressed.
> 

The comments are fixed in patch:v1

https://lore.kernel.org/linux-media/[e-mail]/
> -- 
> With Best Regards,
> Andy Shevchenko