| Message ID | 20240327091336.3434141-1-wenst@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | pinctrl: mediatek: paris: More pin config cleanups | expand |
On Wed, Mar 27, 2024 at 10:13 AM Chen-Yu Tsai <wenst@chromium.org> wrote: > Here are a couple more pin config cleanups for the MediaTek paris > pinctrl driver library. > > Patch 1 fixes readback of PIN_CONFIG_INPUT_SCHMITT_ENABLE. The function > was passing back the disabled state incorrectly. > > Patch 2 reworks support for PIN_CONFIG_{INPUT,OUTPUT}_ENABLE, following > discussions on the bcm2835/bcm2711 pinctrl drivers [1]. The driver is > made to follow the definitions of each option as described in the DT > bindings and pinctrl core. > > Please have a look and merge if possible. Patches applied for fixes, it looks like pretty urgent stuff, yet no feedback from maintainers for a week so I applied it. Yours, Linus Walleij
Il 04/04/24 10:23, Linus Walleij ha scritto: > On Wed, Mar 27, 2024 at 10:13 AM Chen-Yu Tsai <wenst@chromium.org> wrote: > >> Here are a couple more pin config cleanups for the MediaTek paris >> pinctrl driver library. >> >> Patch 1 fixes readback of PIN_CONFIG_INPUT_SCHMITT_ENABLE. The function >> was passing back the disabled state incorrectly. >> >> Patch 2 reworks support for PIN_CONFIG_{INPUT,OUTPUT}_ENABLE, following >> discussions on the bcm2835/bcm2711 pinctrl drivers [1]. The driver is >> made to follow the definitions of each option as described in the DT >> bindings and pinctrl core. >> >> Please have a look and merge if possible. > > Patches applied for fixes, it looks like pretty urgent stuff, yet no feedback > from maintainers for a week so I applied it. > > Yours, > Linus Walleij Yeah - sorry about that, but this one went out of my radar for whatever reason.... Just had a look at it and - even if it's too late - I can give my approval. Please feel free to ping me if this happens again: when done for a good reason, pings are helpful and appreciated on my side, no worries! Btw, Linus, thanks for swiftly applying this as - yes - those are good and high priority fixes. *Anyway* - whole series is Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cheers, Angelo
Hi, Here are a couple more pin config cleanups for the MediaTek paris pinctrl driver library. Patch 1 fixes readback of PIN_CONFIG_INPUT_SCHMITT_ENABLE. The function was passing back the disabled state incorrectly. Patch 2 reworks support for PIN_CONFIG_{INPUT,OUTPUT}_ENABLE, following discussions on the bcm2835/bcm2711 pinctrl drivers [1]. The driver is made to follow the definitions of each option as described in the DT bindings and pinctrl core. Please have a look and merge if possible. Thanks ChenYu [1] https://lore.kernel.org/linux-arm-kernel/CAGb2v66XpjvDnTpi2=SPbeAPf844FLCai6YFwvVqvmF9z4Mj=A@mail.gmail.com/ Chen-Yu Tsai (2): pinctrl: mediatek: paris: Fix PIN_CONFIG_INPUT_SCHMITT_ENABLE readback pinctrl: mediatek: paris: Rework support for PIN_CONFIG_{INPUT,OUTPUT}_ENABLE drivers/pinctrl/mediatek/pinctrl-paris.c | 40 ++++++++---------------- 1 file changed, 13 insertions(+), 27 deletions(-)