| Message ID | 20241105-post-reset-v2-0-c1dc94b65017@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Using i2c-hid-of-elan driver instead of i2c-hid-of driver | expand |
On Tue, 05 Nov 2024 03:08:10 +0000, Hsin-Te Yuan wrote: > After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to > i2c-hid-of"), i2c-hid-of driver resets the touchscreen without having > proper post-reset delay on OF platform. From the commit message of that > commit, not to decribe poset-reset delay in device tree is intended. > Instead, describing the delay in platform data and changing to use > specialized driver is more preferable solution. > > Also workaround the race condition of pinctrl used by touchscreen and > trackpad in this series to avoid merge conflict. > > Adding other second source touchscreen used by some mt8183 devices in > this series since this should be based on the workaround of pinctrl > issue. > > Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org> > --- > Changes in v2: > - Add second source touchscreen patches since they should based on the > first patch of this series. > - Link to v1: https://lore.kernel.org/r/20241018-post-reset-v1-0-5aadb7550037@chromium.org > > --- > Hsin-Te Yuan (4): > arm64: dts: mediatek: mt8183: Fix race condition of pinctrl > arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver > arm64: dts: mediatek: mt8183: kenzo: Support second source touchscreen > arm64: dts: mediatek: mt8183: willow: Support second source touchscreen > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts | 2 -- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts | 3 --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 12 +++--------- > .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 11 ++--------- > .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 11 ++--------- > .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 11 ++--------- > .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi | 3 --- > .../boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi | 3 --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts | 3 --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 --- > .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi | 3 --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 10 +++------- > 12 files changed, 12 insertions(+), 63 deletions(-) > --- > base-commit: eca631b8fe808748d7585059c4307005ca5c5820 > change-id: 20241018-post-reset-ac66b0351613 > > Best regards, > -- > Hsin-Te Yuan <yuanhsinte@chromium.org> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8183-kukui-jacuzzi-burnet.dtb mediatek/mt8183-kukui-jacuzzi-cozmo.dtb mediatek/mt8183-kukui-jacuzzi-damu.dtb mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb mediatek/mt8183-kukui-jacuzzi-kenzo.dtb mediatek/mt8183-kukui-jacuzzi-pico.dtb mediatek/mt8183-kukui-jacuzzi-pico6.dtb' for 20241105-post-reset-v2-0-c1dc94b65017@chromium.org: arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb: dsi@14014000: Unevaluated properties are not allowed ('ports' was unexpected) from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,dsi.yaml#
Il 05/11/24 04:08, Hsin-Te Yuan ha scritto: > After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to > i2c-hid-of"), i2c-hid-of driver resets the touchscreen without having > proper post-reset delay on OF platform. From the commit message of that > commit, not to decribe poset-reset delay in device tree is intended. > Instead, describing the delay in platform data and changing to use > specialized driver is more preferable solution. > > Also workaround the race condition of pinctrl used by touchscreen and > trackpad in this series to avoid merge conflict. > > Adding other second source touchscreen used by some mt8183 devices in > this series since this should be based on the workaround of pinctrl > issue. > > Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org> The switch to i2c-hid-of-elan is okay, but the pinctrl hack is not necessary anymore, as it does get resolved with the hwprober from Chen-Yu https://lore.kernel.org/all/20241106093335.1582205-1-wenst@chromium.org/ Please redo the second source TS addition based on that series instead. Thanks, Angelo > --- > Changes in v2: > - Add second source touchscreen patches since they should based on the > first patch of this series. > - Link to v1: https://lore.kernel.org/r/20241018-post-reset-v1-0-5aadb7550037@chromium.org > > --- > Hsin-Te Yuan (4): > arm64: dts: mediatek: mt8183: Fix race condition of pinctrl > arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver > arm64: dts: mediatek: mt8183: kenzo: Support second source touchscreen > arm64: dts: mediatek: mt8183: willow: Support second source touchscreen > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts | 2 -- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts | 3 --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 12 +++--------- > .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 11 ++--------- > .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 11 ++--------- > .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 11 ++--------- > .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi | 3 --- > .../boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi | 3 --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts | 3 --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 --- > .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi | 3 --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 10 +++------- > 12 files changed, 12 insertions(+), 63 deletions(-) > --- > base-commit: eca631b8fe808748d7585059c4307005ca5c5820 > change-id: 20241018-post-reset-ac66b0351613 > > Best regards,
After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of"), i2c-hid-of driver resets the touchscreen without having proper post-reset delay on OF platform. From the commit message of that commit, not to decribe poset-reset delay in device tree is intended. Instead, describing the delay in platform data and changing to use specialized driver is more preferable solution. Also workaround the race condition of pinctrl used by touchscreen and trackpad in this series to avoid merge conflict. Adding other second source touchscreen used by some mt8183 devices in this series since this should be based on the workaround of pinctrl issue. Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org> --- Changes in v2: - Add second source touchscreen patches since they should based on the first patch of this series. - Link to v1: https://lore.kernel.org/r/20241018-post-reset-v1-0-5aadb7550037@chromium.org --- Hsin-Te Yuan (4): arm64: dts: mediatek: mt8183: Fix race condition of pinctrl arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver arm64: dts: mediatek: mt8183: kenzo: Support second source touchscreen arm64: dts: mediatek: mt8183: willow: Support second source touchscreen arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts | 2 -- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 12 +++--------- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 11 ++--------- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 11 ++--------- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 11 ++--------- .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi | 3 --- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 --- .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 10 +++------- 12 files changed, 12 insertions(+), 63 deletions(-) --- base-commit: eca631b8fe808748d7585059c4307005ca5c5820 change-id: 20241018-post-reset-ac66b0351613 Best regards,