[net-next,0/4] net: airoha: Add Qdisc offload support

Message

Lorenzo Bianconi Jan. 3, 2025, 12:17 p.m. UTC

Introduce support for ETS and HTB Qdisc offload available on the Airoha
EN7581 ethernet controller.

---
Lorenzo Bianconi (4):
      net: airoha: Enable Tx drop capability for each Tx DMA ring
      net: airoha: Introduce ndo_select_queue callback
      net: airoha: Add sched ETS offload support
      net: airoha: Add sched HTB offload support

 drivers/net/ethernet/mediatek/airoha_eth.c | 518 ++++++++++++++++++++++++++++-
 1 file changed, 514 insertions(+), 4 deletions(-)
---
base-commit: 3fff5da4ca2164bb4d0f1e6cd33f6eb8a0e73e50
change-id: 20241230-airoha-en7581-qdisc-offload-732c0fad564f

Best regards,

Comments

[e-mail] Jan. 7, 2025, 11:40 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <[e-mail]>:

On Fri, 03 Jan 2025 13:17:01 +0100 you wrote:
> Introduce support for ETS and HTB Qdisc offload available on the Airoha
> EN7581 ethernet controller.
> 
> ---
> Lorenzo Bianconi (4):
>       net: airoha: Enable Tx drop capability for each Tx DMA ring
>       net: airoha: Introduce ndo_select_queue callback
>       net: airoha: Add sched ETS offload support
>       net: airoha: Add sched HTB offload support
> 
> [...]

Here is the summary with links:
  - [net-next,1/4] net: airoha: Enable Tx drop capability for each Tx DMA ring
    https://git.kernel.org/netdev/net-next/c/5f7955903804
  - [net-next,2/4] net: airoha: Introduce ndo_select_queue callback
    https://git.kernel.org/netdev/net-next/c/2b288b81560b
  - [net-next,3/4] net: airoha: Add sched ETS offload support
    https://git.kernel.org/netdev/net-next/c/20bf7d07c956
  - [net-next,4/4] net: airoha: Add sched HTB offload support
    https://git.kernel.org/netdev/net-next/c/ef1ca9271313

You are awesome, thank you!

Davide Caratti Jan. 7, 2025, 12:32 p.m. UTC | #2

hi,

On Tue, Jan 7, 2025 at 12:40 PM <[e-mail]> wrote:
>
> Hello:
>
> This series was applied to netdev/net-next.git (main)
> by Paolo Abeni <[e-mail]>:
>
> On Fri, 03 Jan 2025 13:17:01 +0100 you wrote:
> > Introduce support for ETS and HTB Qdisc offload available on the Airoha
> > EN7581 ethernet controller.
> >
> > ---
> > Lorenzo Bianconi (4):
> >       net: airoha: Enable Tx drop capability for each Tx DMA ring
> >       net: airoha: Introduce ndo_select_queue callback
> >       net: airoha: Add sched ETS offload support

I was about to comment that ETS offload code probably still lacks
validation of priomap [1]. Otherwise every ETS priomap will behave
like the one that's implemented in hardware. It can be addressed in a
follow-up commit, probably.

thanks,
--
davide

[1] https://lore.kernel.org/netdev/[e-mail]/

Lorenzo Bianconi Jan. 7, 2025, 9:55 p.m. UTC | #3

> hi,
> 
> On Tue, Jan 7, 2025 at 12:40 PM <[e-mail]> wrote:
> >
> > Hello:
> >
> > This series was applied to netdev/net-next.git (main)
> > by Paolo Abeni <[e-mail]>:
> >
> > On Fri, 03 Jan 2025 13:17:01 +0100 you wrote:
> > > Introduce support for ETS and HTB Qdisc offload available on the Airoha
> > > EN7581 ethernet controller.
> > >
> > > ---
> > > Lorenzo Bianconi (4):
> > >       net: airoha: Enable Tx drop capability for each Tx DMA ring
> > >       net: airoha: Introduce ndo_select_queue callback
> > >       net: airoha: Add sched ETS offload support
> 
> I was about to comment that ETS offload code probably still lacks
> validation of priomap [1]. Otherwise every ETS priomap will behave
> like the one that's implemented in hardware. It can be addressed in a
> follow-up commit, probably.

sorry, I forgot about it. I am fine to enforce priomap if it is required with a
follow-up patch. 

Regards,
Lorenzo

> 
> thanks,
> --
> davide
> 
> [1] https://lore.kernel.org/netdev/[e-mail]/
>