[v3,0/1] i2c: mediatek: add runtime PM operations and bus regulator control

Message

Zoie Lin Jan. 3, 2025, 2:32 p.m. UTC

This series is based on linux-next, tag: next-20241220

Changes in v3:

This patch removes the autosuspend functionality from the runtime 
PM operations in the I2C driver. These changes have been tested on 
the target platform and confirmed to work correctly without the 
autosuspend functionality.

Additionally, the patch resumes the I2C bus in mtk_i2c_resume_noirq() 
to fix the unbalanced disable issue.


Zoie Lin (1):
  i2c: mediatek: add runtime PM operations and bus regulator control

 drivers/i2c/busses/i2c-mt65xx.c | 75 +++++++++++++++++++++++++++------
 1 file changed, 63 insertions(+), 12 deletions(-)

Comments

Andi Shyti Jan. 7, 2025, 9:28 p.m. UTC | #1

Hi Zoie,

On Fri, Jan 03, 2025 at 10:32:33PM +0800, Zoie Lin wrote:
> This series is based on linux-next, tag: next-20241220
> 
> Changes in v3:
> 
> This patch removes the autosuspend functionality from the runtime 
> PM operations in the I2C driver. These changes have been tested on 
> the target platform and confirmed to work correctly without the 
> autosuspend functionality.

Was the autosuspend delay not necessary, then?
Is there a specific reason you included it in the first place?

BTW, next time, please use the format [PATCH v3 0/1] for patches.
Also, for just one patch, a cover letter isn't really necessary.
You can include the changelog after the '---' section of the patch.
was, then, the autosuspend delay not necessary?

Andi

> Additionally, the patch resumes the I2C bus in mtk_i2c_resume_noirq() 
> to fix the unbalanced disable issue.
> 
> 
> Zoie Lin (1):
>   i2c: mediatek: add runtime PM operations and bus regulator control
> 
>  drivers/i2c/busses/i2c-mt65xx.c | 75 +++++++++++++++++++++++++++------
>  1 file changed, 63 insertions(+), 12 deletions(-)
> 
> -- 
> 2.45.2
>