From patchwork Fri Feb 21 07:48:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Friday Yang X-Patchwork-Id: 13984925 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FE64C021AA for ; Fri, 21 Feb 2025 07:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=+p3u8QpwBGDD06/FRGFqUOiwVFnXjMgtFPrCz59h9Ms=; b=18zpqBoK+ytzH2vGSEdU4vDqiv KJHwRK7I7Ns8bqwIoeRvSjBilzK1y9ctIw+rb6MQ4ofD3JTN7g81Og1nZJCFNRexO1z0e3mMcff3r XPUsxPUOdCQFIEfRELZsms2aT2p40gTwl4b/xwFHal4MI7LLztXq6G1bTrZlpm0TnhN5UDBOf82WW 778xpoiAG9dnF+4RbmD0oBcafi41LB0X2GHqpNhNM+ZejpXG9woaB4otfPrauK3QTOaRiQm94HPI0 n4VhnEdebIfwUbnouHffFL1g8O7PO/Uxk2XB5rdQ0ewx+FpYBDpD2WsjzLQ08gmmiJ5xLZDkykJX2 +vRpZ5Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tlNox-00000004aFQ-2Eqt; Fri, 21 Feb 2025 07:51:39 +0000 Received: from [216.200.240.184] (helo=mailgw01.mediatek.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tlNmL-00000004Zh6-1vCs; Fri, 21 Feb 2025 07:48:58 +0000 X-UUID: 4aac5d6af02811ef83f2a1c9db70dae0-20250221 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=+p3u8QpwBGDD06/FRGFqUOiwVFnXjMgtFPrCz59h9Ms=; b=SdnP3OWgLqLq/qoseBLuL+rOHRMT4t8yHjUtMyhsH8iJWfas00RxBj0GTJCO3ShxY9Wh5VGH0nZT5/xzZRfJSf2pddVOuhSZrm6tZt5nA8RxrD14Sm9z1DnoLQ6UX1J44DRSbr/XXFOG/rydoVgL/7DuAXstFBpPGu+Sa0fOX5c=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.46,REQID:051d8f64-a301-4a9f-bb54-f5d8af34165a,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:60aa074,CLOUDID:753968b5-a2a1-4ef3-9ef9-e116773da0a7,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0|50,EDM:-3,IP:ni l,URL:1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_ULS,TF_CID_SPAM_SNR X-UUID: 4aac5d6af02811ef83f2a1c9db70dae0-20250221 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 161976412; Fri, 21 Feb 2025 00:48:51 -0700 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Fri, 21 Feb 2025 15:48:48 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1258.28 via Frontend Transport; Fri, 21 Feb 2025 15:48:48 +0800 From: Friday Yang To: Yong Wu , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Philipp Zabel CC: Friday Yang , , , , , Subject: [PATCH v4 0/2] Add SMI reset and clamp for MediaTek MT8188 SoC Date: Fri, 21 Feb 2025 15:48:30 +0800 Message-ID: <20250221074846.14105-1-friday.yang@mediatek.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250220_234857_509414_A2A86D04 X-CRM114-Status: UNSURE ( 9.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Based on tag: next-20250220, linux-next/master On the MediaTek MT8188 SoC platform, we encountered power-off failures and SMI bus hang issues during camera stress tests. The issue arises because bus glitches are sometimes produced when MTCMOS powers on or off. While this is fairly normal, the software must handle these glitches to avoid mistaking them for transaction signals. What's more, this issue emerged only after the initial upstreaming of SMI driver. The software solutions can be summarized as follows: 1. Use CLAMP to disable the SMI sub-common port after turning off the LARB CG and before turning off the LARB MTCMOS. 2. Use CLAMP to disable/enable the SMI sub-common port. 3. Implement an AXI reset for SMI LARBs. Changes v4: - Use 'devm_reset_control_get_optional_exclusive' instead of 'devm_reset_control_get'. v3: https://lore.kernel.org/lkml/20250121064934.13482-2- friday.yang@mediatek.com/ https://lore.kernel.org/lkml/20250121064934.13482-3- friday.yang@mediatek.com/ friday.yang (2): dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188 memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188 .../mediatek,smi-common.yaml | 2 + .../memory-controllers/mediatek,smi-larb.yaml | 20 +++ drivers/memory/mtk-smi.c | 141 +++++++++++++++++- 3 files changed, 159 insertions(+), 4 deletions(-) --- 2.46.0