mbox series

[0/3] wifi: mt76: introduce WED TX support for mt7986 SoC

Message ID cover.1664356281.git.lorenzo@kernel.org (mailing list archive)
Headers show
Series wifi: mt76: introduce WED TX support for mt7986 SoC | expand

Message

Lorenzo Bianconi Sept. 28, 2022, 9:19 a.m. UTC
Enable WED TX support for mt7915 and mt7986-wmac drivers running on MT7986 SoC.
This is series is based on the following net-next series not merged yet in
wireless-next tree:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=377c17c6757ccf43e97f681a6ac5163d3735ab0a

Lorenzo Bianconi (3):
  wifi: mt76: mt7915: move wed init routines in mmio.c
  wifi: mt76: mt7915: enable wed for mt7986 chipset
  wifi: mt76: mt7915: enable wed for mt7986-wmac chipset

 .../net/wireless/mediatek/mt76/mt7915/dma.c   |  75 +++++++---
 .../net/wireless/mediatek/mt76/mt7915/main.c  |   2 +-
 .../net/wireless/mediatek/mt76/mt7915/mcu.c   |   2 +-
 .../net/wireless/mediatek/mt76/mt7915/mmio.c  | 135 +++++++++++++++++-
 .../wireless/mediatek/mt76/mt7915/mt7915.h    |   2 +
 .../net/wireless/mediatek/mt76/mt7915/pci.c   |  93 +-----------
 .../net/wireless/mediatek/mt76/mt7915/regs.h  |  13 ++
 .../net/wireless/mediatek/mt76/mt7915/soc.c   |  21 ++-
 8 files changed, 222 insertions(+), 121 deletions(-)

Comments

Kalle Valo Oct. 12, 2022, 5:42 a.m. UTC | #1
Lorenzo Bianconi <lorenzo@kernel.org> writes:

> Enable WED TX support for mt7915 and mt7986-wmac drivers running on MT7986 SoC.

What's WED TX?
Lorenzo Bianconi Oct. 12, 2022, 9:25 a.m. UTC | #2
> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> 
> > Enable WED TX support for mt7915 and mt7986-wmac drivers running on MT7986 SoC.
> 
> What's WED TX?

It is the same as we did for MT7622. It is the capability to offload traffic
from lan/wan to wlan. I specified "TX" since MT7986 supports even RX
offloading (I am working on it at the moment).

Regards,
Lorenzo

> 
> -- 
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Kalle Valo Oct. 13, 2022, 6:17 a.m. UTC | #3
Lorenzo Bianconi <lorenzo@kernel.org> writes:

>> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>> 
>> > Enable WED TX support for mt7915 and mt7986-wmac drivers running on MT7986 SoC.
>> 
>> What's WED TX?
>
> It is the same as we did for MT7622. It is the capability to offload traffic
> from lan/wan to wlan. I specified "TX" since MT7986 supports even RX
> offloading (I am working on it at the moment).

It would be nice to mention in the commit log that the feature is about
offloading traffic from lan/wan to wlan. That way it's stored to to git
history and people like me have some clue what the patch is about,
otherwise we are totally in dark.
Lorenzo Bianconi Oct. 13, 2022, 8:48 a.m. UTC | #4
> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> 
> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >> 
> >> > Enable WED TX support for mt7915 and mt7986-wmac drivers running on MT7986 SoC.
> >> 
> >> What's WED TX?
> >
> > It is the same as we did for MT7622. It is the capability to offload traffic
> > from lan/wan to wlan. I specified "TX" since MT7986 supports even RX
> > offloading (I am working on it at the moment).
> 
> It would be nice to mention in the commit log that the feature is about
> offloading traffic from lan/wan to wlan. That way it's stored to to git
> history and people like me have some clue what the patch is about,
> otherwise we are totally in dark.

I think Felix has already applied them.
@Felix: are you taking care of it or do I need to repost?

Regards,
Lorenzo

> 
> -- 
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Felix Fietkau Oct. 13, 2022, 8:50 a.m. UTC | #5
On 13.10.22 10:48, Lorenzo Bianconi wrote:
>> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>> 
>> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>> >> 
>> >> > Enable WED TX support for mt7915 and mt7986-wmac drivers running on MT7986 SoC.
>> >> 
>> >> What's WED TX?
>> >
>> > It is the same as we did for MT7622. It is the capability to offload traffic
>> > from lan/wan to wlan. I specified "TX" since MT7986 supports even RX
>> > offloading (I am working on it at the moment).
>> 
>> It would be nice to mention in the commit log that the feature is about
>> offloading traffic from lan/wan to wlan. That way it's stored to to git
>> history and people like me have some clue what the patch is about,
>> otherwise we are totally in dark.
> 
> I think Felix has already applied them.
> @Felix: are you taking care of it or do I need to repost?
No need to repost - just send me the description that you want to put in 
there, and I'll update the commit.

- Felix
Kalle Valo Oct. 13, 2022, 9:04 a.m. UTC | #6
Felix Fietkau <nbd@nbd.name> writes:

> On 13.10.22 10:48, Lorenzo Bianconi wrote:
>>> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>>>
>>> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>>> >> >> > Enable WED TX support for mt7915 and mt7986-wmac drivers
>>> running on MT7986 SoC.
>>> >> >> What's WED TX?
>>> >
>>> > It is the same as we did for MT7622. It is the capability to offload traffic
>>> > from lan/wan to wlan. I specified "TX" since MT7986 supports even RX
>>> > offloading (I am working on it at the moment).
>>>
>>> It would be nice to mention in the commit log that the feature is about
>>> offloading traffic from lan/wan to wlan. That way it's stored to to git
>>> history and people like me have some clue what the patch is about,
>>> otherwise we are totally in dark.
>>
>> I think Felix has already applied them.
>> @Felix: are you taking care of it or do I need to repost?
>
> No need to repost - just send me the description that you want to put
> in there, and I'll update the commit.

Thanks. And if it's too much work to change it feel free to keep it as
is. Just try to keep this mind in the future when using exotic acronyms :)
Lorenzo Bianconi Oct. 13, 2022, 9:07 a.m. UTC | #7
> Felix Fietkau <nbd@nbd.name> writes:
> 
> > On 13.10.22 10:48, Lorenzo Bianconi wrote:
> >>> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >>>
> >>> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >>> >> >> > Enable WED TX support for mt7915 and mt7986-wmac drivers
> >>> running on MT7986 SoC.
> >>> >> >> What's WED TX?
> >>> >
> >>> > It is the same as we did for MT7622. It is the capability to offload traffic
> >>> > from lan/wan to wlan. I specified "TX" since MT7986 supports even RX
> >>> > offloading (I am working on it at the moment).
> >>>
> >>> It would be nice to mention in the commit log that the feature is about
> >>> offloading traffic from lan/wan to wlan. That way it's stored to to git
> >>> history and people like me have some clue what the patch is about,
> >>> otherwise we are totally in dark.
> >>
> >> I think Felix has already applied them.
> >> @Felix: are you taking care of it or do I need to repost?
> >
> > No need to repost - just send me the description that you want to put
> > in there, and I'll update the commit.
> 
> Thanks. And if it's too much work to change it feel free to keep it as
> is. Just try to keep this mind in the future when using exotic acronyms :)

ack, I will do for the rx counterpart :)

Regards,
Lorenzo

> 
> -- 
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches