From patchwork Thu May 21 14:57:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 6456021 Return-Path: X-Original-To: patchwork-linux-mediatek@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7B34D9F318 for ; Thu, 21 May 2015 14:58:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D09E4202AE for ; Thu, 21 May 2015 14:58:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19524202A1 for ; Thu, 21 May 2015 14:58:08 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YvRvD-00006l-N6; Thu, 21 May 2015 14:58:07 +0000 Received: from mail-pd0-f169.google.com ([209.85.192.169]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YvRv8-0008Vq-5o for linux-mediatek@lists.infradead.org; Thu, 21 May 2015 14:58:06 +0000 Received: by pdea3 with SMTP id a3so110909270pde.2 for ; Thu, 21 May 2015 07:57:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=k/I8vf9Ln0y7TGce2T7sU/qpNoPg/fMWTnnczw68uq0=; b=mfThcSkLVAVlwjLM5hJbnORrifyUDdhlSN3Fu+Wa3QLyOt+IHZTyDyaNOBrhUCST3i hhoAf/2JG145v1gyY7a1Tc8SD2y8BTCNc1uodxG6idkCuSTTrcSww8lRGrbYRLiv9/Jf ivCXiq4S6pP924+l3aHUn5bFuPVV1keKV2jgq3F5CFtoAbrceLZUFkmCZl8CTcc6ASfy yTzipVSrJ+57A8jlpmbR3eOcHJB0T7I7yOr22nmBp5laRg1rYwE58X88Hvug+DzZi+SH 2Rx7G5O/NQcLLfHqQzeR+/k801DJkvkzs2eNjbKQdlRqd8qXnNvlLGWE0ar8ZTwKzYzg XtXA== X-Gm-Message-State: ALoCoQkMToLUz31Sc9Sc8bBR4NNZFVmXoAzTHz+RBsT8tN4zrVfCgiy6Jew2vFT3SSfxpr0YKowg X-Received: by 10.70.135.195 with SMTP id pu3mr6538469pdb.0.1432220259638; Thu, 21 May 2015 07:57:39 -0700 (PDT) Received: from phoenix.local (36-239-228-112.dynamic-ip.hinet.net. [36.239.228.112]) by mx.google.com with ESMTPSA id pu1sm19550575pdb.33.2015.05.21.07.57.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 May 2015 07:57:38 -0700 (PDT) Message-ID: <1432220254.29544.1.camel@ingics.com> Subject: [PATCH] irqchip: irq-mtk-sysirq: Make mtk_sysirq_of_init return error if ioremap fails From: Axel Lin To: Thomas Gleixner , Jason Cooper Date: Thu, 21 May 2015 22:57:34 +0800 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150521_075802_252020_904E2636 X-CRM114-Status: UNSURE ( 7.16 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.8 (-) Cc: Matthias Brugger , Yingjoe Chen , "linux-mediatek@lists.infradead.org" , linux-kernel@vger.kernel.org X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP PTR_ERR(NULL) returns 0 so current code returns 0 if ioremap fails, fix it. Signed-off-by: Axel Lin Reviewed-by: Matthias Brugger --- drivers/irqchip/irq-mtk-sysirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c index 04de2d4..15c1303 100644 --- a/drivers/irqchip/irq-mtk-sysirq.c +++ b/drivers/irqchip/irq-mtk-sysirq.c @@ -144,7 +144,7 @@ static int __init mtk_sysirq_of_init(struct device_node *node, chip_data->intpol_base = ioremap(res.start, size); if (!chip_data->intpol_base) { pr_err("mtk_sysirq: unable to map sysirq register\n"); - ret = PTR_ERR(chip_data->intpol_base); + ret = -ENXIO; goto out_free; }