| Message ID | 1447740178-29588-1-git-send-email-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 17, 2015 at 02:02:58PM +0800, Chunfeng Yun wrote: > when use the default value 8 of RG_USB20_SQTH, the HS receiver > sensitivity test of HQA will fail, set it as 2 to fix up the > issue. > > Change-Id: Ia5bdbbfc8ebb170d3ef26007e665b7350b6d28ab What is this field for? Hint, it should never be there for a patch you submit upstream as it means nothing... greg k-h
Hi, On Mon, 2015-11-16 at 22:16 -0800, Greg KH wrote: > On Tue, Nov 17, 2015 at 02:02:58PM +0800, Chunfeng Yun wrote: > > when use the default value 8 of RG_USB20_SQTH, the HS receiver > > sensitivity test of HQA will fail, set it as 2 to fix up the > > issue. > > > > Change-Id: Ia5bdbbfc8ebb170d3ef26007e665b7350b6d28ab > > What is this field for? Hint, it should never be there for a patch you > submit upstream as it means nothing... > I'm sorry for forgetting remove it. And I will remove change-id in next round after review Thanks a lot > greg k-h
diff --git a/drivers/phy/phy-mt65xx-usb3.c b/drivers/phy/phy-mt65xx-usb3.c index f30b28b..dc480d3 100644 --- a/drivers/phy/phy-mt65xx-usb3.c +++ b/drivers/phy/phy-mt65xx-usb3.c @@ -49,6 +49,8 @@ #define PA6_RG_U2_ISO_EN BIT(31) #define PA6_RG_U2_BC11_SW_EN BIT(23) #define PA6_RG_U2_OTG_VBUSCMP_EN BIT(20) +#define PA6_RG_U2_SQTH GENMASK(3, 0) +#define PA6_RG_U2_SQTH_VAL(x) (0xf & (x)) #define U3P_U2PHYACR4 (SSUSB_SIFSLV_U2PHY_COM_BASE + 0x0020) #define P2C_RG_USB20_GPIO_CTL BIT(9) @@ -165,9 +167,10 @@ static void phy_instance_init(struct mt65xx_u3phy *u3phy, writel(tmp, port_base + U3P_U2PHYDTM0); } - /* DP/DM BC1.1 path Disable */ tmp = readl(port_base + U3P_USBPHYACR6); - tmp &= ~PA6_RG_U2_BC11_SW_EN; + tmp &= ~PA6_RG_U2_BC11_SW_EN; /* DP/DM BC1.1 path Disable */ + tmp &= ~PA6_RG_U2_SQTH; + tmp |= PA6_RG_U2_SQTH_VAL(2); writel(tmp, port_base + U3P_USBPHYACR6); tmp = readl(port_base + U3P_U3PHYA_DA_REG0);
when use the default value 8 of RG_USB20_SQTH, the HS receiver sensitivity test of HQA will fail, set it as 2 to fix up the issue. Change-Id: Ia5bdbbfc8ebb170d3ef26007e665b7350b6d28ab Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/phy/phy-mt65xx-usb3.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)