| Message ID | 1467639430-64370-1-git-send-email-john@phrozen.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday, July 4, 2016 3:37:10 PM CEST John Crispin wrote: > Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping") > adds handling for irq 1 and 2 to the uninit function but did not remove > irq 0 which is not used since irq grouping was introduced. Fix this by > removing the superfluous call to free_irq(). > > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: John Crispin <john@phrozen.org> > Acked-by: Arnd Bergmann <arnd@arndb.de> Thanks for the quick update!
From: John Crispin <john@phrozen.org> Date: Mon, 4 Jul 2016 15:37:10 +0200 > Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping") > adds handling for irq 1 and 2 to the uninit function but did not remove > irq 0 which is not used since irq grouping was introduced. Fix this by > removing the superfluous call to free_irq(). > > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: John Crispin <john@phrozen.org> Applied.
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index fbab9b2..682797e 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1492,7 +1492,6 @@ static void mtk_uninit(struct net_device *dev) phy_disconnect(mac->phy_dev); mtk_mdio_cleanup(eth); mtk_irq_disable(eth, ~0); - free_irq(eth->irq[0], dev); free_irq(eth->irq[1], dev); free_irq(eth->irq[2], dev); }
Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping") adds handling for irq 1 and 2 to the uninit function but did not remove irq 0 which is not used since irq grouping was introduced. Fix this by removing the superfluous call to free_irq(). Reported-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: John Crispin <john@phrozen.org> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 - 1 file changed, 1 deletion(-)