From patchwork Fri Sep 30 07:48:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 9357723 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 916D56075E for ; Fri, 30 Sep 2016 07:49:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8481429E64 for ; Fri, 30 Sep 2016 07:49:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 779D229E96; Fri, 30 Sep 2016 07:49:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, HK_RANDOM_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 794D229E64 for ; Fri, 30 Sep 2016 07:49:53 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bpsZt-0004m4-4j; Fri, 30 Sep 2016 07:49:53 +0000 Received: from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bpsZY-0004f4-Mv for linux-mediatek@lists.infradead.org; Fri, 30 Sep 2016 07:49:33 +0000 Received: by mail-pf0-x233.google.com with SMTP id 21so37784739pfy.0 for ; Fri, 30 Sep 2016 00:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=U18v6NTeE7yNQIZ8KiNaznN3ar+Rzfwc6IA8g+gsuFk=; b=G3+4WuKEgggwrO4WMfoqSU4HYCrscEduHEYuxLxpc8k8/u4dG6CiJH4W8C7nO1dbcx EwqTMgKmFXzBcDDovrrKCZ/v5kAOKPbVBSQWjF75hrQGb0XhFfmd4So+0mx/fIhpipGa d/9+9s2wc+M7yedciE3m2ZIdp7Ln4t4NvrLs0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=U18v6NTeE7yNQIZ8KiNaznN3ar+Rzfwc6IA8g+gsuFk=; b=m0pourL9BIYSxhnBxCMPQHAyixMI3C9+LPyK9OqRZC+QIK3eP8RNuQt0NEtwxaVr6H oMwhtIYdKxF/Qz3HUmDt864LLQXUsuAbTqeixFKLKPSqgULYKvjPz9F/9EjTbT/waf2g 1V8GSvbubi5Fzf+rTLji3c5M8E3toV3WJq9pKl3nG+uwBdHk0RYZYztk5V40B1jNVZ6O T8Ujls0CIr7hW41SvKuU7kQyXXLYRXbq91y4T22NGkp/rZg27y3hcvwpkn73ZvbKFqqp aF+fbpF3r0TZ/+5+pm3EE0uuCjRyRL+yqKUTkWFwQlWk41eAZrqeziwKaVAQmxlOpsBZ vrGQ== X-Gm-Message-State: AA6/9RlILP0UDdrph01hkG7PR7HpfkCQo6Iqfg2nJiqFrn2OSeoZOnZDWHgqwfviP7yLBXOZ X-Received: by 10.98.70.132 with SMTP id o4mr9662876pfi.132.1475221751632; Fri, 30 Sep 2016 00:49:11 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.182]) by smtp.gmail.com with ESMTPSA id t67sm25375613pfd.32.2016.09.30.00.49.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Sep 2016 00:49:10 -0700 (PDT) From: Baoyou Xie To: nbd@openwrt.org, blogic@openwrt.org, matthias.bgg@gmail.com Subject: [PATCH] net: ethernet: mediatek: mark symbols static where possible Date: Fri, 30 Sep 2016 15:48:50 +0800 Message-Id: <1475221730-18773-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160930_004932_844121_AB4611E2 X-CRM114-Status: GOOD ( 11.15 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arnd@arndb.de, netdev@vger.kernel.org, tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, han.fei@zte.com.cn, baoyou.xie@linaro.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP We get 2 warnings when building kernel with W=1: drivers/net/ethernet/mediatek/mtk_eth_soc.c:2041:5: warning: no previous prototype for 'mtk_get_link_ksettings' [-Wmissing-prototypes] drivers/net/ethernet/mediatek/mtk_eth_soc.c:2052:5: warning: no previous prototype for 'mtk_set_link_ksettings' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index ddf20a0..ad4ab97 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -2038,8 +2038,8 @@ static int mtk_cleanup(struct mtk_eth *eth) return 0; } -int mtk_get_link_ksettings(struct net_device *ndev, - struct ethtool_link_ksettings *cmd) +static int mtk_get_link_ksettings(struct net_device *ndev, + struct ethtool_link_ksettings *cmd) { struct mtk_mac *mac = netdev_priv(ndev); @@ -2049,8 +2049,8 @@ int mtk_get_link_ksettings(struct net_device *ndev, return phy_ethtool_ksettings_get(ndev->phydev, cmd); } -int mtk_set_link_ksettings(struct net_device *ndev, - const struct ethtool_link_ksettings *cmd) +static int mtk_set_link_ksettings(struct net_device *ndev, + const struct ethtool_link_ksettings *cmd) { struct mtk_mac *mac = netdev_priv(ndev);