From patchwork Thu Jan 26 14:50:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhumika Goyal X-Patchwork-Id: 9539369 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9E01A604A0 for ; Thu, 26 Jan 2017 14:52:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96CEA25E13 for ; Thu, 26 Jan 2017 14:52:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8AA9B27D4D; Thu, 26 Jan 2017 14:52:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0593825E13 for ; Thu, 26 Jan 2017 14:52:59 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cWlQ2-0001ft-JH; Thu, 26 Jan 2017 14:52:58 +0000 Received: from mail-pf0-f195.google.com ([209.85.192.195]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cWlPD-0000oi-LR; Thu, 26 Jan 2017 14:52:09 +0000 Received: by mail-pf0-f195.google.com with SMTP id e4so16560286pfg.0; Thu, 26 Jan 2017 06:51:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=hGFa7DPAFZJE5dGx+XJhzJ/3I/NF9IGnsgvFDHFSLX4=; b=alEww9eh1AArivdDnAZA3rS70XKSn5I14CHa8ZkVx9Bl8/nWSHkml+NdR2Twwkg/Wr q9ujkDO2g8RQlsXthJpKyps5Wfba29R8D684XUwecR64OWLYillLQjmOrdUnyWGT4Nv0 L1gspgNBZ++TGl5I5AvxjDaBh7c1MvcIAaX1NXdq1WIh6VXfm3TUXUmB2/PaQvo4rmvR Bt3AQu4CFX0agvZqwFUEH8FxEHhvBllz0NI1AN5rZ8rHQPHC+3d2pZVxoc+C0r+ZKxpA cZamuvR4DKllVJKhZDxw1+lehxtgzwWVPi8PvLdzme+adjj//Gg2kj4NP+KbdgBOn2T4 ErGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hGFa7DPAFZJE5dGx+XJhzJ/3I/NF9IGnsgvFDHFSLX4=; b=rppJneRDGrDqTqRMOCieGxL+obwnX2Cd/PXLn8vREVGNw4SHzXLeq/sbo/0xoLX8gO FG+u5O2rV2Yh++JDFZCqsmcusgmUFpRxwFwZ1pGDScZTdAAV2ocAUHudnRaMik2hrfYU ZCWNSo2naIn9FGOJOUId+yjRiTPoFbIWNSfAKncS36lcAa23IN23eGSLPA5idjncp/wz UiP7MAZpcKMAt7JxS4yMTXNZxV5moz9WvizJHcTP6zCg8nYVOv6MKyl4hfyB6/576Q0z 66AdEyfzSK5Z0wYjkxQhi/LHrL8I+xT+vGbBSjPrCBhUnkBxuk1SMS7BG9fCRZ8CYn8y kO3g== X-Gm-Message-State: AIkVDXKPdynAjayoC+nfOOzpmAETaTyCoO6JRPlIwQueHky51avCf7VbWihNowKAGzkkGg== X-Received: by 10.84.142.101 with SMTP id 92mr4674252plw.66.1485442247147; Thu, 26 Jan 2017 06:50:47 -0800 (PST) Received: from gmail.com ([2405:204:5407:562c:ec75:efc8:4903:575d]) by smtp.gmail.com with ESMTPSA id w2sm4146776pfi.65.2017.01.26.06.50.39 (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 26 Jan 2017 06:50:46 -0800 (PST) Received: by gmail.com (sSMTP sendmail emulation); Thu, 26 Jan 2017 20:20:35 +0530 From: Bhumika Goyal To: julia.lawall@lip6.fr, ulf.hansson@linaro.org, matthias.bgg@gmail.com, saschasommer@freenet.de, maxime.ripard@free-electrons.com, wens@csie.org, tony.olech@elandigitalsystems.com, linux@prisktech.co.nz, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-usb@vger.kernel.org Subject: [PATCH] mmc: host: constify mmc_host_ops structures Date: Thu, 26 Jan 2017 20:20:34 +0530 Message-Id: <1485442234-2900-1-git-send-email-bhumirks@gmail.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170126_065207_743212_60B4314D X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bhumika Goyal MIME-Version: 1.0 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Declare mmc_host_ops structures as const as they are only stored in the ops field of a mmc_host structure. This field is of type const, so mmc_host_ops structures having this property can be made const too. Done using Coccinelle: @r disable optional_qualifier@ identifier x; position p; @@ static struct mmc_host_ops x@p={...}; @ok@ struct mmc_host mmc; identifier r.x; position p; @@ mmc.ops=&x@p; @bad@ position p != {r.p,ok.p}; identifier r.x; @@ x@p @depends on !bad disable optional_qualifier@ identifier r.x; @@ +const struct mmc_host_ops x; File size details before and after patching. First line of every .o file shows the file size before patching and second line shows the size after patching. text data bss dec hex filename 4710 344 0 5054 13be drivers/mmc/host/moxart-mmc.o 4854 192 0 5046 13b6 drivers/mmc/host/moxart-mmc.o 10743 344 0 11087 2b4f drivers/mmc/host/mtk-sd.o 10887 192 0 11079 2b47 drivers/mmc/host/mtk-sd.o 2760 376 4 3140 c44 drivers/mmc/host/sdricoh_cs.o 2920 240 4 3164 c5c drivers/mmc/host/sdricoh_cs.o 9485 344 0 9829 2665 drivers/mmc/host/sh_mmcif.o 9645 192 0 9837 266d drivers/mmc/host/sh_mmcif.o 7281 344 0 7625 1dc9 drivers/mmc/host/sunxi-mmc.o 7441 192 0 7633 1dd1 drivers/mmc/host/sunxi-mmc.o 4982 408 0 5390 150e drivers/mmc/host/toshsd.o 5142 264 0 5406 151e drivers/mmc/host/toshsd.o 11239 344 0 11583 2d3f drivers/mmc/host/usdhi6rol0.o 11391 192 0 11583 2d3f drivers/mmc/host/usdhi6rol0.o 19444 541 29 20014 4e2e drivers/mmc/host/vub300.o 19604 381 29 20014 4e2e drivers/mmc/host/vub300.o 5487 376 0 5863 16e7 drivers/mmc/host/wmt-sdmmc.o 5639 220 0 5859 16e3 drivers/mmc/host/wmt-sdmmc.o Signed-off-by: Bhumika Goyal --- drivers/mmc/host/moxart-mmc.c | 2 +- drivers/mmc/host/mtk-sd.c | 2 +- drivers/mmc/host/sdricoh_cs.c | 2 +- drivers/mmc/host/sh_mmcif.c | 2 +- drivers/mmc/host/sunxi-mmc.c | 2 +- drivers/mmc/host/toshsd.c | 2 +- drivers/mmc/host/usdhi6rol0.c | 2 +- drivers/mmc/host/vub300.c | 2 +- drivers/mmc/host/wmt-sdmmc.c | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c index bbad309..ac07dab 100644 --- a/drivers/mmc/host/moxart-mmc.c +++ b/drivers/mmc/host/moxart-mmc.c @@ -548,7 +548,7 @@ static int moxart_get_ro(struct mmc_host *mmc) return !!(readl(host->base + REG_STATUS) & WRITE_PROT); } -static struct mmc_host_ops moxart_ops = { +static const struct mmc_host_ops moxart_ops = { .request = moxart_request, .set_ios = moxart_set_ios, .get_ro = moxart_get_ro, diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 10ef2ae..fa0c331 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -1467,7 +1467,7 @@ static void msdc_hw_reset(struct mmc_host *mmc) sdr_clr_bits(host->base + EMMC_IOCON, 1); } -static struct mmc_host_ops mt_msdc_ops = { +static const struct mmc_host_ops mt_msdc_ops = { .post_req = msdc_post_req, .pre_req = msdc_pre_req, .request = msdc_ops_request, diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c index 5ff26ab..6732753 100644 --- a/drivers/mmc/host/sdricoh_cs.c +++ b/drivers/mmc/host/sdricoh_cs.c @@ -388,7 +388,7 @@ static int sdricoh_get_ro(struct mmc_host *mmc) return (status & STATUS_CARD_LOCKED); } -static struct mmc_host_ops sdricoh_ops = { +static const struct mmc_host_ops sdricoh_ops = { .request = sdricoh_request, .set_ios = sdricoh_set_ios, .get_ro = sdricoh_get_ro, diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 9007784..93cff28 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -1095,7 +1095,7 @@ static int sh_mmcif_get_cd(struct mmc_host *mmc) return p->get_cd(host->pd); } -static struct mmc_host_ops sh_mmcif_ops = { +static const struct mmc_host_ops sh_mmcif_ops = { .request = sh_mmcif_request, .set_ios = sh_mmcif_set_ios, .get_cd = sh_mmcif_get_cd, diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c index b1d1303..e75e11a 100644 --- a/drivers/mmc/host/sunxi-mmc.c +++ b/drivers/mmc/host/sunxi-mmc.c @@ -1033,7 +1033,7 @@ static int sunxi_mmc_card_busy(struct mmc_host *mmc) return !!(mmc_readl(host, REG_STAS) & SDXC_CARD_DATA_BUSY); } -static struct mmc_host_ops sunxi_mmc_ops = { +static const struct mmc_host_ops sunxi_mmc_ops = { .request = sunxi_mmc_request, .set_ios = sunxi_mmc_set_ios, .get_ro = mmc_gpio_get_ro, diff --git a/drivers/mmc/host/toshsd.c b/drivers/mmc/host/toshsd.c index 553ef41..dd961c5 100644 --- a/drivers/mmc/host/toshsd.c +++ b/drivers/mmc/host/toshsd.c @@ -550,7 +550,7 @@ static int toshsd_get_cd(struct mmc_host *mmc) return !!(ioread16(host->ioaddr + SD_CARDSTATUS) & SD_CARD_PRESENT_0); } -static struct mmc_host_ops toshsd_ops = { +static const struct mmc_host_ops toshsd_ops = { .request = toshsd_request, .set_ios = toshsd_set_ios, .get_ro = toshsd_get_ro, diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c index 1bd5f1a..64da6a8 100644 --- a/drivers/mmc/host/usdhi6rol0.c +++ b/drivers/mmc/host/usdhi6rol0.c @@ -1185,7 +1185,7 @@ static int usdhi6_sig_volt_switch(struct mmc_host *mmc, struct mmc_ios *ios) return ret; } -static struct mmc_host_ops usdhi6_ops = { +static const struct mmc_host_ops usdhi6_ops = { .request = usdhi6_request, .set_ios = usdhi6_set_ios, .get_cd = usdhi6_get_cd, diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c index bb3e0d1..ec23121 100644 --- a/drivers/mmc/host/vub300.c +++ b/drivers/mmc/host/vub300.c @@ -2083,7 +2083,7 @@ static void vub300_init_card(struct mmc_host *mmc, struct mmc_card *card) dev_info(&vub300->udev->dev, "NO host QUIRKS for this card\n"); } -static struct mmc_host_ops vub300_mmc_ops = { +static const struct mmc_host_ops vub300_mmc_ops = { .request = vub300_mmc_request, .set_ios = vub300_mmc_set_ios, .get_ro = vub300_mmc_get_ro, diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c index 5af0055..1bf725a 100644 --- a/drivers/mmc/host/wmt-sdmmc.c +++ b/drivers/mmc/host/wmt-sdmmc.c @@ -725,7 +725,7 @@ static int wmt_mci_get_cd(struct mmc_host *mmc) return !(cd ^ priv->cd_inverted); } -static struct mmc_host_ops wmt_mci_ops = { +static const struct mmc_host_ops wmt_mci_ops = { .request = wmt_mci_request, .set_ios = wmt_mci_set_ios, .get_ro = wmt_mci_get_ro,