From patchwork Tue Mar 7 06:57:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunfeng Yun X-Patchwork-Id: 9608127 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E8C646046A for ; Tue, 7 Mar 2017 06:58:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D9CC42847F for ; Tue, 7 Mar 2017 06:58:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CE64E28485; Tue, 7 Mar 2017 06:58:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 812D62847F for ; Tue, 7 Mar 2017 06:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4hcung7OKLLqQC/YvUqIJLQEgCmYB6nK9RSh5xShFMQ=; b=FubWk4eY+YzWO2 pwAlXDmAty4MNgt4PSx7D1LFUhxb0QALBTnfaL69Mp/RFrW27b0c9iE9RlWcdWxDinP3qGdopqqqr fdxOP1W21LiCQjXniJVtf519p14O3CEtXsjaOQp9TZ5NosQaQyfCGlRrztw8VqlLgJHHjOBVF2IUT Z3WA45IRLqd7HsdIYHfV0z0eN4cqEGuEn4HGcweNtaBkoynn5NWe98XlFDTfFKI00B3x5yk8NhnI0 uCVpC3zqmMtsjpK3IRIxJ2Ty04i6PMTKxzttMdGA6cVTrapdqB4nXwd+K9FI0DGe63EdXqx/UgUCr aEVovTriT72m+u2ZlTww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cl94K-0004GH-UB; Tue, 07 Mar 2017 06:58:00 +0000 Received: from [210.61.82.183] (helo=mailgw01.mediatek.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cl94H-0004Ei-MD; Tue, 07 Mar 2017 06:57:59 +0000 Received: from mtkhts09.mediatek.inc [(172.21.101.70)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1413906739; Tue, 07 Mar 2017 14:57:31 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkhts09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 14.3.266.1; Tue, 7 Mar 2017 14:57:29 +0800 From: Chunfeng Yun To: Mathias Nyman Subject: [PATCH 2/2] usb: xhci-mtk: fix checkpatch warning and erorr Date: Tue, 7 Mar 2017 14:57:21 +0800 Message-ID: <1488869841-9959-2-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1488869841-9959-1-git-send-email-chunfeng.yun@mediatek.com> References: <1488869841-9959-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170306_225757_886372_4DA0DC04 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Chunfeng Yun , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP there are two warnings and a erorr when checked by checkpatch.pl as following: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c index 9636884..22c94fe 100644 --- a/drivers/usb/host/xhci-mtk.c +++ b/drivers/usb/host/xhci-mtk.c @@ -287,9 +287,9 @@ static void usb_wakeup_ip_sleep_dis(struct xhci_hcd_mtk *mtk) } /* -* for line-state wakeup mode, phy's power should not power-down -* and only support cable plug in/out -*/ + * for line-state wakeup mode, phy's power should not power-down + * and only support cable plug in/out + */ static void usb_wakeup_line_state_en(struct xhci_hcd_mtk *mtk) { u32 tmp; @@ -350,10 +350,10 @@ static int usb_wakeup_of_property_parse(struct xhci_hcd_mtk *mtk, struct device *dev = mtk->dev; /* - * wakeup function is optional, so it is not an error if this property - * does not exist, and in such case, no need to get relative - * properties anymore. - */ + * wakeup function is optional, so it is not an error if this property + * does not exist, and in such case, no need to get relative + * properties anymore. + */ of_property_read_u32(dn, "mediatek,wakeup-src", &mtk->wakeup_src); if (!mtk->wakeup_src) return 0; @@ -796,7 +796,7 @@ static int __maybe_unused xhci_mtk_resume(struct device *dev) static const struct dev_pm_ops xhci_mtk_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(xhci_mtk_suspend, xhci_mtk_resume) }; -#define DEV_PM_OPS IS_ENABLED(CONFIG_PM) ? &xhci_mtk_pm_ops : NULL +#define DEV_PM_OPS (IS_ENABLED(CONFIG_PM) ? &xhci_mtk_pm_ops : NULL) #ifdef CONFIG_OF static const struct of_device_id mtk_xhci_of_match[] = {