From patchwork Wed Nov 16 19:38:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 9432473 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 755F86021C for ; Wed, 16 Nov 2016 19:39:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6104229124 for ; Wed, 16 Nov 2016 19:39:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 558D429129; Wed, 16 Nov 2016 19:39:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F030829124 for ; Wed, 16 Nov 2016 19:39:29 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c763N-000777-Ff; Wed, 16 Nov 2016 19:39:29 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c7636-00070Y-Ua; Wed, 16 Nov 2016 19:39:14 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D0FB66156B; Wed, 16 Nov 2016 19:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1479325131; bh=mYj3wHq4ZtQyz4jGvs+Bl/21TUAjZi81neG0hJR9lEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FWSNdlh/pR9A05TOqb4epO7mQrar3xJYNtFROc8r4VQI9dXUV5NRipruzP8kemj/X 5zTf5PGDJ0XVG5xP9HqK22I7r8NQEQ94qmm1aZCSCaCAdSZKrjbvIWDdFR17dlQB1A lU/3kEhm1DirtVVQbscUPrkOGHAiBI7ttWQuDC94= Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 35A7560492; Wed, 16 Nov 2016 19:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1479325131; bh=mYj3wHq4ZtQyz4jGvs+Bl/21TUAjZi81neG0hJR9lEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FWSNdlh/pR9A05TOqb4epO7mQrar3xJYNtFROc8r4VQI9dXUV5NRipruzP8kemj/X 5zTf5PGDJ0XVG5xP9HqK22I7r8NQEQ94qmm1aZCSCaCAdSZKrjbvIWDdFR17dlQB1A lU/3kEhm1DirtVVQbscUPrkOGHAiBI7ttWQuDC94= DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 35A7560492 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 16 Nov 2016 11:38:50 -0800 From: Stephen Boyd To: Arnd Bergmann Subject: Re: [PATCH] iommu: mtk: add common-clk dependency Message-ID: <20161116193850.GK25626@codeaurora.org> References: <20161116152837.3508723-1-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161116152837.3508723-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161116_113913_113019_AC4B8E18 X-CRM114-Status: GOOD ( 14.15 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Liao , Joerg Roedel , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Shunli Wang , Matthias Brugger , Erin Lo , linux-arm-kernel@lists.infradead.org, John Crispin Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 11/16, Arnd Bergmann wrote: > After the MT2701 clock driver was added, we get a harmless warning for > the iommu driver that selects it, when compile-testing without > COMMON_CLK. > > warning: (MTK_IOMMU_V1) selects COMMON_CLK_MT2701_IMGSYS which has unmet direct dependencies (COMMON_CLK) > > Adding a dependency on COMMON_CLK avoids the warning. > > Fixes: e9862118272a ("clk: mediatek: Add MT2701 clock support") > Signed-off-by: Arnd Bergmann Hm.. why is an iommu driver selecting a clk driver? They should be using standard clk APIs so it's not like they need it for build time correctness. Shouldn't we drop the selects instead? Those look to have been introduced a few kernel versions ago, but they were selecting options that didn't exist until a few days ago when I merged the mediatek clk driver. The clk options are user-visible, so it should be possible to select them in the configuration phase. ----8<---- diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index 8ee54d71c7eb..37e204f3d9be 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig @@ -352,9 +352,6 @@ config MTK_IOMMU_V1 select IOMMU_API select MEMORY select MTK_SMI - select COMMON_CLK_MT2701_MMSYS - select COMMON_CLK_MT2701_IMGSYS - select COMMON_CLK_MT2701_VDECSYS help Support for the M4U on certain Mediatek SoCs. M4U generation 1 HW is Multimedia Memory Managememt Unit. This option enables remapping of