From patchwork Tue May 30 08:59:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 9754113 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BF3D3602F0 for ; Tue, 30 May 2017 09:00:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B2AC527E63 for ; Tue, 30 May 2017 09:00:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A728227FAD; Tue, 30 May 2017 09:00:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2820627E63 for ; Tue, 30 May 2017 09:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=IKW90bSpBoUtLlKi/pW/+xxqynlVc6VTPGQF98s+vdw=; b=qPv lkPpBgVNR0X6+BI1LFldC1bOtN1dQuKtNpYUApuJT2Bx1LaCwECTu2PbWQsjnZZUhrXAWHNekkrjT fgf80ThC4dZY67X/HEl3PmRQ5iw1REvVWs6k9GOQLB51n3Ld49ijY/Ao2fJ4EjO7TV7MdNQOFOJ+O BdgafrLBcZdAQHe/B3Eg3iT5nHQn8ZtSxkz+L/HE5zOPjti5TV7kdaSFn/ik/FRyWbjNKIdYyvpwi MWC0SLxuw8VN+6KcBx74eyivJIVRwMIUmvM72YPAdOjiSptzSgDQwzUTRcgfuFsX77G6zcXUSlLAt nbW4OKq2uOTRpz5t0R6GfxkgVMPzPlQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dFd0b-00010G-0D; Tue, 30 May 2017 09:00:09 +0000 Received: from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dFd0Y-0008DV-84 for linux-mediatek@lists.infradead.org; Tue, 30 May 2017 09:00:07 +0000 Received: by mail-pf0-x233.google.com with SMTP id n23so66568527pfb.2 for ; Tue, 30 May 2017 01:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=kN9X7OkdJtjY4cUxSG3RPdOE98OJmb/I7FvDwd21p0Y=; b=HdAhzdiOIStrOc268AS7OjUNXCpxIjZjrjyvRKJUm4l+aP1eFW5E6+EXvz7WXIL2cY LFXEBkRqomhX9plQHgUvS+mE34vHGQ/1SzUzKEjTqnA8wTrYenn42X/BNWZ0QP8C+PEq ldrKtm/SWXeYetWZ9vScQNAOgBVPn8r9GdcuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kN9X7OkdJtjY4cUxSG3RPdOE98OJmb/I7FvDwd21p0Y=; b=WS6Xp4AY0c0Iapbarm3hqriGW0oFuMpBmRFYnixWTA2V+Mxr6T5FaslRoh8ikK64mb 2XBbOF/Cw8QyHeUHjtG7kzB95v/5u7DjMSJ6kRNFVS4g2gjRscPpNA10Sgz5yEQVju/W iYcgTdjSVHsM0Q6j9ntHCezy8V4z/cQFT1ime9vZWCScY2ADB1b58FPpqWLqFNai/0zy HU0Gcb4Z2m2c9fxrhxCVXXfs1iUuc65b8dsBskwObTj98oXqYGS+bnxCRfcn9RJ1pd64 hZfJnEUGUWDYGni1gEkcouhl0B5Sprb7Y4+pW4d16Orxo/8/ke4lcv8aWHCAJX+qDSc4 6epQ== X-Gm-Message-State: AODbwcBkeFJ7xJieiS6X2W75Zxw9DI3N9whCnTxWEXREEJ0RlmPBabDY ynUomzOJ9CJePwbb X-Received: by 10.84.248.73 with SMTP id e9mr82057005pln.76.1496134782883; Tue, 30 May 2017 01:59:42 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([100.103.2.121]) by smtp.gmail.com with ESMTPSA id c196sm21402240pga.23.2017.05.30.01.59.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 May 2017 01:59:41 -0700 (PDT) From: Hirokazu Honda To: Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Matthias Brugger Subject: [PATCH] mtk-vcodec: Show mtk driver error without DEBUG definition Date: Tue, 30 May 2017 17:59:31 +0900 Message-Id: <20170530085931.187344-1-hiroh@chromium.org> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170530_020006_329818_A536C595 X-CRM114-Status: UNSURE ( 8.31 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hirokazu Honda , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org MIME-Version: 1.0 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP A driver error message is shown without DEBUG definition to find an error and debug easily. Signed-off-by: Hirokazu Honda --- drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h index 237e144c194f..06c254f5c171 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h @@ -32,6 +32,15 @@ extern int mtk_v4l2_dbg_level; extern bool mtk_vcodec_dbg; +#define mtk_v4l2_err(fmt, args...) \ + pr_err("[MTK_V4L2][ERROR] %s:%d: " fmt "\n", __func__, __LINE__, \ + ##args) + +#define mtk_vcodec_err(h, fmt, args...) \ + pr_err("[MTK_VCODEC][ERROR][%d]: %s() " fmt "\n", \ + ((struct mtk_vcodec_ctx *)h->ctx)->id, __func__, ##args) + + #if defined(DEBUG) #define mtk_v4l2_debug(level, fmt, args...) \ @@ -41,11 +50,6 @@ extern bool mtk_vcodec_dbg; level, __func__, __LINE__, ##args); \ } while (0) -#define mtk_v4l2_err(fmt, args...) \ - pr_err("[MTK_V4L2][ERROR] %s:%d: " fmt "\n", __func__, __LINE__, \ - ##args) - - #define mtk_v4l2_debug_enter() mtk_v4l2_debug(3, "+") #define mtk_v4l2_debug_leave() mtk_v4l2_debug(3, "-") @@ -57,22 +61,16 @@ extern bool mtk_vcodec_dbg; __func__, ##args); \ } while (0) -#define mtk_vcodec_err(h, fmt, args...) \ - pr_err("[MTK_VCODEC][ERROR][%d]: %s() " fmt "\n", \ - ((struct mtk_vcodec_ctx *)h->ctx)->id, __func__, ##args) - #define mtk_vcodec_debug_enter(h) mtk_vcodec_debug(h, "+") #define mtk_vcodec_debug_leave(h) mtk_vcodec_debug(h, "-") #else #define mtk_v4l2_debug(level, fmt, args...) {} -#define mtk_v4l2_err(fmt, args...) {} #define mtk_v4l2_debug_enter() {} #define mtk_v4l2_debug_leave() {} #define mtk_vcodec_debug(h, fmt, args...) {} -#define mtk_vcodec_err(h, fmt, args...) {} #define mtk_vcodec_debug_enter(h) {} #define mtk_vcodec_debug_leave(h) {}