From patchwork Thu Jul 6 20:51:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 9829005 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 15869602CA for ; Thu, 6 Jul 2017 20:52:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 052C328522 for ; Thu, 6 Jul 2017 20:52:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EDF6C28585; Thu, 6 Jul 2017 20:52:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 75F8828522 for ; Thu, 6 Jul 2017 20:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Os862WTFb1YWammOmlUJyR+g8KeOTlLhCfDrAeRlNqo=; b=Pi/qKm5LubDn31 yFriEs4h96nqsyP7p/sHXPC2Gxj/1HS/axglTR+X7VloDojfMjiyXEsj9U70JWsAEb80iZgNF2Swd uYnsyPb8+rPxCRcIo1bwc4b1zjMyIMNJHWVI6kQjNp18HPVu0GM4TiBU/3WSzxw0byqX63q4k1ZqQ wkCit84VVKBGflIawzK2U4+YRkt9tirgiTSXtmsqfjjgl64LTQ57iL5uheOYGstBvfVowVgavt5QN 2opRbFcRPgt7WiwDiaepMe3eAPHyIm5sBWDs9pxkSyIVwShbhPtGjVbjS2WfjxFN3Us+WrMPmqypf 1NP5vQ0kXyGAIBG1NFKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dTDl3-0006Un-61; Thu, 06 Jul 2017 20:52:17 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dTDl2-0006OX-Ai for linux-mediatek@bombadil.infradead.org; Thu, 06 Jul 2017 20:52:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OZBcWYzisU0w9BbWPOGnU31eF2/bsLek80Ol0SiO9Bg=; b=b7pOae8YW+PIgqqW/h9QLn7a6z LcaptohN2X1nVTYEeXhbi3Pc7s+1+0rMnB0oluFPd5cIqRqpNyd9Gx4QyKdaCCkFlVZJ20aZwPiKR pP5b7SGu+CNYZ5t8moZii962chPj/F8A6Tx+MkRz5RMpH6EppVOdr/iS0aDwK6W5KHp5u/8ByDs+O +VcVGGF/0sLIm229K9E16kTEmaYSr73IT2tDIlXMkDUdd2h5PDTgM+o1VRoB3cdUxhhR0IsYRghqF GMSFHkNsglVBuhyHKVo6/1k88igOZzIwCpAKlNXo4Job9aaLXJ9Fc2P9ooD1CHQqW0o4mfMZ3kBln 7+4htPYA==; Received: from gateway32.websitewelcome.com ([192.185.145.182]) by merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dTDkz-00054A-Ej for linux-mediatek@lists.infradead.org; Thu, 06 Jul 2017 20:52:14 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 0A5AB765830 for ; Thu, 6 Jul 2017 15:51:28 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id TDkldEFEseE2kTDkldKKKv; Thu, 06 Jul 2017 15:51:59 -0500 Received: from [189.152.196.165] (port=37104 helo=embeddedgus) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1dTDkF-0009zb-N2; Thu, 06 Jul 2017 15:51:27 -0500 Date: Thu, 6 Jul 2017 15:51:27 -0500 From: "Gustavo A. R. Silva" To: Rick Chang , Bin Liu , Mauro Carvalho Chehab , Matthias Brugger Subject: [PATCH] mediatek: constify vb2_ops structure Message-ID: <20170706205127.GA20926@embeddedgus> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.196.165 X-Exim-ID: 1dTDkF-0009zb-N2 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.196.165]:37104 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 46 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gustavo A. R. Silva" , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct vb2_ops i@p = { ... }; @ok@ identifier r.i; struct vb2_queue e; position p; @@ e.ops = &i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct vb2_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva --- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c index 451a540..f17a86b 100644 --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c @@ -756,7 +756,7 @@ static void mtk_jpeg_stop_streaming(struct vb2_queue *q) pm_runtime_put_sync(ctx->jpeg->dev); } -static struct vb2_ops mtk_jpeg_qops = { +static const struct vb2_ops mtk_jpeg_qops = { .queue_setup = mtk_jpeg_queue_setup, .buf_prepare = mtk_jpeg_buf_prepare, .buf_queue = mtk_jpeg_buf_queue,