diff mbox

usb: xhci-mtk: fix ptr_ret.cocci warnings

Message ID 20171024163318.GA20883@lkp-wsm-ep2 (mailing list archive)
State New, archived
Headers show

Commit Message

Fengguang Wu Oct. 24, 2017, 4:33 p.m. UTC 
drivers/usb/host/xhci-mtk.c:256:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: b6bb72cf0df1 ("usb: xhci-mtk: add optional mcu and dma bus clocks")
CC: Chunfeng Yun <chunfeng.yun@mediatek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 xhci-mtk.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Chunfeng Yun Oct. 25, 2017, 1:11 a.m. UTC | #1 
On Wed, 2017-10-25 at 00:33 +0800, kbuild test robot wrote:
> drivers/usb/host/xhci-mtk.c:256:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> 
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Fixes: b6bb72cf0df1 ("usb: xhci-mtk: add optional mcu and dma bus clocks")
> CC: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
Thanks

Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

>  xhci-mtk.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -253,10 +253,7 @@ static int xhci_mtk_clks_get(struct xhci
>  		return PTR_ERR(mtk->mcu_clk);
>  
>  	mtk->dma_clk = optional_clk_get(dev, "dma_ck");
> -	if (IS_ERR(mtk->dma_clk))
> -		return PTR_ERR(mtk->dma_clk);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(mtk->dma_clk);
>  }
>  
>  static int xhci_mtk_clks_enable(struct xhci_hcd_mtk *mtk)
diff mbox

Patch

--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -253,10 +253,7 @@  static int xhci_mtk_clks_get(struct xhci
 		return PTR_ERR(mtk->mcu_clk);
 
 	mtk->dma_clk = optional_clk_get(dev, "dma_ck");
-	if (IS_ERR(mtk->dma_clk))
-		return PTR_ERR(mtk->dma_clk);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(mtk->dma_clk);
 }
 
 static int xhci_mtk_clks_enable(struct xhci_hcd_mtk *mtk)