From patchwork Wed Dec 26 07:53:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pi-Hsun Shih X-Patchwork-Id: 10742883 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B8CAB1399 for ; Wed, 26 Dec 2018 07:55:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A880F287C6 for ; Wed, 26 Dec 2018 07:55:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C3F1288C4; Wed, 26 Dec 2018 07:55:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 288DA287C6 for ; Wed, 26 Dec 2018 07:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T2iE4idF5J1h+hqScpbUxK8waGZ4ZE49nhsyj5o2hRw=; b=D7LyGuGk8+1wdr A2ymAi+Tm5dVmnYWrJvigiyhMCK85DHBtKrrc66l24xGk5jFfhUkDSyhrMtjn0kWVPMwTAGwKhhw0 /xFB+41V/JvGBOTihPOzfa0ZLjFdQEKT0G5tVwEqfEkoipbrGR2nWy/ey7hzDyoTNfLp6FI+hfx5J wG641Y+SumyqYVGM7Km3JsDzd12xtUL/7GCbKZBJMGk7vO/lreENeSIMKCfLiyIIY9515ZB+KU/iG PpP/gfhPExmxC6nC3X8ibVnETqXpfgl51vBz3kUDW0wKLvUrkOnNRTD2fcFzf69Drxxb6RDRlaExj I8NX1zD8b64eX/08exCw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gc42K-0000lK-1Y; Wed, 26 Dec 2018 07:55:28 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gc41N-0006ZX-PQ for linux-mediatek@lists.infradead.org; Wed, 26 Dec 2018 07:54:41 +0000 Received: by mail-pl1-x642.google.com with SMTP id 101so7271411pld.6 for ; Tue, 25 Dec 2018 23:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VFE5Q/expx9u5OAcUoGYir738UVsOttn1xCRe3b7ESk=; b=YBSkpL6ELxysiEDR1WlP0Jt/OWkV8QHrPo7e1QRsjZcA/yXiqhBE5uU0ePmN6uMMH/ 7yaZsKV9VWLlx8S1ADViAYPe6/H1hHPvdtz7FU7KbTjeFw3dN4lZaAR7F316cMOqaYqR eTGBw8j2i7V4/G+xCGXIMIlODu2P0XBYYjq1A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VFE5Q/expx9u5OAcUoGYir738UVsOttn1xCRe3b7ESk=; b=I/gQKhk0+SbW1PCmzpS4IxbmTaK0IcG/iW4OgOpHIFz2J6cCd3A9LOqifr5O7QAK41 BpNnov3NrrNsKwcmdx+Yv1kZhckiPbIa0/+5rdb64kvbRjDAVAsYLH6MWaFc1Me7OkEf 0/X+p43etC5fGXSTMZrIhSp6ulIXSLe+ZkkzBIB62HoeeavQSu5teOoyZczELdlPf9pk BoQ0ybGF0QMaP6lVicccWCa+NPZAPGsUxyrfv4RSWku8PWZnyO40A2THmfyHwejs3GEp AJReapDzFj4BSQwm4DWG0t22kFu/4KdIYUOiVW1HDq4llUbEnDEnqAqz1HmjeY357Ks/ EXaQ== X-Gm-Message-State: AJcUukdVDB8tg4SbAU9UC7iK5VrPAa7q9kDld1rQ3nCpf/fPM2TJTsfa I4qp5nAJMIYOYuT2tjR9cj4xzw== X-Google-Smtp-Source: ALg8bN54MM/dDBhCsTLRoHdoOmRtFl0m6Y30ZyOKKPjc3nFyFdj70pxkjvEAKApaXOt7DhSsOjvojg== X-Received: by 2002:a17:902:9a8b:: with SMTP id w11mr18448017plp.121.1545810856986; Tue, 25 Dec 2018 23:54:16 -0800 (PST) Received: from pihsun-z840.tpe.corp.google.com ([2401:fa00:1:10:7889:7a43:f899:134c]) by smtp.googlemail.com with ESMTPSA id 84sm107392395pfa.115.2018.12.25.23.54.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Dec 2018 23:54:16 -0800 (PST) From: Pi-Hsun Shih To: Subject: [RFC,4/5] rpmsg: add rpmsg support for mt8183 SCP. Date: Wed, 26 Dec 2018 15:53:12 +0800 Message-Id: <20181226075330.82462-5-pihsun@chromium.org> X-Mailer: git-send-email 2.20.1.415.g653613c723-goog In-Reply-To: <20181226075330.82462-1-pihsun@chromium.org> References: <20181226075330.82462-1-pihsun@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181225_235430_082121_848628BA X-CRM114-Status: GOOD ( 29.29 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben-Cohen , Nicolas Boichat , Erin Lo , "open list:REMOTE PROCESSOR REMOTEPROC SUBSYSTEM" , open list , Bjorn Andersson , "moderated list:ARM/Mediatek SoC support" , Pi-Hsun Shih , Matthias Brugger , Eddie Huang , "moderated list:ARM/Mediatek SoC support" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly. Signed-off-by: Pi-Hsun Shih --- There are lots of TODO comments on things that are not done yet / I have doubt on whether it's the best way to do it. drivers/remoteproc/mtk_common.h | 3 + drivers/remoteproc/mtk_scp.c | 30 ++- drivers/remoteproc/mtk_scp_ipi.c | 2 +- drivers/rpmsg/Kconfig | 5 + drivers/rpmsg/Makefile | 1 + drivers/rpmsg/mtk_rpmsg.c | 341 ++++++++++++++++++++++++++ include/linux/platform_data/mtk_scp.h | 7 + include/linux/rpmsg/mtk_rpmsg.h | 34 +++ 8 files changed, 419 insertions(+), 4 deletions(-) create mode 100644 drivers/rpmsg/mtk_rpmsg.c create mode 100644 include/linux/rpmsg/mtk_rpmsg.h diff --git a/drivers/remoteproc/mtk_common.h b/drivers/remoteproc/mtk_common.h index ae55fca2ce2d7..cdd4919a402a8 100644 --- a/drivers/remoteproc/mtk_common.h +++ b/drivers/remoteproc/mtk_common.h @@ -54,6 +54,9 @@ struct mtk_scp { void __iomem *cpu_addr; phys_addr_t phys_addr; size_t dram_size; + + struct platform_device *pdev; + struct rproc_subdev *rpmsg_subdev; }; /** diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index aaebe96bcfd66..0ed7904809dce 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -12,6 +12,7 @@ #include #include #include +#include #include "remoteproc_internal.h" #include "mtk_common.h" @@ -278,6 +279,24 @@ static int scp_map_memory_region(struct mtk_scp *scp) return 0; } +static void scp_add_rpmsg_subdev(struct mtk_scp *scp) +{ + scp->rpmsg_subdev = + mtk_rpmsg_create_rproc_subdev(scp->pdev, scp->rproc); + if (scp->rpmsg_subdev) { + rproc_add_subdev(scp->rproc, scp->rpmsg_subdev); + } +} + +static void scp_remove_rpmsg_subdev(struct mtk_scp *scp) +{ + if (scp->rpmsg_subdev) { + rproc_remove_subdev(scp->rproc, scp->rpmsg_subdev); + mtk_rpmsg_destroy_rproc_subdev(scp->rpmsg_subdev); + scp->rpmsg_subdev = NULL; + } +} + static int mtk_scp_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -301,6 +320,7 @@ static int mtk_scp_probe(struct platform_device *pdev) scp = (struct mtk_scp *)rproc->priv; scp->rproc = rproc; scp->dev = dev; + scp->pdev = pdev; platform_set_drvdata(pdev, scp); res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram"); @@ -372,13 +392,16 @@ static int mtk_scp_probe(struct platform_device *pdev) init_waitqueue_head(&scp->run.wq); init_waitqueue_head(&scp->ack_wq); + scp_add_rpmsg_subdev(scp); + ret = rproc_add(rproc); if (ret) - goto destroy_mutex; + goto remove_subdev; - return ret; + return 0; -destroy_mutex: +remove_subdev: + scp_remove_rpmsg_subdev(scp); mutex_destroy(&scp->scp_mutex); free_rproc: rproc_free(rproc); @@ -390,6 +413,7 @@ static int mtk_scp_remove(struct platform_device *pdev) { struct mtk_scp *scp = platform_get_drvdata(pdev); + scp_remove_rpmsg_subdev(scp); rproc_del(scp->rproc); rproc_free(scp->rproc); diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c index 6923066869874..1b72c5cc72d36 100644 --- a/drivers/remoteproc/mtk_scp_ipi.c +++ b/drivers/remoteproc/mtk_scp_ipi.c @@ -50,7 +50,7 @@ int scp_ipi_send(struct platform_device *pdev, unsigned long timeout; int ret; - if (WARN(id <= IPI_SCP_INIT || id >= IPI_MAX || + if (WARN(id <= IPI_NS_SERVICE || id >= IPI_MAX || len > sizeof(send_obj->share_buf) || !buf, "failed to send ipi message\n")) return -EINVAL; diff --git a/drivers/rpmsg/Kconfig b/drivers/rpmsg/Kconfig index d0322b41eca54..b8364a397bb60 100644 --- a/drivers/rpmsg/Kconfig +++ b/drivers/rpmsg/Kconfig @@ -55,4 +55,9 @@ config RPMSG_VIRTIO select RPMSG select VIRTIO +config RPMSG_MTK_SCP + tristate "MediaTek SCP" + depends on MTK_SCP + select RPMSG + endmenu diff --git a/drivers/rpmsg/Makefile b/drivers/rpmsg/Makefile index 9aa859502d275..a0c1dcefa36ee 100644 --- a/drivers/rpmsg/Makefile +++ b/drivers/rpmsg/Makefile @@ -6,3 +6,4 @@ obj-$(CONFIG_RPMSG_QCOM_GLINK_NATIVE) += qcom_glink_native.o obj-$(CONFIG_RPMSG_QCOM_GLINK_SMEM) += qcom_glink_smem.o obj-$(CONFIG_RPMSG_QCOM_SMD) += qcom_smd.o obj-$(CONFIG_RPMSG_VIRTIO) += virtio_rpmsg_bus.o +obj-$(CONFIG_RPMSG_MTK_SCP) += mtk_rpmsg.o diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c new file mode 100644 index 0000000000000..66b39eaae51f2 --- /dev/null +++ b/drivers/rpmsg/mtk_rpmsg.c @@ -0,0 +1,341 @@ +// SPDX-License-Identifier: GPL-2.0 +// +// Copyright 2018 Google LLC. + +#include +#include +#include +#include +#include +#include +#include +#include + +#include "rpmsg_internal.h" + +// TODO: This is built on top of scp_ipi_register / scp_ipi_send in mtk_scp.h. +// It's probably better to move the implementation of register / send to here +// instead of in remoteproc/mtk_scp_ipi.c +// TODO: Do we need some sort of vring for performance? We may be able to get +// rid of this file if so, but that would require SCP firmware support too. + +struct mtk_rpmsg_device { + struct rpmsg_device rpdev; + + struct platform_device *scp_pdev; +}; + +struct mtk_rpmsg_endpoint { + struct rpmsg_endpoint ept; + u32 ipi_id; + struct platform_device *scp_pdev; +}; + +// TODO: Naming is hard... +struct mtk_rpmsg_rproc_subdev { + struct rproc *scp_rproc; + struct platform_device *scp_pdev; + struct rpmsg_endpoint *ns_ept; + struct rproc_subdev subdev; +}; + +#define to_mtk_subdev(d) container_of(d, struct mtk_rpmsg_rproc_subdev, subdev); + +struct mtk_register_device_work { + struct work_struct register_work; + struct platform_device *scp_pdev; + char name[RPMSG_NAME_SIZE]; + u32 addr; +}; + +/** + * TODO: This is copied from virtio_rpmsg_bus. + * struct rpmsg_ns_msg - dynamic name service announcement message + * @name: name of remote service that is published + * @addr: address of remote service that is published + * + * This message is sent across to publish a new service, or announce + * about its removal. When we receive these messages, an appropriate + * rpmsg channel (i.e device) is created/destroyed. In turn, the ->probe() + * or ->remove() handler of the appropriate rpmsg driver will be invoked + * (if/as-soon-as one is registered). + */ +struct rpmsg_ns_msg { + char name[RPMSG_NAME_SIZE]; + u32 addr; +} __packed; + +#define to_scp_device(r) container_of(r, struct mtk_rpmsg_device, rpdev) +#define to_scp_endpoint(r) container_of(r, struct mtk_rpmsg_endpoint, ept) + +static const struct rpmsg_endpoint_ops mtk_rpmsg_endpoint_ops; + +static void __ept_release(struct kref *kref) +{ + struct rpmsg_endpoint *ept = container_of(kref, struct rpmsg_endpoint, + refcount); + kfree(to_scp_endpoint(ept)); +} + +static void mtk_rpmsg_ipi_handler(void *data, unsigned int len, void *priv) +{ + struct mtk_rpmsg_endpoint *mept = priv; + struct rpmsg_endpoint *ept = &mept->ept; + + // TODO: What if the cb() returns error? + (*ept->cb)(ept->rpdev, data, len, ept->priv, mept->ipi_id); +} + +static struct rpmsg_endpoint * +__rpmsg_create_ept(struct platform_device *scp_pdev, struct rpmsg_device *rpdev, + rpmsg_rx_cb_t cb, void *priv, + u32 id, const char *name) +{ + struct mtk_rpmsg_endpoint *mept; + struct rpmsg_endpoint *ept; + + int ret; + + mept = kzalloc(sizeof(*mept), GFP_KERNEL); + if (!mept) + return NULL; + mept->ipi_id = id; + mept->scp_pdev = scp_pdev; + + ept = &mept->ept; + kref_init(&ept->refcount); + + ept->rpdev = rpdev; + ept->cb = cb; + ept->priv = priv; + ept->ops = &mtk_rpmsg_endpoint_ops; + + ret = scp_ipi_register(scp_pdev, id, mtk_rpmsg_ipi_handler, name, mept); + if (ret) { + dev_err(&scp_pdev->dev, "ipi register failed, id = %d", id); + kref_put(&ept->refcount, __ept_release); + return NULL; + } + + return ept; +} + +static struct rpmsg_endpoint * +mtk_rpmsg_create_ept(struct rpmsg_device *rpdev, rpmsg_rx_cb_t cb, void *priv, + struct rpmsg_channel_info chinfo) +{ + struct platform_device *scp_pdev = to_scp_device(rpdev)->scp_pdev; + // TODO: Is using src as IPI id "correct"? + return __rpmsg_create_ept(scp_pdev, rpdev, cb, priv, chinfo.src, + chinfo.name); +} + +static const struct rpmsg_device_ops mtk_rpmsg_device_ops = { + .create_ept = mtk_rpmsg_create_ept, +}; + +static void mtk_rpmsg_destroy_ept(struct rpmsg_endpoint *ept) +{ + kref_put(&ept->refcount, __ept_release); +} + +static int __mtk_rpmsg_send(struct mtk_rpmsg_endpoint *mept, void *data, + int len, bool wait) +{ + // TODO: The "wait" is not same as what scp_ipi_send's "wait" means, so + // this is not correct. + // (first wait for there's space of tx buffer, second wait for the ack + // from scp.) + return scp_ipi_send(mept->scp_pdev, mept->ipi_id, data, len, + wait ? 200 : 0); +} + +static int mtk_rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len) +{ + struct mtk_rpmsg_endpoint *mept = to_scp_endpoint(ept); + + return __mtk_rpmsg_send(mept, data, len, true); +} + +static int mtk_rpmsg_trysend(struct rpmsg_endpoint *ept, void *data, int len) +{ + struct mtk_rpmsg_endpoint *mept = to_scp_endpoint(ept); + + return __mtk_rpmsg_send(mept, data, len, false); +} + +static const struct rpmsg_endpoint_ops mtk_rpmsg_endpoint_ops = { + .destroy_ept = mtk_rpmsg_destroy_ept, + .send = mtk_rpmsg_send, + .trysend = mtk_rpmsg_trysend, +}; + +static void mtk_rpmsg_release_device(struct device *dev) +{ + struct rpmsg_device *rpdev = to_rpmsg_device(dev); + struct mtk_rpmsg_device *mdev = to_scp_device(rpdev); + + kfree(mdev); +} + +static void mtk_register_device_work_function(struct work_struct *register_work) +{ + struct mtk_rpmsg_device *mdev; + struct rpmsg_device *rpdev; + + struct mtk_register_device_work *work = container_of( + register_work, struct mtk_register_device_work, register_work); + struct platform_device *scp_pdev = work->scp_pdev; + + int ret; + + mdev = kzalloc(sizeof(*mdev), GFP_KERNEL); + if (!mdev) { + goto free_work; + } + + mdev->scp_pdev = scp_pdev; + + rpdev = &mdev->rpdev; + rpdev->ops = &mtk_rpmsg_device_ops; + rpdev->src = work->addr; + rpdev->dst = RPMSG_ADDR_ANY; + strncpy(rpdev->id.name, work->name, RPMSG_NAME_SIZE); + + rpdev->dev.parent = &scp_pdev->dev; + rpdev->dev.release = mtk_rpmsg_release_device; + + ret = rpmsg_register_device(rpdev); + + if (ret) { + dev_err(&scp_pdev->dev, "rpmsg register device failed\n"); + goto free_work; + } + return; + +free_work: + // TODO: Is it reasonable to free the work itself in the handler? + kfree(register_work); +} + +static int mtk_rpmsg_create_device(struct platform_device *scp_pdev, + char *name, u32 addr) +{ + struct mtk_register_device_work *work; + + // This is called in interrupt context from name service callback. + work = kzalloc(sizeof(*work), GFP_ATOMIC); + if (!work) + return -ENOMEM; + + INIT_WORK(&work->register_work, mtk_register_device_work_function); + work->scp_pdev = scp_pdev; + strncpy(work->name, name, RPMSG_NAME_SIZE); + work->addr = addr; + // rpmsg_register_device can't be called in interrupt context, so need + // to schedule a work for it. + // TODO: Or should we change mtk_scp to call the callback in + // non-interrupt context? + schedule_work(&work->register_work); + return 0; +} + +static int mtk_rpmsg_ns_cb(struct rpmsg_device *rpdev, void *data, int len, + void *priv, u32 src) +{ + struct rpmsg_ns_msg *msg = data; + struct platform_device *scp_pdev = priv; + struct device *dev = &scp_pdev->dev; + + int ret; + + if (len != sizeof(*msg)) { + dev_err(dev, "malformed ns msg (%d)\n", len); + return -EINVAL; + } + + /* + * the name service ept does _not_ belong to a real rpmsg channel, + * and is handled by the rpmsg bus itself. + * for sanity reasons, make sure a valid rpdev has _not_ sneaked + * in somehow. + */ + if (rpdev) { + dev_err(dev, "anomaly: ns ept has an rpdev handle\n"); + return -EINVAL; + } + + /* don't trust the remote processor for null terminating the name */ + msg->name[RPMSG_NAME_SIZE - 1] = '\0'; + + dev_info(dev, "creating channel %s addr 0x%x\n", msg->name, msg->addr); + + ret = mtk_rpmsg_create_device(scp_pdev, msg->name, msg->addr); + if (ret) { + dev_err(dev, "create rpmsg device failed\n"); + return ret; + } + + return 0; +} + +int mtk_rpmsg_prepare(struct rproc_subdev *subdev) +{ + struct mtk_rpmsg_rproc_subdev *mtk_subdev; + struct platform_device *scp_pdev; + + mtk_subdev = to_mtk_subdev(subdev); + scp_pdev = mtk_subdev->scp_pdev; + + /* a dedicated endpoint handles the name service msgs */ + mtk_subdev->ns_ept = + __rpmsg_create_ept(scp_pdev, NULL, mtk_rpmsg_ns_cb, scp_pdev, + IPI_NS_SERVICE, "name-service"); + if (!mtk_subdev->ns_ept) { + dev_err(&scp_pdev->dev, + "failed to create name service endpoint\n"); + return -ENOMEM; + } + + return 0; +} + +void mtk_rpmsg_unprepare(struct rproc_subdev *subdev) +{ + struct mtk_rpmsg_rproc_subdev *mtk_subdev = to_mtk_subdev(subdev); + + kref_put(&mtk_subdev->ns_ept->refcount, __ept_release); + // TODO: unregister all rpmsg devices created by name service here. +} + +struct rproc_subdev * +mtk_rpmsg_create_rproc_subdev(struct platform_device *scp_pdev, + struct rproc *scp_rproc) +{ + struct mtk_rpmsg_rproc_subdev *mtk_subdev; + struct device *dev = &scp_pdev->dev; + + mtk_subdev = kzalloc(sizeof(*mtk_subdev), GFP_KERNEL); + if (!mtk_subdev) { + dev_err(dev, "allocate rproc subdevice failed.\n"); + return NULL; + } + mtk_subdev->scp_pdev = scp_pdev; + mtk_subdev->scp_rproc = scp_rproc; + mtk_subdev->subdev.prepare = mtk_rpmsg_prepare; + mtk_subdev->subdev.unprepare = mtk_rpmsg_unprepare; + + return &mtk_subdev->subdev; +} +EXPORT_SYMBOL_GPL(mtk_rpmsg_create_rproc_subdev); + +void mtk_rpmsg_destroy_rproc_subdev(struct rproc_subdev *subdev) +{ + struct mtk_rpmsg_rproc_subdev *mtk_subdev = to_mtk_subdev(subdev); + + kfree(mtk_subdev); +} +EXPORT_SYMBOL_GPL(mtk_rpmsg_destroy_rproc_subdev); + +MODULE_LICENSE("GPL v2"); +MODULE_DESCRIPTION("MediaTek scp rpmsg driver"); diff --git a/include/linux/platform_data/mtk_scp.h b/include/linux/platform_data/mtk_scp.h index 118838c91564f..4b3cf4f63fbe9 100644 --- a/include/linux/platform_data/mtk_scp.h +++ b/include/linux/platform_data/mtk_scp.h @@ -27,7 +27,14 @@ typedef void (*ipi_handler_t) (void *data, enum ipi_id { IPI_SCP_INIT = 0, + // TODO: Should this just be part of the response of IPI_SCP_INIT + // instead? e.g. the initial IPI_SCP_INIT from SCP sends a list of + // channels. + IPI_NS_SERVICE, IPI_MDP, + // TODO: Since we'll not be having all IPI numbers here after the name + // service & rpmsg, this IPI_MAX need to be manually specified and sync + // with the firmware. IPI_MAX, }; diff --git a/include/linux/rpmsg/mtk_rpmsg.h b/include/linux/rpmsg/mtk_rpmsg.h new file mode 100644 index 0000000000000..c55dbd658dde1 --- /dev/null +++ b/include/linux/rpmsg/mtk_rpmsg.h @@ -0,0 +1,34 @@ +// SPDX-License-Identifier: GPL-2.0 +// +// Copyright 2018 Google LLC. + +#ifndef __LINUX_RPMSG_MTK_RPMSG_H +#define __LINUX_RPMSG_MTK_RPMSG_H + +#include +#include + +#if IS_ENABLED(CONFIG_RPMSG_MTK_SCP) + +struct rproc_subdev * +mtk_rpmsg_create_rproc_subdev(struct platform_device *scp_pdev, + struct rproc *scp_rproc); + +void mtk_rpmsg_destroy_rproc_subdev(struct rproc_subdev *subdev); + +#else + +static inline struct rproc_subdev * +mtk_rpmsg_create_rproc_subdev(struct platform_device *scp_pdev, + struct rproc *scp_rproc) +{ + return NULL; +} + +static inline void mtk_rpmsg_destroy_rproc_subdev(struct rproc_subdev *subdev) +{ +} + +#endif + +#endif