| Message ID | 20190429085116.60081-2-xiaolei.li@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Re-license MTK NAND driver | expand |
On 2019-04-29 10:51, Xiaolei Li wrote: > It is allowed to use MTK NAND driver with GPL-2.0 or MIT license. What do you mean by "It is allowed"? According to the license it's rather not. Did you mean something like "It it wanted"? > But now it is only licensed as GPL-2.0. > So re-license it as dual MIT/GPL and replace license text with > SPDX tag. > > Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > Acked-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> > Acked-by: Ryder Lee <ryder.lee@mediatek.com> My development involvement was trivial/minimal, so I'm OK if that's what most developers want. Acked-by: Rafał Miłecki <rafal@milecki.pl>
Hi Rafał, On Mon, 2019-04-29 at 11:41 +0200, Rafał Miłecki wrote: > On 2019-04-29 10:51, Xiaolei Li wrote: > > It is allowed to use MTK NAND driver with GPL-2.0 or MIT license. > > What do you mean by "It is allowed"? According to the license it's > rather not. > > Did you mean something like "It it wanted"? > Thanks for your ACK and your suggestion. "It is wanted" sounds more properly. > > > But now it is only licensed as GPL-2.0. > > So re-license it as dual MIT/GPL and replace license text with > > SPDX tag. > > > > Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > > Acked-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> > > Acked-by: Ryder Lee <ryder.lee@mediatek.com> > > My development involvement was trivial/minimal, so I'm OK if that's what > most > developers want. > > Acked-by: Rafał Miłecki <rafal@milecki.pl> Thanks, Xiaolei
Hi Richard, Miquel, Up to now, Xiaolei Li <xiaolei.li@mediatek.com> (the author and major contributor), Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> (the author and major contributor), Ryder Lee <ryder.lee@mediatek.com> (developer), Rafał Miłecki <rafal@milecki.pl> (developer) sent ACK for this RFC patch. May I ask if it is enough to accept this change? Or should I wait for other developer's response? Thanks, Xiaolei On Mon, 2019-04-29 at 11:41 +0200, Rafał Miłecki wrote: > On 2019-04-29 10:51, Xiaolei Li wrote: > > It is allowed to use MTK NAND driver with GPL-2.0 or MIT license. > > What do you mean by "It is allowed"? According to the license it's > rather not. > > Did you mean something like "It it wanted"? > > > > But now it is only licensed as GPL-2.0. > > So re-license it as dual MIT/GPL and replace license text with > > SPDX tag. > > > > Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > > Acked-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> > > Acked-by: Ryder Lee <ryder.lee@mediatek.com> > > My development involvement was trivial/minimal, so I'm OK if that's what > most > developers want. > > Acked-by: Rafał Miłecki <rafal@milecki.pl>
On 2019-05-05 11:12, xiaolei li wrote: > Up to now, > Xiaolei Li <xiaolei.li@mediatek.com> (the author and major > contributor), > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> (the author and > major contributor), > Ryder Lee <ryder.lee@mediatek.com> (developer), > Rafał Miłecki <rafal@milecki.pl> (developer) > sent ACK for this RFC patch. > > May I ask if it is enough to accept this change? Or should I wait for > other developer's response? I can't imagine re-licensing someone's work without a permission. The best you can do is ignoring contributors that submitted changes that aren't really copyrightable (something like fixing a comment typo, some auto-generated diff-s). I used following command to check mtk_nand.c file history: # git log --follow drivers/mtd/nand/raw/mtk_nand.c | grep "Signed-off-by" | sort | uniq -c | sort -r -n 19 Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> 18 Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> 15 Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> 6 Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> 3 Signed-off-by: RogerCC Lin <rogercc.lin@mediatek.com> 2 Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com> 1 Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> 1 Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> 1 Signed-off-by: Rafał Miłecki <rafal@milecki.pl> 1 Signed-off-by: Peter Pan <peterpandong@micron.com> 1 Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 1 Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> Ideally you should still get acks from: 1) Miquel Contributor of 21 changes 2) Boris Contributor of 33 changes 3) RogerCC Contributor of 3 changes: 98dea8d71931 ("mtd: nand: mtk: Support MT7622 NAND flash controller.") b45ee5501ede ("mtd: nand: mtk: Support different MTK NAND flash controller IP") 559e58e7ed2d ("mtd: nand: fix chances to create incomplete ECC data when writing") 4) Wei Contributor of 1 change: 07f76443ef81 ("mtd: nand: mediatek: remove redundant dev_err call in mtk_nfc_probe()") 5) Peter Contributor of 1 change: d4092d76a4a4 ("mtd: nand: Rename nand.h into rawnand.h") 6) Masahiro Contributor of 1 change: f0dbe4aa35e7 ("mtd: nand: mediatek: return error code of nand_scan_ident/tail() on error") I guess we could accept your patch without acks from Wei, Peter and Masahiro. You definitely need an approval from Miquel, Boris and RogerCC. It doesn't seem you took this re-licensing task too seriously. Please pay more attention to this licensing problem, you can start with doing a similar research for mtk_ecc.c and mtk_ecc.h.
Hi Rafal, On Sun, 2019-05-05 at 17:06 +0200, Rafał Miłecki wrote: > On 2019-05-05 11:12, xiaolei li wrote: > > Up to now, > > Xiaolei Li <xiaolei.li@mediatek.com> (the author and major > > contributor), > > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> (the author and > > major contributor), > > Ryder Lee <ryder.lee@mediatek.com> (developer), > > Rafał Miłecki <rafal@milecki.pl> (developer) > > sent ACK for this RFC patch. > > > > May I ask if it is enough to accept this change? Or should I wait for > > other developer's response? > > I can't imagine re-licensing someone's work without a permission. I have no intention to offend other's contribution. That is why I sent this RFC patch to ask for ACKs from contributors. > > The best you can do is ignoring contributors that submitted changes that > aren't really copyrightable (something like fixing a comment typo, some > auto-generated diff-s). > > I used following command to check mtk_nand.c file history: > # git log --follow drivers/mtd/nand/raw/mtk_nand.c | grep > "Signed-off-by" | sort | uniq -c | sort -r -n > 19 Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > 18 Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > 15 Signed-off-by: Boris Brezillon > <boris.brezillon@free-electrons.com> > 6 Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > 3 Signed-off-by: RogerCC Lin <rogercc.lin@mediatek.com> > 2 Signed-off-by: Miquel Raynal > <miquel.raynal@free-electrons.com> > 1 Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > 1 Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > 1 Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > 1 Signed-off-by: Peter Pan <peterpandong@micron.com> > 1 Signed-off-by: Masahiro Yamada > <yamada.masahiro@socionext.com> > 1 Signed-off-by: Jorge Ramirez-Ortiz > <jorge.ramirez-ortiz@linaro.org> > > Ideally you should still get acks from: > > 1) Miquel > Contributor of 21 changes > > 2) Boris > Contributor of 33 changes > > 3) RogerCC > Contributor of 3 changes: > 98dea8d71931 ("mtd: nand: mtk: Support MT7622 NAND flash controller.") > b45ee5501ede ("mtd: nand: mtk: Support different MTK NAND flash > controller IP") > 559e58e7ed2d ("mtd: nand: fix chances to create incomplete ECC data when > writing") > > 4) Wei > Contributor of 1 change: > 07f76443ef81 ("mtd: nand: mediatek: remove redundant dev_err call in > mtk_nfc_probe()") > > 5) Peter > Contributor of 1 change: > d4092d76a4a4 ("mtd: nand: Rename nand.h into rawnand.h") > > 6) Masahiro > Contributor of 1 change: > f0dbe4aa35e7 ("mtd: nand: mediatek: return error code of > nand_scan_ident/tail() on error") > > I guess we could accept your patch without acks from Wei, Peter and > Masahiro. > > You definitely need an approval from Miquel, Boris and RogerCC. > > It doesn't seem you took this re-licensing task too seriously. > > Please pay more attention to this licensing problem, you can start with > doing > a similar research for mtk_ecc.c and mtk_ecc.h. Thanks for your ACK and good suggestion. It is really helpful for me. Thanks, Xiaolei
Hi xiaolei, xiaolei li <xiaolei.li@mediatek.com> wrote on Mon, 6 May 2019 08:56:20 +0800: > Hi Rafal, > > On Sun, 2019-05-05 at 17:06 +0200, Rafał Miłecki wrote: > > On 2019-05-05 11:12, xiaolei li wrote: > > > Up to now, > > > Xiaolei Li <xiaolei.li@mediatek.com> (the author and major > > > contributor), > > > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> (the author and > > > major contributor), > > > Ryder Lee <ryder.lee@mediatek.com> (developer), > > > Rafał Miłecki <rafal@milecki.pl> (developer) > > > sent ACK for this RFC patch. > > > > > > May I ask if it is enough to accept this change? Or should I wait for > > > other developer's response? > > > > I can't imagine re-licensing someone's work without a permission. > > I have no intention to offend other's contribution. > That is why I sent this RFC patch to ask for ACKs from contributors. > > > > > The best you can do is ignoring contributors that submitted changes that > > aren't really copyrightable (something like fixing a comment typo, some > > auto-generated diff-s). > > > > I used following command to check mtk_nand.c file history: > > # git log --follow drivers/mtd/nand/raw/mtk_nand.c | grep > > "Signed-off-by" | sort | uniq -c | sort -r -n > > 19 Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > 18 Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > > 15 Signed-off-by: Boris Brezillon > > <boris.brezillon@free-electrons.com> > > 6 Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > > 3 Signed-off-by: RogerCC Lin <rogercc.lin@mediatek.com> > > 2 Signed-off-by: Miquel Raynal > > <miquel.raynal@free-electrons.com> > > 1 Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > 1 Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > > 1 Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > 1 Signed-off-by: Peter Pan <peterpandong@micron.com> > > 1 Signed-off-by: Masahiro Yamada > > <yamada.masahiro@socionext.com> > > 1 Signed-off-by: Jorge Ramirez-Ortiz > > <jorge.ramirez-ortiz@linaro.org> > > > > Ideally you should still get acks from: > > > > 1) Miquel > > Contributor of 21 changes > > > > 2) Boris > > Contributor of 33 changes > > > > 3) RogerCC > > Contributor of 3 changes: > > 98dea8d71931 ("mtd: nand: mtk: Support MT7622 NAND flash controller.") > > b45ee5501ede ("mtd: nand: mtk: Support different MTK NAND flash > > controller IP") > > 559e58e7ed2d ("mtd: nand: fix chances to create incomplete ECC data when > > writing") > > > > 4) Wei > > Contributor of 1 change: > > 07f76443ef81 ("mtd: nand: mediatek: remove redundant dev_err call in > > mtk_nfc_probe()") > > > > 5) Peter > > Contributor of 1 change: > > d4092d76a4a4 ("mtd: nand: Rename nand.h into rawnand.h") > > > > 6) Masahiro > > Contributor of 1 change: > > f0dbe4aa35e7 ("mtd: nand: mediatek: return error code of > > nand_scan_ident/tail() on error") > > > > I guess we could accept your patch without acks from Wei, Peter and > > Masahiro. > > > > You definitely need an approval from Miquel, Boris and RogerCC. Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Let's wait for RogerCC and Boris acks. Thanks Rafał for the details. > > > > It doesn't seem you took this re-licensing task too seriously. > > > > Please pay more attention to this licensing problem, you can start with > > doing > > a similar research for mtk_ecc.c and mtk_ecc.h. > > Thanks for your ACK and good suggestion. It is really helpful for me. > > Thanks, > Xiaolei > Thanks, Miquèl
On Mon, 6 May 2019 08:56:20 +0800 xiaolei li <xiaolei.li@mediatek.com> wrote: > Hi Rafal, > > On Sun, 2019-05-05 at 17:06 +0200, Rafał Miłecki wrote: > > On 2019-05-05 11:12, xiaolei li wrote: > > > Up to now, > > > Xiaolei Li <xiaolei.li@mediatek.com> (the author and major > > > contributor), > > > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> (the author and > > > major contributor), > > > Ryder Lee <ryder.lee@mediatek.com> (developer), > > > Rafał Miłecki <rafal@milecki.pl> (developer) > > > sent ACK for this RFC patch. > > > > > > May I ask if it is enough to accept this change? Or should I wait for > > > other developer's response? > > > > I can't imagine re-licensing someone's work without a permission. > > I have no intention to offend other's contribution. > That is why I sent this RFC patch to ask for ACKs from contributors. > > > > > The best you can do is ignoring contributors that submitted changes that > > aren't really copyrightable (something like fixing a comment typo, some > > auto-generated diff-s). > > > > I used following command to check mtk_nand.c file history: > > # git log --follow drivers/mtd/nand/raw/mtk_nand.c | grep > > "Signed-off-by" | sort | uniq -c | sort -r -n > > 19 Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > 18 Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > > 15 Signed-off-by: Boris Brezillon > > <boris.brezillon@free-electrons.com> > > 6 Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > > 3 Signed-off-by: RogerCC Lin <rogercc.lin@mediatek.com> > > 2 Signed-off-by: Miquel Raynal > > <miquel.raynal@free-electrons.com> > > 1 Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > 1 Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > > 1 Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > 1 Signed-off-by: Peter Pan <peterpandong@micron.com> > > 1 Signed-off-by: Masahiro Yamada > > <yamada.masahiro@socionext.com> > > 1 Signed-off-by: Jorge Ramirez-Ortiz > > <jorge.ramirez-ortiz@linaro.org> > > > > Ideally you should still get acks from: > > > > 1) Miquel > > Contributor of 21 changes > > > > 2) Boris > > Contributor of 33 changes Not sure that's really necessary given the type of changes done in those 33 commits (mostly mechanical changes due to modifications in the NAND framework), but here is my Acked-by: Boris Brezillon <boris.brezillon@collabora.com> > > > > 3) RogerCC > > Contributor of 3 changes: > > 98dea8d71931 ("mtd: nand: mtk: Support MT7622 NAND flash controller.") > > b45ee5501ede ("mtd: nand: mtk: Support different MTK NAND flash > > controller IP") > > 559e58e7ed2d ("mtd: nand: fix chances to create incomplete ECC data when > > writing") > > > > 4) Wei > > Contributor of 1 change: > > 07f76443ef81 ("mtd: nand: mediatek: remove redundant dev_err call in > > mtk_nfc_probe()") > > > > 5) Peter > > Contributor of 1 change: > > d4092d76a4a4 ("mtd: nand: Rename nand.h into rawnand.h") > > > > 6) Masahiro > > Contributor of 1 change: > > f0dbe4aa35e7 ("mtd: nand: mediatek: return error code of > > nand_scan_ident/tail() on error") > > > > I guess we could accept your patch without acks from Wei, Peter and > > Masahiro. > > > > You definitely need an approval from Miquel, Boris and RogerCC. > > > > It doesn't seem you took this re-licensing task too seriously. > > > > Please pay more attention to this licensing problem, you can start with > > doing > > a similar research for mtk_ecc.c and mtk_ecc.h. > > Thanks for your ACK and good suggestion. It is really helpful for me. > > Thanks, > Xiaolei >
Miquel, Boris, thanks for your ACK. On Mon, 2019-05-06 at 10:18 +0200, Boris Brezillon wrote: > On Mon, 6 May 2019 08:56:20 +0800 > xiaolei li <xiaolei.li@mediatek.com> wrote: > > > Hi Rafal, > > > > On Sun, 2019-05-05 at 17:06 +0200, Rafał Miłecki wrote: > > > On 2019-05-05 11:12, xiaolei li wrote: > > > > Up to now, > > > > Xiaolei Li <xiaolei.li@mediatek.com> (the author and major > > > > contributor), > > > > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> (the author and > > > > major contributor), > > > > Ryder Lee <ryder.lee@mediatek.com> (developer), > > > > Rafał Miłecki <rafal@milecki.pl> (developer) > > > > sent ACK for this RFC patch. > > > > > > > > May I ask if it is enough to accept this change? Or should I wait for > > > > other developer's response? > > > > > > I can't imagine re-licensing someone's work without a permission. > > > > I have no intention to offend other's contribution. > > That is why I sent this RFC patch to ask for ACKs from contributors. > > > > > > > > The best you can do is ignoring contributors that submitted changes that > > > aren't really copyrightable (something like fixing a comment typo, some > > > auto-generated diff-s). > > > > > > I used following command to check mtk_nand.c file history: > > > # git log --follow drivers/mtd/nand/raw/mtk_nand.c | grep > > > "Signed-off-by" | sort | uniq -c | sort -r -n > > > 19 Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > 18 Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > > > 15 Signed-off-by: Boris Brezillon > > > <boris.brezillon@free-electrons.com> > > > 6 Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > > > 3 Signed-off-by: RogerCC Lin <rogercc.lin@mediatek.com> > > > 2 Signed-off-by: Miquel Raynal > > > <miquel.raynal@free-electrons.com> > > > 1 Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > > 1 Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > > > 1 Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > > 1 Signed-off-by: Peter Pan <peterpandong@micron.com> > > > 1 Signed-off-by: Masahiro Yamada > > > <yamada.masahiro@socionext.com> > > > 1 Signed-off-by: Jorge Ramirez-Ortiz > > > <jorge.ramirez-ortiz@linaro.org> > > > > > > Ideally you should still get acks from: > > > > > > 1) Miquel > > > Contributor of 21 changes > > > > > > 2) Boris > > > Contributor of 33 changes > > Not sure that's really necessary given the type of changes done in those > 33 commits (mostly mechanical changes due to modifications in the NAND > framework), but here is my > > Acked-by: Boris Brezillon <boris.brezillon@collabora.com> > > > > > > > 3) RogerCC > > > Contributor of 3 changes: > > > 98dea8d71931 ("mtd: nand: mtk: Support MT7622 NAND flash controller.") > > > b45ee5501ede ("mtd: nand: mtk: Support different MTK NAND flash > > > controller IP") > > > 559e58e7ed2d ("mtd: nand: fix chances to create incomplete ECC data when > > > writing") > > > > > > 4) Wei > > > Contributor of 1 change: > > > 07f76443ef81 ("mtd: nand: mediatek: remove redundant dev_err call in > > > mtk_nfc_probe()") > > > > > > 5) Peter > > > Contributor of 1 change: > > > d4092d76a4a4 ("mtd: nand: Rename nand.h into rawnand.h") > > > > > > 6) Masahiro > > > Contributor of 1 change: > > > f0dbe4aa35e7 ("mtd: nand: mediatek: return error code of > > > nand_scan_ident/tail() on error") > > > > > > I guess we could accept your patch without acks from Wei, Peter and > > > Masahiro. > > > > > > You definitely need an approval from Miquel, Boris and RogerCC. > > > > > > It doesn't seem you took this re-licensing task too seriously. > > > > > > Please pay more attention to this licensing problem, you can start with > > > doing > > > a similar research for mtk_ecc.c and mtk_ecc.h. > > > > Thanks for your ACK and good suggestion. It is really helpful for me. > > > > Thanks, > > Xiaolei > > >
On Mon, 2019-05-06 at 17:11 +0800, xiaolei li wrote: > Miquel, Boris, thanks for your ACK. > > On Mon, 2019-05-06 at 10:18 +0200, Boris Brezillon wrote: > > On Mon, 6 May 2019 08:56:20 +0800 > > xiaolei li <xiaolei.li@mediatek.com> wrote: > > > > > Hi Rafal, > > > > > > On Sun, 2019-05-05 at 17:06 +0200, Rafał Miłecki wrote: > > > > On 2019-05-05 11:12, xiaolei li wrote: > > > > > Up to now, > > > > > Xiaolei Li <xiaolei.li@mediatek.com> (the author and major > > > > > contributor), > > > > > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> (the author and > > > > > major contributor), > > > > > Ryder Lee <ryder.lee@mediatek.com> (developer), > > > > > Rafał Miłecki <rafal@milecki.pl> (developer) > > > > > sent ACK for this RFC patch. > > > > > > > > > > May I ask if it is enough to accept this change? Or should I wait for > > > > > other developer's response? > > > > > > > > I can't imagine re-licensing someone's work without a permission. > > > > > > I have no intention to offend other's contribution. > > > That is why I sent this RFC patch to ask for ACKs from contributors. > > > > > > > > > > > The best you can do is ignoring contributors that submitted changes that > > > > aren't really copyrightable (something like fixing a comment typo, some > > > > auto-generated diff-s). > > > > > > > > I used following command to check mtk_nand.c file history: > > > > # git log --follow drivers/mtd/nand/raw/mtk_nand.c | grep > > > > "Signed-off-by" | sort | uniq -c | sort -r -n > > > > 19 Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > 18 Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > > > > 15 Signed-off-by: Boris Brezillon > > > > <boris.brezillon@free-electrons.com> > > > > 6 Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > > > > 3 Signed-off-by: RogerCC Lin <rogercc.lin@mediatek.com> > > > > 2 Signed-off-by: Miquel Raynal > > > > <miquel.raynal@free-electrons.com> > > > > 1 Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > > > 1 Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > > > > 1 Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > > > 1 Signed-off-by: Peter Pan <peterpandong@micron.com> > > > > 1 Signed-off-by: Masahiro Yamada > > > > <yamada.masahiro@socionext.com> > > > > 1 Signed-off-by: Jorge Ramirez-Ortiz > > > > <jorge.ramirez-ortiz@linaro.org> > > > > > > > > Ideally you should still get acks from: > > > > > > > > 1) Miquel > > > > Contributor of 21 changes > > > > > > > > 2) Boris > > > > Contributor of 33 changes > > > > Not sure that's really necessary given the type of changes done in those > > 33 commits (mostly mechanical changes due to modifications in the NAND > > framework), but here is my > > > > Acked-by: Boris Brezillon <boris.brezillon@collabora.com> > > > > > > > > > > 3) RogerCC > > > > Contributor of 3 changes: > > > > 98dea8d71931 ("mtd: nand: mtk: Support MT7622 NAND flash controller.") > > > > b45ee5501ede ("mtd: nand: mtk: Support different MTK NAND flash > > > > controller IP") > > > > 559e58e7ed2d ("mtd: nand: fix chances to create incomplete ECC data when > > > > writing") > > > > Acked-by: RogerCC Lin <rogercc.lin@mediatek.com> > > > > 4) Wei > > > > Contributor of 1 change: > > > > 07f76443ef81 ("mtd: nand: mediatek: remove redundant dev_err call in > > > > mtk_nfc_probe()") > > > > > > > > 5) Peter > > > > Contributor of 1 change: > > > > d4092d76a4a4 ("mtd: nand: Rename nand.h into rawnand.h") > > > > > > > > 6) Masahiro > > > > Contributor of 1 change: > > > > f0dbe4aa35e7 ("mtd: nand: mediatek: return error code of > > > > nand_scan_ident/tail() on error") > > > > > > > > I guess we could accept your patch without acks from Wei, Peter and > > > > Masahiro. > > > > > > > > You definitely need an approval from Miquel, Boris and RogerCC. > > > > > > > > It doesn't seem you took this re-licensing task too seriously. > > > > > > > > Please pay more attention to this licensing problem, you can start with > > > > doing > > > > a similar research for mtk_ecc.c and mtk_ecc.h. > > > > > > Thanks for your ACK and good suggestion. It is really helpful for me. > > > > > > Thanks, > > > Xiaolei > > > > > >
On Mon, 2019-05-06 at 17:11 +0800, xiaolei li wrote: > Miquel, Boris, thanks for your ACK. > > On Mon, 2019-05-06 at 10:18 +0200, Boris Brezillon wrote: > > On Mon, 6 May 2019 08:56:20 +0800 > > xiaolei li <xiaolei.li@mediatek.com> wrote: > > > > > Hi Rafal, > > > > > > On Sun, 2019-05-05 at 17:06 +0200, Rafał Miłecki wrote: > > > > On 2019-05-05 11:12, xiaolei li wrote: > > > > > Up to now, > > > > > Xiaolei Li <xiaolei.li@mediatek.com> (the author and major > > > > > contributor), > > > > > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> (the author and > > > > > major contributor), > > > > > Ryder Lee <ryder.lee@mediatek.com> (developer), > > > > > Rafał Miłecki <rafal@milecki.pl> (developer) > > > > > sent ACK for this RFC patch. > > > > > > > > > > May I ask if it is enough to accept this change? Or should I wait for > > > > > other developer's response? > > > > > > > > I can't imagine re-licensing someone's work without a permission. > > > > > > I have no intention to offend other's contribution. > > > That is why I sent this RFC patch to ask for ACKs from contributors. > > > > > > > > > > > The best you can do is ignoring contributors that submitted changes that > > > > aren't really copyrightable (something like fixing a comment typo, some > > > > auto-generated diff-s). > > > > > > > > I used following command to check mtk_nand.c file history: > > > > # git log --follow drivers/mtd/nand/raw/mtk_nand.c | grep > > > > "Signed-off-by" | sort | uniq -c | sort -r -n > > > > 19 Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > 18 Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > > > > 15 Signed-off-by: Boris Brezillon > > > > <boris.brezillon@free-electrons.com> > > > > 6 Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > > > > 3 Signed-off-by: RogerCC Lin <rogercc.lin@mediatek.com> > > > > 2 Signed-off-by: Miquel Raynal > > > > <miquel.raynal@free-electrons.com> > > > > 1 Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > > > 1 Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > > > > 1 Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > > > 1 Signed-off-by: Peter Pan <peterpandong@micron.com> > > > > 1 Signed-off-by: Masahiro Yamada > > > > <yamada.masahiro@socionext.com> > > > > 1 Signed-off-by: Jorge Ramirez-Ortiz > > > > <jorge.ramirez-ortiz@linaro.org> > > > > > > > > Ideally you should still get acks from: > > > > > > > > 1) Miquel > > > > Contributor of 21 changes > > > > > > > > 2) Boris > > > > Contributor of 33 changes > > > > Not sure that's really necessary given the type of changes done in those > > 33 commits (mostly mechanical changes due to modifications in the NAND > > framework), but here is my > > > > Acked-by: Boris Brezillon <boris.brezillon@collabora.com> > > > > > > > > > > 3) RogerCC > > > > Contributor of 3 changes: > > > > 98dea8d71931 ("mtd: nand: mtk: Support MT7622 NAND flash controller.") > > > > b45ee5501ede ("mtd: nand: mtk: Support different MTK NAND flash > > > > controller IP") > > > > 559e58e7ed2d ("mtd: nand: fix chances to create incomplete ECC data when > > > > writing") > > > > It's OK for me. Acked-by: RogerCC Lin <rogercc.lin@mediatek.com> > > > > 4) Wei > > > > Contributor of 1 change: > > > > 07f76443ef81 ("mtd: nand: mediatek: remove redundant dev_err call in > > > > mtk_nfc_probe()") > > > > > > > > 5) Peter > > > > Contributor of 1 change: > > > > d4092d76a4a4 ("mtd: nand: Rename nand.h into rawnand.h") > > > > > > > > 6) Masahiro > > > > Contributor of 1 change: > > > > f0dbe4aa35e7 ("mtd: nand: mediatek: return error code of > > > > nand_scan_ident/tail() on error") > > > > > > > > I guess we could accept your patch without acks from Wei, Peter and > > > > Masahiro. > > > > > > > > You definitely need an approval from Miquel, Boris and RogerCC. > > > > > > > > It doesn't seem you took this re-licensing task too seriously. > > > > > > > > Please pay more attention to this licensing problem, you can start with > > > > doing > > > > a similar research for mtk_ecc.c and mtk_ecc.h. > > > > > > Thanks for your ACK and good suggestion. It is really helpful for me. > > > > > > Thanks, > > > Xiaolei > > > > > >
diff --git a/drivers/mtd/nand/raw/mtk_ecc.c b/drivers/mtd/nand/raw/mtk_ecc.c index 6432bd70c3b3..eea0f903bc24 100644 --- a/drivers/mtd/nand/raw/mtk_ecc.c +++ b/drivers/mtd/nand/raw/mtk_ecc.c @@ -1,17 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0 OR MIT /* * MTK ECC controller driver. * Copyright (C) 2016 MediaTek Inc. * Authors: Xiaolei Li <xiaolei.li@mediatek.com> * Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. */ #include <linux/platform_device.h> @@ -600,4 +592,4 @@ module_platform_driver(mtk_ecc_driver); MODULE_AUTHOR("Xiaolei Li <xiaolei.li@mediatek.com>"); MODULE_DESCRIPTION("MTK Nand ECC Driver"); -MODULE_LICENSE("GPL"); +MODULE_LICENSE("Dual MIT/GPL"); diff --git a/drivers/mtd/nand/raw/mtk_ecc.h b/drivers/mtd/nand/raw/mtk_ecc.h index a455df080952..0e48c36e6ca0 100644 --- a/drivers/mtd/nand/raw/mtk_ecc.h +++ b/drivers/mtd/nand/raw/mtk_ecc.h @@ -1,12 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 OR MIT */ /* * MTK SDG1 ECC controller * * Copyright (c) 2016 Mediatek * Authors: Xiaolei Li <xiaolei.li@mediatek.com> * Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> - * This program is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 as published - * by the Free Software Foundation. */ #ifndef __DRIVERS_MTD_NAND_MTK_ECC_H__ diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c index b6b4602f5132..3cbc25793062 100644 --- a/drivers/mtd/nand/raw/mtk_nand.c +++ b/drivers/mtd/nand/raw/mtk_nand.c @@ -1,17 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0 OR MIT /* * MTK NAND Flash controller driver. * Copyright (C) 2016 MediaTek Inc. * Authors: Xiaolei Li <xiaolei.li@mediatek.com> * Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. */ #include <linux/platform_device.h> @@ -1598,6 +1590,6 @@ static struct platform_driver mtk_nfc_driver = { module_platform_driver(mtk_nfc_driver); -MODULE_LICENSE("GPL"); +MODULE_LICENSE("Dual MIT/GPL"); MODULE_AUTHOR("Xiaolei Li <xiaolei.li@mediatek.com>"); MODULE_DESCRIPTION("MTK Nand Flash Controller Driver");