| Message ID | 20200617014928.4374-1-yunfei.dong@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] media: v4l UAPI: add V4L2_BUF_CAP_SUPPORTS_RO_REQUESTS | expand |
Hi Yunfei, On Wed, Jun 17, 2020 at 09:49:27AM +0800, Yunfei Dong wrote: > This patch adds support for the V4L2_BUF_CAP_SUPPORTS_RO_REQUESTS > flag. This flag is used for RO Request. I think this patch series lacks two major things: - a cover letter explaining the feature and what it is needed/useful for, - a user - is there an upstream driver which would implement this feature and benefit from it? Best regards, Tomasz
Hi Tomasz, Thanks for your advice. I have submitted patch v2, could you please help to review again. changed compared with v1: -- add cover-letter -- change commit message of patch 01/02 -- change commit message of patch 02/02 Best Regards, Yunfei Dong On Thu, 2020-06-18 at 17:52 +0000, Tomasz Figa wrote: > Hi Yunfei, > > On Wed, Jun 17, 2020 at 09:49:27AM +0800, Yunfei Dong wrote: > > This patch adds support for the V4L2_BUF_CAP_SUPPORTS_RO_REQUESTS > > flag. This flag is used for RO Request. > > I think this patch series lacks two major things: > - a cover letter explaining the feature and what it is needed/useful > for, > - a user - is there an upstream driver which would implement this > feature and benefit from it? > > Best regards, > Tomasz
diff --git a/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst b/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst index b6d52083707b..7c7451773b8e 100644 --- a/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst +++ b/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst @@ -126,6 +126,7 @@ aborting or finishing any DMA in progress, an implicit .. _V4L2-BUF-CAP-SUPPORTS-REQUESTS: .. _V4L2-BUF-CAP-SUPPORTS-ORPHANED-BUFS: .. _V4L2-BUF-CAP-SUPPORTS-M2M-HOLD-CAPTURE-BUF: +.. _V4L2-BUF-CAP-SUPPORTS-RO-REQUESTS: .. cssclass:: longtable @@ -156,6 +157,9 @@ aborting or finishing any DMA in progress, an implicit - Only valid for stateless decoders. If set, then userspace can set the ``V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF`` flag to hold off on returning the capture buffer until the OUTPUT timestamp changes. + * - ``V4L2_BUF_CAP_SUPPORTS_RO_REQUESTS`` + - 0x00000040 + - This buffer type supports :ref:`requests <media-request-api>`. Return Value ============
This patch adds support for the V4L2_BUF_CAP_SUPPORTS_RO_REQUESTS flag. This flag is used for RO Request. Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com> --- Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst | 4 ++++ 1 file changed, 4 insertions(+)