| Message ID | 20200727074124.3779237-1-hsinyi@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: mt8173: elm: Fix nor_flash node property | expand |
Hi Hsin-Yi, Thank you for your patch. On 27/7/20 9:41, Hsin-Yi Wang wrote: > bus-width and non-removable is not used by the driver. > max-frequency should be spi-max-frequency for flash node. > > Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board") > Reported-by: Nicolas Boichat <drinkcat@chromium.org> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index a5a12b2599a4..01522dd10603 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -431,12 +431,11 @@ &nor_flash { > status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&nor_gpio1_pins>; > - bus-width = <8>; > - max-frequency = <50000000>; > - non-removable; > + > flash@0 { > compatible = "jedec,spi-nor"; > reg = <0>; > + spi-max-frequency = <50000000>; > }; > }; > >
On Fri, Jul 31, 2020 at 7:21 PM Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > Hi Hsin-Yi, > > Thank you for your patch. > > On 27/7/20 9:41, Hsin-Yi Wang wrote: > > bus-width and non-removable is not used by the driver. > > max-frequency should be spi-max-frequency for flash node. > > > > Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board") > > Reported-by: Nicolas Boichat <drinkcat@chromium.org> > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Gentle ping.
On 27/07/2020 09:41, Hsin-Yi Wang wrote: > bus-width and non-removable is not used by the driver. > max-frequency should be spi-max-frequency for flash node. > > Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board") > Reported-by: Nicolas Boichat <drinkcat@chromium.org> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> Applied to v5.9-next/dts64 Thanks! > --- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index a5a12b2599a4..01522dd10603 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -431,12 +431,11 @@ &nor_flash { > status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&nor_gpio1_pins>; > - bus-width = <8>; > - max-frequency = <50000000>; > - non-removable; > + > flash@0 { > compatible = "jedec,spi-nor"; > reg = <0>; > + spi-max-frequency = <50000000>; > }; > }; > >
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi index a5a12b2599a4..01522dd10603 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi @@ -431,12 +431,11 @@ &nor_flash { status = "okay"; pinctrl-names = "default"; pinctrl-0 = <&nor_gpio1_pins>; - bus-width = <8>; - max-frequency = <50000000>; - non-removable; + flash@0 { compatible = "jedec,spi-nor"; reg = <0>; + spi-max-frequency = <50000000>; }; };
bus-width and non-removable is not used by the driver. max-frequency should be spi-max-frequency for flash node. Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board") Reported-by: Nicolas Boichat <drinkcat@chromium.org> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)