| Message ID | 20210709034308.21713-1-jason-jh.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] drm/mediatek: Add component_del in OVL remove function | expand |
Hi, Jason: On Fri, 2021-07-09 at 11:43 +0800, jason-jh.lin wrote: > Add component_del in OVL remove function to make it symmetrical > to component_add in probe function. > > Fixes: ff1395609e20 ("drm/mediatek: Move mtk_ddp_comp_init() from sub driver to DRM driver") > In patch [1], both OVL and COLOR has the same problem. I would like you to fix both bug. It could be in one patch. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.14-rc5&id=ff1395609e20c1cd98b3ec65d16dc18f0471dca3 Regards, CK > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > index 961f87f8d4d1..081c96aa7f72 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > @@ -158,7 +158,6 @@ void mtk_ovl_stop(struct device *dev) > reg = reg & ~OVL_LAYER_SMI_ID_EN; > writel_relaxed(reg, ovl->regs + DISP_REG_OVL_DATAPATH_CON); > } > - > } > > void mtk_ovl_config(struct device *dev, unsigned int w, > @@ -424,6 +423,8 @@ static int mtk_disp_ovl_probe(struct platform_device *pdev) > > static int mtk_disp_ovl_remove(struct platform_device *pdev) > { > + component_del(&pdev->dev, &mtk_disp_ovl_component_ops); > + > return 0; > } >
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 961f87f8d4d1..081c96aa7f72 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c @@ -158,7 +158,6 @@ void mtk_ovl_stop(struct device *dev) reg = reg & ~OVL_LAYER_SMI_ID_EN; writel_relaxed(reg, ovl->regs + DISP_REG_OVL_DATAPATH_CON); } - } void mtk_ovl_config(struct device *dev, unsigned int w, @@ -424,6 +423,8 @@ static int mtk_disp_ovl_probe(struct platform_device *pdev) static int mtk_disp_ovl_remove(struct platform_device *pdev) { + component_del(&pdev->dev, &mtk_disp_ovl_component_ops); + return 0; }
Add component_del in OVL remove function to make it symmetrical to component_add in probe function. Fixes: ff1395609e20 ("drm/mediatek: Move mtk_ddp_comp_init() from sub driver to DRM driver") Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)