From patchwork Fri Apr 8 01:39:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 12805992 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFD86C433EF for ; Fri, 8 Apr 2022 01:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ckvv8xKYsDx/Z4XVnqRcdWxIKbwYJq3E+m7qNCq/zTw=; b=iPayU1v4wBTvnk r/3ARJeq5ICj9HJQEXWRq2fpeU1DGjPLaSHDdjpccNYV9TswIdWp/KJWY32igiWi4XfOQzaFbkWwY ovpJfBdYc42+HDzyBt0fKEz1LtA2Z4zu8YX4PHhHMIp3eOxL/ZCpkkHJc1bNvdcd32USUbyYEkmlv l5Cr0pt/yBMzPI5Gcd3+5EkZRyf4B0bEjVZ+IEnghspF8By0Z2FUhRR5fdKLT2gNe6aUsLPD7O/yX 0cuRgYtrN+UR7rV+nKBNj8Ag1C4gSv+3Ydem1THrD2z6CIiwQHg5qmke0BIvof6Ft1iWZSu4ypOdp gJSTO1unfcuAvOAHRO7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncdbd-00EYxc-Ez; Fri, 08 Apr 2022 01:40:09 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncdbR-00EYup-SD; Fri, 08 Apr 2022 01:39:59 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id 2E48A1F46A39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649381996; bh=Zoo0D97gEmqNrY989eMksqTtr9Q81mrxj7dB1t09D6s=; h=From:To:Cc:Subject:Date:From; b=SQ9QUQfCr2e2hvpXJL9p427drhnonB1hrAQ8NW3YHYwSh7XMHkrq68aZorlrf21qK rxNjA+g4ONZ9RezDcpv3/OYQjrUaiaBo0tlbsPaodSI0pBtpPdm0c1Y8JNg25LcGCM ocvAOI7iADHCPaxskD5eQYeZ12t3qdFf3IL4SHC8tItqZiP4fJyVaoUdoTvKwCFjRH ToDi6AZ2yynJchpugZDEsMe2PFFwramN38bqAYBmAhKLHqP73XvYN5dhhOI7eWrDCT 5zhHtBpnbQ7QB55NIwNBTgjUNfbVLGYhetLLKjxnMm/NGfObTwaDWENbbgBENwLMlD CJpl9ajw90Gjg== From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: Philipp Zabel , Chun-Kuang Hu Cc: AngeloGioacchino Del Regno , kernel@collabora.com, =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Vetter , David Airlie , Jitao Shi , Matthias Brugger , Rex-BC Chen , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192 Date: Thu, 7 Apr 2022 21:39:50 -0400 Message-Id: <20220408013950.674477-1-nfraprado@collabora.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_183958_082802_41186B6A X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The configuration for mt8192 was incorrectly using the output formats from mt8173. Since the output formats for mt8192 are instead the same ones as for mt8183, which require two bus samples per pixel, the pixelclock and DDR edge setting were misconfigured. This made external displays unable to show the image. Fix the issue by correcting the output format for mt8192 to be the same as for mt8183, fixing the usage of external displays for mt8192. Fixes: be63f6e8601f ("drm/mediatek: dpi: Add output bus formats to driver data") Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen --- Changes in v2: - Added Fixes tag drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 4554e2de1430..e61cd67b978f 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf = { .cal_factor = mt8183_calculate_factor, .reg_h_fre_con = 0xe0, .max_clock_khz = 150000, - .output_fmts = mt8173_output_fmts, - .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), + .output_fmts = mt8183_output_fmts, + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts), }; static int mtk_dpi_probe(struct platform_device *pdev)